1. 26 9月, 2015 1 次提交
  2. 13 8月, 2015 1 次提交
    • F
      Drive hot-unplug: reliable parsing of HMP results · 69a3b0df
      Frank Schreuder 提交于
      Hot-unplugging a disk from a guest that supports hot-unplugging generates an error
      in the libvirt log when running QEMU with the "-msg timestamp=on" flag.
      
      2015-08-06 10:48:59.945+0000: 11662: error : qemuMonitorTextDriveDel:2594 :
      operation failed: deleting drive-virtio-disk4 drive failed:
      2015-08-06T10:48:59.945058Z Device 'drive-virtio-disk4' not found
      
      This error is caused because the HMP results are getting prefixed with a timestamp.
      Parsing the output is not reliable with STRPREFIX as the results can be prefixed with a timestamp.
      
      Using strstr ensures that parsing the output works whether the results are prefixed or not.
      
      Cc: Stefan Hajnoczi <stefanha@redhat.com>
      Cc: Daniel P. Berrange <berrange@redhat.com>
      Signed-off-by: NFrank Schreuder <fschreuder@transip.nl>
      69a3b0df
  3. 10 7月, 2015 1 次提交
  4. 26 6月, 2015 1 次提交
  5. 03 6月, 2015 2 次提交
  6. 02 4月, 2015 1 次提交
    • J
      Remove unused macros · a0482396
      Ján Tomko 提交于
      In the order of appearance:
      
      * MAX_LISTEN - never used
        added by 23ad665c (qemud) and addec57 (lock daemon)
      
      * NEXT_FREE_CLASS_ID - never used, added by 07d1b6b5
      
      * virLockError - never used, added by eb8268a4
      
      * OPENVZ_MAX_ARG, CMDBUF_LEN, CMDOP_LEN
        unused since the removal of ADD_ARG_LIT in d8b31306
      
      * QEMU_NB_PER_CPU_STAT_PARAM - unused since 897808e7
      
      * QEMU_CMD_PROMPT, QEMU_PASSWD_PROMPT - unused since 1dc10a7b
      
      * TEST_MODEL_WORDSIZE - unused since c25c18f7
      
      * TEMPDIR - never used, added by 714bef5b
      
      * NSIG - workaround around old headers
        added by commit 60ed1d2a
        unused since virExec was moved by commit 02e86910
      
      * DO_TEST_PARSE - never used, added by 9afa0060
      
      * DIFF_MSEC, GETTIMEOFDAY - unused since eee6eb66
      a0482396
  7. 11 3月, 2015 4 次提交
    • P
      qemu: monitor: Kill qemuMonitorGetBlockStats(Info,ParamsNumber) · d3534a43
      Peter Krempa 提交于
      The functions and their QMP and HMP implementations are no longer needed
      since everything is now done via the *AllStats functions.
      d3534a43
    • P
      qemu: monitor: Count block stats fields in qemuMonitorGetAllBlockStatsInfo · bdc05128
      Peter Krempa 提交于
      Our virDomainBlockStatsFlags API uses the old approach where, when it's
      called without the typed parameter array, returns the count of parameters
      supported by qemu.
      
      The supported parameter count is obtained via separate monitor calls
      which is a waste since we can calculate it when gathering the data.
      
      This patch adds code to the qemuMonitorGetAllBlockStatsInfo workers that
      allows to track the count of supported fields reported by qemu and will
      allow to remove the old duplicate code.
      bdc05128
    • P
      qemu: monitor: Implement HMP version for listing all block device stats · f6563bc3
      Peter Krempa 提交于
      Add a different version of parser for "info blockstats" that basically
      parses the same information as the existing copy of the function.
      
      This will allow us to remove the single device version
      qemuMonitorGetBlockStatsInfo in the future.
      
      The new implementation uses few new helpers so it should be more
      understandable and provides a test case to verify that it works.
      f6563bc3
    • P
      qemu: monitor: Drop parsing of 'errs' from block info · 32288fc9
      Peter Krempa 提交于
      The error count statistic is not supported by qemu, so there's no need
      to pass the variables around if the result is ignored anyways.
      32288fc9
  8. 24 11月, 2014 1 次提交
    • P
      qemu: chardev: Extract more information about character devices · 4d7eb903
      Peter Krempa 提交于
      Improve the monitor function to also retrieve the guest state of
      character device (if provided) so that we can refresh the state of
      virtio-serial channels and perhaps react to changes in the state in
      future patches.
      
      This patch changes the returned data from qemuMonitorGetChardevInfo to
      return a structure containing the pty path and the state for all the
      character devices.
      
      The change to the testsuite makes sure that the data is parsed
      correctly.
      4d7eb903
  9. 21 11月, 2014 1 次提交
  10. 15 11月, 2014 1 次提交
  11. 18 9月, 2014 1 次提交
  12. 04 9月, 2014 1 次提交
    • E
      maint: use consistent if-else braces in qemu · 44e30277
      Eric Blake 提交于
      I'm about to add a syntax check that enforces our documented
      HACKING style of always using matching {} on if-else statements.
      
      This commit focuses on the qemu driver.
      
      * src/qemu/qemu_command.c (qemuParseISCSIString)
      (qemuParseCommandLineDisk, qemuParseCommandLine)
      (qemuBuildSmpArgStr, qemuBuildCommandLine)
      (qemuParseCommandLineDisk, qemuParseCommandLineSmp): Correct use
      of {}.
      * src/qemu/qemu_capabilities.c (virQEMUCapsProbeCPUModels):
      Likewise.
      * src/qemu/qemu_driver.c (qemuDomainCoreDumpWithFormat)
      (qemuDomainRestoreFlags, qemuDomainGetInfo)
      (qemuDomainMergeBlkioDevice): Likewise.
      * src/qemu/qemu_hotplug.c (qemuDomainAttachNetDevice): Likewise.
      * src/qemu/qemu_monitor_text.c (qemuMonitorTextCreateSnapshot)
      (qemuMonitorTextLoadSnapshot, qemuMonitorTextDeleteSnapshot):
      Likewise.
      * src/qemu/qemu_process.c (qemuProcessStop): Likewise.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      44e30277
  13. 03 7月, 2014 1 次提交
    • J
      Use virBufferCheckError everywhere we report OOM error · 92a8e72f
      Ján Tomko 提交于
      Replace:
      if (virBufferError(&buf)) {
          virBufferFreeAndReset(&buf);
          virReportOOMError();
          ...
      }
      
      with:
      if (virBufferCheckError(&buf) < 0)
          ...
      
      This should not be a functional change (unless some callers
      misused the virBuffer APIs - a different error would be reported
      then)
      92a8e72f
  14. 03 6月, 2014 1 次提交
  15. 06 5月, 2014 1 次提交
    • L
      qemu: specify domain in host-side PCI addresses when needed/supported · 1e947cf7
      Laine Stump 提交于
      This uses the new QEMU_CAPS_HOST_PCI_MULTIDOMAIN capability when
      present, for -devivce pci-assign, -device vfio-pci, and -pcidevice.
      
      While creating tests for this new functionality, I noticed that the
      xmls for two existing tests had erroneously specified an
      until-now-ignored domain="0x0002", so I corrected those two tests, and
      also added two failure tests to be sure that we alert users who
      attempt to use a non-zero domain with a qemu that doesn't support it.
      1e947cf7
  16. 08 4月, 2014 1 次提交
  17. 25 3月, 2014 1 次提交
  18. 21 3月, 2014 1 次提交
  19. 18 3月, 2014 2 次提交
  20. 10 3月, 2014 1 次提交
  21. 11 7月, 2013 1 次提交
  22. 10 7月, 2013 1 次提交
  23. 07 6月, 2013 1 次提交
  24. 06 6月, 2013 1 次提交
  25. 23 5月, 2013 1 次提交
  26. 21 5月, 2013 1 次提交
  27. 02 5月, 2013 1 次提交
    • M
      virutil: Move string related functions to virstring.c · 7c9a2d88
      Michal Privoznik 提交于
      The source code base needs to be adapted as well. Some files
      include virutil.h just for the string related functions (here,
      the include is substituted to match the new file), some include
      virutil.h without any need (here, the include is removed), and
      some require both.
      7c9a2d88
  28. 21 3月, 2013 2 次提交
  29. 15 3月, 2013 1 次提交
    • L
      Remove contiguous CPU indexes assumption · cc78d7ba
      Li Zhang 提交于
      When getting CPUs' information, it assumes that CPU indexes
      are not contiguous. But for ppc64 platform, CPU indexes are not
      contiguous because SMT is needed to be disabled, so CPU information
      is not right on ppc64 and vpuinfo, vcpupin can't work corretly.
      
      This patch is to remove the assumption to be compatible with ppc64.
      
      Test:
         4 vcpus are assigned to one VM and execute vcpuinfo command.
      
         Without patch: There is only one vcpu informaion can be listed.
         With patch: All vcpus' information can be listed correctly.
      Signed-off-by: NLi Zhang <zhlcindy@linux.vnet.ibm.com>
      cc78d7ba
  30. 23 2月, 2013 1 次提交
  31. 25 1月, 2013 1 次提交
  32. 21 12月, 2012 3 次提交