1. 19 8月, 2016 6 次提交
  2. 18 8月, 2016 6 次提交
    • J
      cfg.mk: join not_streq and not_strneq tests · f9785569
      Ján Tomko 提交于
      The marginally nicer error message is not worth the extra lines in
      cfg.mk.
      
      Also drop the excludes since there was only one offender in the tests.
      f9785569
    • J
      cfg.mk: drop redundant sc_prohibit_gethostby · b3e3fc32
      Ján Tomko 提交于
      Both gethostbyaddr and gethostbyname* are already checked
      by sc_prohibit_nonreentrant.
      b3e3fc32
    • J
      cfg.mk: use subst instead of tr · 1fe77f9f
      Ján Tomko 提交于
      GNU make is able to replace characters, no need to call tr.
      1fe77f9f
    • J
      tests: fix the return value of test-wrap-argv · 5e045eca
      Ján Tomko 提交于
      The script was returning success unless it failed on the last file.
      This went unnoticed because sc_prohibit_long_lines forbids lines
      longer than 90 characters in .arg[sv] files.
      5e045eca
    • J
      maint: update to latest gnulib · 212564a0
      Ján Tomko 提交于
      Pick up the new syntax-check speedups.
      212564a0
    • J
      Introduce QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY · 41f5c2ca
      Ján Tomko 提交于
      Check whether the disable-legacy property is present on the following
      devices:
        virtio-balloon-pci
        virtio-blk-pci
        virtio-scsi-pci
        virtio-serial-pci
        virtio-9p-pci
        virtio-net-pci
        virtio-rng-pci
        virtio-gpu-pci
        virtio-input-host-pci
        virtio-keyboard-pci
        virtio-mouse-pci
        virtio-tablet-pci
      
      Assuming that if QEMU knows other virtio devices where this property
      is applicable, it will have at least one of these devices.
      
      Added in QEMU by:
      commit e266d421490e0ae83044bbebb209b2d3650c0ba6
          virtio-pci: add flags to enable/disable legacy/modern
      41f5c2ca
  3. 17 8月, 2016 9 次提交
  4. 16 8月, 2016 13 次提交
  5. 15 8月, 2016 4 次提交
    • J
      Introduce node device update event as top level event · 43a6b37b
      Jovanka Gulicoska 提交于
      This event is emitted when a nodedev XML definition is updated,
      like when cdrom media is changed in a cdrom block device.
      
      Also includes node device update event implementation for udev
      backend, virsh nodedev-event support, and event-test support
      43a6b37b
    • J
      virsh: Fix core for cmdSecretGetValue · 18701e9d
      John Ferlan 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1366611
      
      When commit id 'cb2e3e50' reworked the cmdSecretGetValue call to use
      VIR_DISPOSE_STRING for base64, it neglected to initialize the base64
      value to NULL since the cleanup: label could be reached prior to the
      base64 value being set or not.  This resulted in a core dump, adding
      the initialization will avoid the issue.
      18701e9d
    • P
      qemu_command: don't modify heads for graphics device · ef11e770
      Pavel Hrdina 提交于
      Setting heads to 0 in case that *max_outputs* is not supported while building
      command line doesn't have any real effect.  It only removes *heads* attribute
      from live XML, but after restarting libvirt the default value is restored.
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      ef11e770
    • M
      virschematest: Make sure that validator is initialized · cba18f8a
      Michal Privoznik 提交于
      It may happen that a developer wants to run just a specific
      subset of tests:
      
      tests $ VIR_TEST_RANGE=22 ../run ./virschematest
      
      This now fails miserably:
      
          ==6840== Invalid read of size 8
          ==6840==    at 0x4F397C0: virXMLValidatorValidate (virxml.c:1216)
          ==6840==    by 0x402B72: testSchemaFile (virschematest.c:53)
          ==6840==    by 0x403737: virTestRun (testutils.c:180)
          ==6840==    by 0x402CF5: testSchemaDir (virschematest.c:98)
          ==6840==    by 0x402EB1: testSchemaDirs (virschematest.c:131)
          ==6840==    by 0x40314D: mymain (virschematest.c:194)
          ==6840==    by 0x4051AF: virTestMain (testutils.c:982)
          ==6840==    by 0x4035A9: main (virschematest.c:217)
          ==6840==  Address 0x10 is not stack'd, malloc'd or (recently) free'd
      
      Problem is, we are trying to do two types of tests here: validate
      RNG schema itself, and validate XML files against RNG schemas.
      And the latter tries to re-use a resource allocated in the
      former. Therefore if the former is skipped (due to
      VIR_TEST_RANGE) we have to allocate the resource manually.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      cba18f8a
  6. 13 8月, 2016 1 次提交
    • J
      cpu_x86: fix libvirtd crash when host cpu vendor is not available · 541e9ae6
      Jim Fehlig 提交于
      When starting a guest and copying host vendor cpuid to the guest
      cpu, libvirtd would crash if the host cpu contained a NULL vendor
      field. Avoid the crash by checking for a valid vendor in the host
      cpu before copying the cpuid to the guest cpu.
      
      For completeness, here is a backtrace from the crash
      
      (gdb) bt
      f0  0x00007ffff739bf33 in x86DataCpuid (cpuid=0x8, cpuid=0x8,
          data=data@entry=0x7fffb800ee78) at cpu/cpu_x86.c:287
      f1  virCPUx86DataAddCPUID (data=data@entry=0x7fffb800ee78, cpuid=0x8)
          at cpu/cpu_x86.c:355
      f2  0x00007ffff739ef47 in x86Compute (host=<optimized out>, cpu=0x7fffb8000cc0,
          guest=0x7fffecca7348, message=<optimized out>) at cpu/cpu_x86.c:1580
      f3  0x00007fffd2b38e53 in qemuBuildCpuModelArgStr (migrating=false,
          hasHwVirt=<synthetic pointer>, qemuCaps=0x7fffb8001040, buf=0x7fffecca7360,
          def=0x7fffc400ce20, driver=0x1c) at qemu/qemu_command.c:6283
      f4  qemuBuildCpuCommandLine (cmd=cmd@entry=0x7fffb8002f60,
          driver=driver@entry=0x7fffc80882c0, def=def@entry=0x7fffc400ce20,
          qemuCaps=qemuCaps@entry=0x7fffb8001040, migrating=<optimized out>)
          at qemu/qemu_command.c:6445
      (gdb) f2
      (gdb) p *host_model
      $23 = {name = 0x7fffb800ec50 "qemu64", vendor = 0x0, signature = 0, data = {
          len = 2, data = 0x7fffb800e720}}
      541e9ae6
  7. 12 8月, 2016 1 次提交