- 25 2月, 2020 34 次提交
-
-
由 Ján Tomko 提交于
This lets us mock functions from the libxl driver. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NJim Fehlig <jfehlig@suse.com>
-
由 Ján Tomko 提交于
Point the logDir to abs_builddir instead. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NJim Fehlig <jfehlig@suse.com>
-
由 Ján Tomko 提交于
Take the parts affected by the host state out of DriverConfigNew and put them into a separate function. Adjust all the callers to call both functions. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NJim Fehlig <jfehlig@suse.com>
-
由 Ján Tomko 提交于
Use g_autofree to free the driver config file path. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NJim Fehlig <jfehlig@suse.com>
-
由 Ján Tomko 提交于
These hardcoded defaults do not need to be read from the file. Move them out of libxlDriverConfigLoadFile. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NJim Fehlig <jfehlig@suse.com>
-
由 Ján Tomko 提交于
libxlDriverConfigNew can possibly fail on wrong firmware values (unlikely) or on failure to create the log directory (possible if you're debugging tests with VIR_FILE_ACCESS) Signed-off-by: NJán Tomko <jtomko@redhat.com> Fixes: 4a4132b4Reviewed-by: NJim Fehlig <jfehlig@suse.com>
-
由 Michal Privoznik 提交于
The way that our file locking works is that we open() the file we want to lock and then use fcntl(fd, F_SETLKW, ...) to lock it. The problem is, we are doing all of these as root which doesn't work if the file lives on root squashed NFS, because if it does then the open() fails. The way to resolve this is to make this a non fatal error and leave callers deal with this (i.e. disable remembering) - implemented in the previous commit. https://bugzilla.redhat.com/show_bug.cgi?id=1804672Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NPeter Krempa <pkrempa@redhat.com>
-
由 Michal Privoznik 提交于
There are some cases where we want to remember the original owner of a file but we fail to lock it for XATTR change (e.g. root squashed NFS). If that is the case we error out and refuse to start a domain. Well, we can do better if we disable remembering for paths we haven't locked successfully. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NPeter Krempa <pkrempa@redhat.com>
-
由 Michal Privoznik 提交于
So far, in the lock state we are storing only the file descriptors of the files we've locked. Therefore, when unlocking them and something does wrong the only thing we can report is FD number, which is not user friendly at all. But if we store paths among with FDs we can do better error reporting. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NPeter Krempa <pkrempa@redhat.com>
-
由 Daniel P. Berrangé 提交于
The virutil.h header defines a geteuid() macro for Windows platforms. This fixes a few missed cases from: commit b11e8ccc Author: Ján Tomko <jtomko@redhat.com> Date: Sun Feb 16 23:09:15 2020 +0100 Remove virutil.h from all header files Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Daniel P. Berrangé 提交于
The autoreconf script will already run aclocal for us, so there's no need to do that ahead of time. Reviewed-by: NJán Tomko <jtomko@redhat.com> Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Ján Tomko 提交于
Signed-off-by: NJán Tomko <jtomko@redhat.com> Fixes: b11e8ccc
-
由 Jim Fehlig 提交于
Commit fb01e1a4 missed including virutil.h, causing the following compilation error ../../src/security/virt-aa-helper.c:1055:43: error: implicit declaration of function 'virHostGetDRMRenderNode' [-Werror=implicit-function-declaration] 1055 | char *defaultRenderNode = virHostGetDRMRenderNode(); Signed-off-by: NJim Fehlig <jfehlig@suse.com>
-
由 Ján Tomko 提交于
After the split of enum functions into virenum.h, this function does not contain anything worth including in another header file. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
Include virutil.h in all files that use it, instead of relying on it being pulled in somehow. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
Include unistd.h in all files that use it, instead of relying on it being pulled in via virutil.h Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
After the introduction of virenum.h in commit 285c5f28, it is only needed in the C file. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
Include both virutil.h and unistd.h. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
There is nothing in the vircgroup.h header file requiring virutil.h. Remove it and include unistd.h in the C files. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
These tests do not use anything from virutil.h apart from the transitive include. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
Historically, this file was a dump for most of our helper functions and needed almost everywhere. With the introduction of virfile.h and virstring.h, and more importantly, virenum.h and the introduction of GLib, that is no longer true. Remove its include from C files that don't even use it. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
-
由 Ján Tomko 提交于
Now that it is no longer used. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NLaine Stump <laine@redhat.com>
-
由 Ján Tomko 提交于
Replace it by g_ascii_xdigit_value. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NLaine Stump <laine@redhat.com>
-
由 Ján Tomko 提交于
Prefer g_ascii_xdigit_value to virHexToBin. Check the return value of the function and remove the g_ascii_isxdigit calls, since they're done anyway internally. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NLaine Stump <laine@redhat.com>
-
由 Ján Tomko 提交于
When moving virclosecallbacks to src/hypervisor, I did not adjust all the possible includes in Makefiles. Use a path relative to src to fix the build. Signed-off-by: NJán Tomko <jtomko@redhat.com> Fixes: 25c29ac2
-
由 Ryan Moeller 提交于
This *is* a no-op, but there was a period of sickening dread while auditing to be sure that no actual confusion between bus and slot had occurred. I hope to avoid that by following the conventional order. Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
Reduce the complexity by isolating loop bodies in separate functions. Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
Pull the code for registering and unregistering a bhyve monitor object into separate functions to improve code clarity. Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
This makes lifecycle management a bit easier thanks to ref counting, and it is closer to what the qemu driver does. Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
The file is opened O_APPEND. Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
由 Ryan Moeller 提交于
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NRyan Moeller <ryan@iXsystems.com>
-
- 24 2月, 2020 6 次提交
-
-
由 Ján Tomko 提交于
Just like virhostdev, this depends on domain_conf and it's shared by multiple hypervisor drivers. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Ján Tomko 提交于
This module depends on domain_conf and is used directly by various hypervisor drivers. Move it to src/hypervisor. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Ján Tomko 提交于
Currently they live in util/virhostdev. However the virhostdev module is wrongly placed in util, which is below conf/ in our hierarchy. Move the functions that are actually used in conf/ to conf/ and remove the include of virhostdev.h from domain_conf. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Ján Tomko 提交于
Allow it to be included by anything above mid_dirs. Signed-off-by: NJán Tomko <jtomko@redhat.com> Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Andrea Bolognani 提交于
There are two environment variables that are baked into our cross-compilation container images at build time, $CONFIGURE_OPTS and $PKG_CONFIG_LIBDIR: the former contain the options necessary to convince configure to perform a cross build rather than a native one, and the latter is necessary so that pkg-config will locate the .pc files for MinGW libraries. Container images that are not intended for cross-compilation will not have either one defined. The problem is that, while an empty $CONFIGURE_OPTS is completely harmless, setting $PKG_CONFIG_LIBDIR to an emtpy value will result in pkg-config not looking in its default search path, thus not finding any library, and subsequently breaking native builds. To work around this issue, only pass $PKG_CONFIG_LIBDIR to sudo when the value is set in the calling environment. Fixes: 71517ae4Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
-
由 Peter Krempa 提交于
Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-