1. 23 3月, 2018 1 次提交
    • D
      rpc: remove remains of obsolete log_buffer_size config parameter · 65824a7e
      Daniel P. Berrangé 提交于
      The global log buffer feature was deleted in:
      
        commit c0c8c1d7
        Author: Daniel P. Berrange <berrange@redhat.com>
        Date:   Mon Mar 3 14:54:33 2014 +0000
      
          Remove global log buffer feature entirely
      
          A earlier commit changed the global log buffer so that it only
          records messages that are explicitly requested via the log
          filters setting. This removes the performance burden, and
          improves the signal/noise ratio for messages in the global
          buffer. At the same time though, it is somewhat pointless, since
          all the recorded log messages are already going to be sent to an
          explicit log output like syslog, stderr or the journal. The
          global log buffer is thus just duplicating this data on stderr
          upon crash.
      
          The log_buffer_size config parameter is left in the augeas
          lens to prevent breakage for users on upgrade. It is however
          completely ignored hereafter.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      
      This was in the 1.2.3 release, and 4 years is sufficient time for a
      graceful upgrade path for augeas, so all remaining traces are now
      removed.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      65824a7e
  2. 22 2月, 2018 1 次提交
  3. 16 8月, 2017 1 次提交
  4. 09 2月, 2017 1 次提交
  5. 08 6月, 2016 1 次提交
  6. 03 5月, 2016 1 次提交
  7. 10 8月, 2015 1 次提交
    • M
      rpc: Remove keepalive_required option · a8743c39
      Martin Kletzander 提交于
      Since its introduction in 2011 (particularly in commit f4324e32),
      the option doesn't work.  It just effectively disables all incoming
      connections.  That's because the client private data that contain the
      'keepalive_supported' boolean, are initialized to zeroes so the bool is
      false and the only other place where the bool is used is when checking
      whether the client supports keepalive.  Thus, according to the server,
      no client supports keepalive.
      
      Removing this instead of fixing it is better because a) apparently
      nobody ever tried it since 2011 (4 years without one month) and b) we
      cannot know whether the client supports keepalive until we get a ping or
      pong keepalive packet.  And that won't happen until after we dispatched
      the ConnectOpen call.
      
      Another two reasons would be c) the keepalive_required was tracked on
      the server level, but keepalive_supported was in private data of the
      client as well as the check that was made in the remote layer, thus
      making all other instances of virNetServer miss this feature unless they
      all implemented it for themselves and d) we can always add it back in
      case there is a request and a use-case for it.
      Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      a8743c39
  8. 16 6月, 2015 1 次提交
  9. 18 3月, 2014 1 次提交
  10. 06 8月, 2013 1 次提交
  11. 24 6月, 2013 2 次提交
  12. 28 5月, 2012 1 次提交
    • D
      Autogenerate augeas test case from default config files · de9758ae
      Daniel P. Berrange 提交于
      When adding new config file parameters, the corresponding
      additions to the augeas lens' are constantly forgotten.
      Also there are augeas test cases, these don't catch the
      error, since they too are never updated.
      
      To address this, the augeas test cases need to be auto-generated
      from the example config files.
      
      * build-aux/augeas-gentest.pl: Helper to generate an
        augeas test file, substituting in elements from the
        example config files
      * src/Makefile.am, daemon/Makefile.am: Switch to
        auto-generated augeas test cases
      * daemon/test_libvirtd.aug, daemon/test_libvirtd.aug.in,
        src/locking/test_libvirt_sanlock.aug,
        src/locking/test_libvirt_sanlock.aug.in,
        src/lxc/test_libvirtd_lxc.aug,
        src/lxc/test_libvirtd_lxc.aug.in,
        src/qemu/test_libvirtd_qemu.aug,
        src/qemu/test_libvirtd_qemu.aug.in: Remove example
        config file data, replacing with a ::CONFIG:: placeholder
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      de9758ae