1. 03 6月, 2019 2 次提交
  2. 30 5月, 2019 1 次提交
    • J
      build: fix linking libqemutestdriver with LTO enabled · 76b420d0
      Jim Fehlig 提交于
      openSUSE Factory is in the process of enabling Link Time Optimization [0]
      and stumbled upon missing symbols when linking libqemutestdriver
      
      libtool: link: gcc -shared  -fPIC -DPIC  ../src/libvirt_qemu_probes.o  \
      -Wl,--whole-archive ../src/.libs/libvirt_driver_qemu_impl.a \
      ../src/.libs/libvirt_driver_network_impl.a \
      ../src/.libs/libvirt_driver_storage_impl.a -Wl,--no-whole-archive  \
      -lcap-ng -lgnutls -lnl-route-3 -lnl-3 -ldbus-1 -lselinux -lapparmor \
      /usr/lib/libxml2.so -ldl -lz -llzma -lm -lblkid -ltirpc  \
      -fstack-protector-strong -O2 -fstack-protector-strong -flto=16 -g -O2 \
      -fstack-protector-strong -flto=16 -g \
      -Wl,-soname -Wl,libqemutestdriver.so -o .libs/libqemutestdriver.so
      ...
      /usr/lib/gcc/i586-suse-linux/9/../../../../i586-suse-linux/bin/ld: ./.libs/libqemutestdriver.so: undefined reference to `mdir_name'
      /usr/lib/gcc/i586-suse-linux/9/../../../../i586-suse-linux/bin/ld: ./.libs/libqemutestdriver.so: undefined reference to `rpl_ioctl'
      /usr/lib/gcc/i586-suse-linux/9/../../../../i586-suse-linux/bin/ld: ./.libs/libqemutestdriver.so: undefined reference to `rpl_pipe2'
      /usr/lib/gcc/i586-suse-linux/9/../../../../i586-suse-linux/bin/ld: ./.libs/libqemutestdriver.so: undefined reference to `recvfd'
      /usr/lib/gcc/i586-suse-linux/9/../../../../i586-suse-linux/bin/ld: ./.libs/libqemutestdriver.so: undefined reference to `c_strcasecmp'
      
      The missing symbols are provided by GNUlib. Add it when linking
      libqemutestdriver.
      
      [0] https://en.opensuse.org/openSUSE:LTOSigned-off-by: NJim Fehlig <jfehlig@suse.com>
      Acked-by: NMichal Privoznik <mprivozn@redhat.com>
      76b420d0
  3. 23 5月, 2019 2 次提交
  4. 22 5月, 2019 3 次提交
  5. 21 5月, 2019 2 次提交
  6. 17 5月, 2019 5 次提交
    • M
      lib: Avoid double close when passing FDs with virCommandPassFD() · 5cdd5d38
      Michal Privoznik 提交于
      If an FD is passed into a child using:
      
        virCommandPassFD(cmd, fd, VIR_COMMAND_PASS_FD_CLOSE_PARENT);
      
      then the parent should refrain from touching @fd thereafter. This
      is even documented in virCommandPassFD() comment. The reason is
      that either at virCommandRun()/virCommandRunAsync() or
      virCommandFree() time the @fd will be closed. Closing it earlier,
      e.g. right after virCommandPassFD() call might result in
      undesired results. Another thread might open a file and receive
      the same FD which is then unexpectedly closed by virCommandFree()
      or virCommandRun().
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NJán Tomko <jtomko@redhat.com>
      5cdd5d38
    • A
      qemu: Only probe available machine types · a251095e
      Andrea Bolognani 提交于
      Since we know the full list of machine types supported
      by the QEMU binary when probing machine type properties,
      we can save some work (and eventually test suite churn,
      as more architecture-specific machine types need to be
      probed) by only probing machines that we know exist.
      Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
      a251095e
    • A
      tests: Refresh capabilities for QEMU on ppc64 · 35e4c153
      Andrea Bolognani 提交于
      Now that we're probing machine type properties using the
      latest machine type rather than the "spapr-machine" parent,
      we can finally discover properties that are not available
      on all machine types.
      
      This commit refreshes replies for QEMU 4.0.0 as well as
      3.1.0 to show not only that we're actually discovering new
      machine type properties this way, but also that the number
      of available machine type properties increases with each
      subsequent QEMU release.
      
      If qom-list-properties had been available in QEMU 2.10.0,
      we could now drop the explicit version number checks for
      the QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT and
      QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT capabilities, but
      unfortunately it wasn't, so we have to keep them around
      still.
      Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
      35e4c153
    • A
      qemu: Probe canonicalized machine type · d22c6221
      Andrea Bolognani 提交于
      Now that we have the list of machine types available when
      probing machine type properties, we can list properties for
      the canonicalized version of the "pseries" machine type
      instead of having to go through "spapr-machine", which we
      know to be the parent type for all "pseries-*-machine"
      types. By doing this, we'll be able to find even properties
      that are only available from a certain versioned machine
      type forward, and can't thus be obtained when looking at
      the parent type only.
      Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
      d22c6221
    • A
      qemu: Move call to virQEMUCapsProbeQMPMachineProps() · 295a42e1
      Andrea Bolognani 提交于
      We're going to need information about available machine types
      when probing machine type properties soon, and that means we
      have to change the order we call QMP commands.
      Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
      295a42e1
  7. 15 5月, 2019 4 次提交
  8. 14 5月, 2019 1 次提交
  9. 09 5月, 2019 1 次提交
  10. 07 5月, 2019 3 次提交
    • M
      virtestmock: Initialize symbols from stat() and its friends · e1de5dd2
      Michal Privoznik 提交于
      Introduced by ff376c62.
      
      Previously, init_syms() was called from stat() mock and its
      friends. This is crucial because checkPath() might call
      printFile() which in turn calls real_fopen(). But if stat() or
      one of its friends is the first function called then because of
      lacking init_syms() call no real_* is initialized.
      
      The other thing is that we really want the recorded action to be
      "stat" instead of __FUNCTION__ because there's no good in
      recording that it was __xstat64 who touched some file.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      e1de5dd2
    • M
      virfilemock: Init symbols in canonicalize_file_name() · dd5ae5f2
      Michal Privoznik 提交于
      If a program that is using this mock calls canonicalize_file_name()
      as the very first function then it will face SIGSEGV because
      real_canonicalize_file_name is uninitialized.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      dd5ae5f2
    • E
      conf: Add parameter to virDomainDiskSourceFormat · 1ec3e397
      Eric Blake 提交于
      Commits 4bc42986 and 218c81ea removed virDomainStorageSourceFormat on
      the grounds that there were no external callers; however, the upcoming
      backup code wants to output a <target> (push mode) or <scratch> (pull
      mode) element that is in all other respects identical to a domain's
      <source> element, where the previous virDomainStorageSourceFormat fit
      the bill nicely. But rather than reverting the commits, it's easier to
      just add an additional parameter for the element name to use, and
      update all callers.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      1ec3e397
  11. 06 5月, 2019 13 次提交
  12. 05 5月, 2019 2 次提交
  13. 30 4月, 2019 1 次提交