- 24 4月, 2010 11 次提交
-
-
由 Chris Lalancette 提交于
We were freeing the virDomainSnapshotDefPtr, but not the virDomainSnapshotObjPtr in virDomainSnapshotObjFree. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Chris Lalancette 提交于
Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Chris Lalancette 提交于
While running libvirtd under valgrind and doing some snapshot testing I noticed that we would always leak a connection reference. The problem was actually that we were leaking a domain reference in the libvirtd remote snapshot code, which was in turn causing a leaked connection reference. Fix the situation by explicitly taking and dropping a domain reference where we need it. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Matthias Bolte 提交于
Cygwin has mntent.h but lacks getmntent_r. Update preprocessor checks to catch this combination.
-
由 Matthias Bolte 提交于
-
由 Matthias Bolte 提交于
The defined __sun is there, because inside_daemon is used in xenUnifiedOpen if __sun is defined.
-
由 Matthias Bolte 提交于
Also move the equivalent checks for LXC and UML before their header checks. This way configure doesn't check for the headers when the driver gets disabled anyway.
-
由 Matthias Bolte 提交于
-
由 Eric Blake 提交于
* configure.ac: Avoid syntax error.
-
由 Eric Blake 提交于
Under cygwin, winsock2.h is intentionally incompatible with, <sys/socket.h>, and checking for existence is wrong. Under mingw, HAVE_WINSOCK2_H is defined on our behalf by gnulib, in a way that does not interfere with cygwin. * configure.ac: Drop unnecessary header check. Reported by Matthias Bolte.
-
由 Luiz Capitulino 提交于
It's not needed and is currently ignored, but this is a bug. It will get fixed soon and QMP will return an error for keys it doesn't know about, this will break libvirt. * src/qemu/qemu_monitor_json.c: remove qemuMonitorJSONCommandAddTimestamp() and the place where it's invoked in qemuMonitorJSONMakeCommand()
-
- 23 4月, 2010 14 次提交
-
-
由 Stefan Berger 提交于
I am extending the schema with the recently added connlimit-above attribute and adding a test case for it to the test suite.
-
由 Marco Bozzolan 提交于
* AUTHORS: Use preferred name. Signed-off-by: NEric Blake <eblake@redhat.com>
-
由 Daniel P. Berrange 提交于
The nwfilterDriverActive() could de-reference a NULL pointer if it hadn't be started at the point it was called. It was also not thread safe, since it lacked locking around data accesses. * src/nwfilter/nwfilter_driver.c: Fix locking & NULL checks in nwfilterDriverActive()
-
由 Eric Blake 提交于
The user probably doesn't care what the gai error numbers are, as much as what the failed conversion IP address was. * src/remote/remote_driver.c (addrToString): Mention which address could not be converted. * daemon/remote.c (addrToString): Likewise.
-
由 Eric Blake 提交于
git shortlog $(git log -1 --format=%H AUTHORS).. | grep -v "^ " then add missing entries to AUTHORS. * AUTHORS: Update.
-
由 Spencer Shimko 提交于
* The error messages coming from qemu's DAC support contain strings from the original SELinux security driver code. This just removes references to "security context" and other SELinux-isms from the DAC code. Signed-off-by: NSpencer Shimko <sshimko@tresys.com> Signed-off-by: NEric Blake <eblake@redhat.com>
-
由 Stefan Berger 提交于
- using INT_BUFSIZE_BOUND() to determine the length of the buffersize for printing and integer into - not explicitly initializing static var threadsTerminate to false anymore, since that's done automatically Changes after V2: - removed while looks in case of OOM error - removed on ifaceDown() call - preceding one ifaceDown() call with an ifaceCheck() call Since the name of an interface can be the same between stops and starts of different VMs I have to switch the IP address learning thread to use the index of the interface to determine whether an interface is still available or not - in the case of macvtap the thread needs to listen for traffic on the physical interface, thus having to time out periodically to check whether the VM's macvtap device is still there as an indication that the VM is still alive. Previously the following sequence of 2 VMs with macvtap device virsh start testvm1; virsh destroy testvm1 ; virsh start testvm2 would not terminate the thread upon testvm1's destroy since the name of the interface on the host could be the same (i.e, macvtap0) on testvm1 and testvm2, thus it was easily race-able. The thread would then determine the IP address parameter for testvm2 but apply the rule set for testvm1. :-( I am also introducing a lock for the interface (by name) that the thread must hold while it listens for the traffic and releases when it terminates upon VM termination or 0.5 second thereafter. Thus, the new thread for a newly started VM with the same interface name will not start while the old one still holds the lock. The only other code that I see that also needs to grab the lock to serialize operation is the one that tears down the firewall that were established on behalf of an interface. I am moving the code applying the 'basic' firewall rules during the IP address learning phase inside the thread but won't start the thread unless it is ensured that the firewall driver has the ability to apply the 'basic' firewall rules.
-
由 David Allan 提交于
* Fix for the bug reported at: https://bugzilla.redhat.com/show_bug.cgi?id=573908
-
由 Jiri Denemark 提交于
The hang fix in d376b7d6 was incomplete since it left quite a few {Enter,Exit}Monitor calls which require driver to be unlocked. Since the driver is locked throughout the whole function, {Enter,Exit}MonitorWithDriver need to be used instead to ensure driver is not locked when issuing monitor commands.
-
由 Jiri Denemark 提交于
The comment in qemuDomainWaitForMigrationComplete says we are polling every 50ms but the code sleeps only for 50us. This was already discussed during review but apparently forgotten when the series was pushed.
-
由 Spencer Shimko 提交于
* Fix a logic error in configure.ac that prevented --with-selinux=no from being used with --with-secdriver-selinux=no. * Fix some strings to clarify the difference between --with-selinux and --with-secdriver-selinux. Signed-off-by: NSpencer Shimko <sshimko@tresys.com> Signed-off-by: NEric Blake <eblake@redhat.com>
-
由 Daniel P. Berrange 提交于
The text monitor code was checking for a '\n' prefix on several places. Previously this would work, but since the monitor code re-write the '\n' is already stripped off, so mustn't be checked for. * src/qemu/qemu_monitor_text.c: Fix monitor error checking
-
由 Daniel P. Berrange 提交于
Probably as a result of a merge error, the CPU hotplug command names were completely wrong. * src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_text.c: Fix the CPU hotplug command names
-
由 Daniel P. Berrange 提交于
The events demo program is slightly misleading printing myDomainEventCallback1 EVENT: Domain f14i686(-1) Added which is not distinguishing Add vs Update events. It should have been doing myDomainEventCallback1 EVENT: Domain f14i686(-1) Defined Updated * examples/domain-events/events-python/event-test.py: Fully print event detail info string
-
- 22 4月, 2010 13 次提交
-
-
由 Dustin Kirkland 提交于
A few fixes will help make tools/virt-pki-validate.in useful on Debian and Ubuntu. And one fix should be useful to everyone (see #3). 1) note our gnutls-bin package (in addition to your gnutls-utils package) in the no-certtool error text 2) fix a bashism, == should be = in the case where /bin/sh is a symlink to dash 3) $(SYSCONFDIR) cannot evaluate; set a single shell SYSCONFDIR variable to the autoconf @SYSCONFDIR@ value, and use $SYSCONFDIR everywhere Bug report: * https://bugs.edge.launchpad.net/ubuntu/+source/libvirt/+bug/562266Signed-off-by: NDustin Kirkland <kirkland@canonical.com> Signed-off-by: NEric Blake <eblake@redhat.com>
-
由 Eric Blake 提交于
Noticed because virt-pki-validate was very inconsistent on using tabs vs. 8 spaces, sometimes mixing both paradigms on a single line. 'git diff -b' shows significant changes only in cfg.mk. * cfg.mk (sc_TAB_in_indentation): Add a few files. * daemon/libvirtd.init.in: Avoid tabs. * tools/virt-pki-validate.in: Likewise.
-
由 Eric Blake 提交于
* tests/testutilsqemu.c (testQemuCapsInit): Initialize variables.
-
由 Jiri Denemark 提交于
-
由 Jiri Denemark 提交于
Adds ability to provide a preferred CPU model for CPUID data decoding. Such model would be considered as the best possible model (if it's supported by hypervisor) regardless on number of features which have to be added or removed for describing required CPU.
-
由 Jiri Denemark 提交于
So far, when CPUID data were converted into CPU model and features, the features can only be added to the model. As a result, when a guest asked for something like "qemu64,-svm" it would get a qemu32 plus a bunch of additional features instead. This patch adds support for removing feature from the base model. Selection algorithm remains the same: the best CPU model is the model which requires lowest number of features to be added/removed from it.
-
由 Jiri Denemark 提交于
-
由 Jiri Denemark 提交于
Qemu committed a patch which list some CPU names in [] when asked for supported CPUs (qemu -cpu ?). Yet, it needs such CPUs to be passed without those square braces. When probing for supported CPU models, we can just strip the square braces and pretend we have never seen them.
-
由 Jiri Denemark 提交于
First, inital VCPU pinning is set correctly but then it is reset by assigning qemu process to a new cgroup (which contains all CPUs). It's easily fixed by swapping these two actions.
-
由 Eric Blake 提交于
* .gitignore: Add exemption. * cfg.mk (local-checks-to-skip): Ignore a test to silence a skip warning.
-
由 Chris Lalancette 提交于
If the hostname of the current virtualization machine could not be resolved, then libvirtd would fail to start. However, for disconnected operation (on a laptop, for instance) the hostname may very legitimately not be resolvable. This patch makes it so that if we can't resolve the hostname, avahi doesn't fail, it just uses a less useful MDNS string. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
-
由 Eric Blake 提交于
* src/esx/esx_vi.h: Placate cppi.
-
- 21 4月, 2010 2 次提交
-
-
由 Chris Wong 提交于
An empty root snapshot list was considered as error condition. Creating a new snapshot would fail if the domain didn't have snapshots yet, because the snapshot-create function tries to lookup the list of existing snapshots in order to verify that the snapshot name is unique. This fails if the domain doesn't have snapshots yet. Removing the NULL check from esxVI_LookupRootSnapshotTreeList fixes this.
-
由 Matthias Bolte 提交于
-