1. 12 6月, 2019 4 次提交
  2. 21 5月, 2019 2 次提交
  3. 25 4月, 2019 1 次提交
  4. 10 4月, 2019 1 次提交
  5. 26 3月, 2019 1 次提交
  6. 04 2月, 2019 1 次提交
  7. 09 1月, 2019 2 次提交
    • M
      qemu: Use ULL instead of uint64_t for RDMA GID event · f8862714
      Michal Privoznik 提交于
      In the previous commit we are using uint64_t for storing subnet
      prefix and interface id that qemu reports in
      RDMA_GID_STATUS_CHANGED event. We also report them in some debug
      messages. This poses a problem because uint64_t can be UL or ULL
      depending on the host architecture and hence we wouldn't know
      which format to use. Switch to ULL which is big enough and
      doesn't suffer from the issue.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      f8862714
    • Y
      qemu: Process RDMA GID state change event · ed357cef
      Yuval Shaia 提交于
      This event is emitted on the monitor when a GID table in pvrdma device
      is modified and the change needs to be propagate to the backend RDMA
      device's GID table.
      
      The control over the RDMA device's GID table is done by updating the
      device's Ethernet function addresses.
      Usually the first GID entry is determine by the MAC address, the second
      by the first IPv6 address and the third by the IPv4 address. Other
      entries can be added by adding more IP addresses. The opposite is the
      same, i.e. whenever an address is removed, the corresponding GID entry
      is removed.
      
      The process is done by the network and RDMA stacks. Whenever an address
      is added the ib_core driver is notified and calls the device driver's
      add_gid function which in turn update the device.
      
      To support this in pvrdma device we need to hook into the create_bind
      and destroy_bind HW commands triggered by pvrdma driver in guest.
      Whenever a changed is made to the pvrdma device's GID table a special
      QMP messages is sent to be processed by libvirt to update the address of
      the backend Ethernet device.
      Signed-off-by: NYuval Shaia <yuval.shaia@oracle.com>
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      ed357cef
  8. 17 12月, 2018 1 次提交
  9. 14 12月, 2018 3 次提交
    • D
      Enforce a standard header file guard symbol name · 568a4172
      Daniel P. Berrangé 提交于
      Require that all headers are guarded by a symbol named
      
        LIBVIRT_$FILENAME
      
      where $FILENAME is the uppercased filename, with all characters
      outside a-z changed into '_'.
      
      Note we do not use a leading __ because that is technically a
      namespace reserved for the toolchain.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      568a4172
    • D
      Fix many mistakes & inconsistencies in header file layout · 4cfd7090
      Daniel P. Berrangé 提交于
      This introduces a syntax-check script that validates header files use a
      common layout:
      
        /*
         ...copyright header...
         */
        <one blank line>
        #ifndef SYMBOL
        # define SYMBOL
        ....content....
        #endif /* SYMBOL */
      
      For any file ending priv.h, before the #ifndef, we will require a
      guard to prevent bogus imports:
      
        #ifndef SYMBOL_ALLOW
        # error ....
        #endif /* SYMBOL_ALLOW */
        <one blank line>
      
      The many mistakes this script identifies are then fixed.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      4cfd7090
    • D
      Remove all Author(s): lines from source file headers · 60046283
      Daniel P. Berrangé 提交于
      In many files there are header comments that contain an Author:
      statement, supposedly reflecting who originally wrote the code.
      In a large collaborative project like libvirt, any non-trivial
      file will have been modified by a large number of different
      contributors. IOW, the Author: comments are quickly out of date,
      omitting people who have made significant contribitions.
      
      In some places Author: lines have been added despite the person
      merely being responsible for creating the file by moving existing
      code out of another file. IOW, the Author: lines give an incorrect
      record of authorship.
      
      With this all in mind, the comments are useless as a means to identify
      who to talk to about code in a particular file. Contributors will always
      be better off using 'git log' and 'git blame' if they need to  find the
      author of a particular bit of code.
      
      This commit thus deletes all Author: comments from the source and adds
      a rule to prevent them reappearing.
      
      The Copyright headers are similarly misleading and inaccurate, however,
      we cannot delete these as they have legal meaning, despite being largely
      inaccurate. In addition only the copyright holder is permitted to change
      their respective copyright statement.
      Reviewed-by: NErik Skultety <eskultet@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      60046283
  10. 19 11月, 2018 2 次提交
    • J
      qemu: Add monitor functions to set IOThread params · 3083bf18
      John Ferlan 提交于
      Add functions to set the IOThreadInfo param data for the live guest.
      Modify the _qemuMonitorIOThreadInfo to have a flag to indicate when
      a value was set so that we don't set a value unless it was desired
      to be set.
      
      Based on code originally posted by Pavel Hrdina <phrdina@redhat.com>,
      but extracted into a separate patch. Note that qapi expects to receive
      integer parameters rather than unsigned long long or unsigned int's.
      QEMU does save the value in larger signed 64 bit values eventually.
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      ACKed-by: NMichal Privoznik <mprivozn@redhat.com>
      3083bf18
    • J
      qemu: Check for and return IOThread polling values if available · d1c1f2c2
      John Ferlan 提交于
      If there are IOThread polling values in the query-iothreads return
      buffer, then fill them in and set a bool indicating their presence.
      This will allow for displaying in a domain stats output eventually.
      
      Note that the QEMU values are managed a bit differently (as int's
      stored in int64_t's) than we will manage them (as unsigned long and
      int values). This is intentional to allow for value validation
      checking when it comes time to provide the values to QEMU.
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      ACKed-by: NMichal Privoznik <mprivozn@redhat.com>
      d1c1f2c2
  11. 24 8月, 2018 1 次提交
  12. 21 8月, 2018 9 次提交
  13. 20 7月, 2018 2 次提交
  14. 13 7月, 2018 1 次提交
  15. 10 7月, 2018 3 次提交
  16. 12 6月, 2018 3 次提交
  17. 06 6月, 2018 1 次提交
    • D
      qemu: don't retry connect() if doing FD passing · 7ef0471b
      Daniel P. Berrangé 提交于
      Since libvirt called bind() and listen() on the UNIX socket, it is
      guaranteed that connect() will immediately succeed, if QEMU is running
      normally. It will only fail if QEMU has closed the monitor socket by
      mistake or if QEMU has exited, letting the kernel close it.
      
      With this in mind we can remove the retry loop and timeout when
      connecting to the QEMU monitor if we are doing FD passing. Libvirt can
      go straight to sending the QMP greeting and will simply block waiting
      for a reply until QEMU is ready.
      Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      7ef0471b
  18. 05 6月, 2018 2 次提交