1. 09 2月, 2016 1 次提交
    • P
      qemu: vcpu: Aggregate code to set vCPU tuning · 56971667
      Peter Krempa 提交于
      Rather than iterating 3 times for various settings this function
      aggregates all the code into single place. One of the other advantages
      is that it can then be reused for properly setting vCPU info on hotplug.
      
      With this approach autoCpuset is also used when setting the process
      affinity rather than just via cgroups.
      56971667
  2. 08 2月, 2016 24 次提交
  3. 07 2月, 2016 1 次提交
  4. 06 2月, 2016 8 次提交
    • J
      util: Fix virCgroupNewMachine ATTRIBUTE_NONNULL args · b8c0f186
      John Ferlan 提交于
      Commit id 'c3bd0019' removed arg3, but forgot to adjust the numbers
      for NONNULL - caused build failure for coverity
      b8c0f186
    • R
      bhyve: fix preprocessor indentation · dcb3d87d
      Roman Bogorodskiy 提交于
      Syntax-check fails with:
      
      cppi: src/bhyve/bhyve_driver.h: line 26: not properly indented
      cppi: src/bhyve/bhyve_driver.h: line 27: not properly indented
      maint.mk: incorrect preprocessor indentation
      
      Fix by properly indenting '#include's.
      
      Pushed as trivial.
      dcb3d87d
    • M
      bhyve: Fix the build · 5147f4f3
      Michal Privoznik 提交于
      After 1036ddad we use bhyveDriverGetCapabilities from other
      sources too, not only from bhyve_driver.c. However, the function
      was static so not properly expose to other files. In order to
      expose it, we need to move couple of #include-s too.
      Then, there has been a copy paste error in
      virBhyveProcessReconnect: s/privconn/data->driver/.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      5147f4f3
    • C
      tests: qemuargv2xml: separate from qemuxml2argv data · e117bf64
      Cole Robinson 提交于
      Most of the qemuargv2xml tests are parsing old style qemu command
      lines (with -disk, -serial, etc), and it gets its input from
      qemuxml2argv output.
      
      But since we've raise the minimum supported qemu version to 0.12.0,
      which supports -device, once that changes propagates through libvirt
      the vast majority of qemuxml2argv output is _not_ going to be using
      old style qemu options.
      
      In preparation for this, switch qemuargv2xml to use its own copies
      of input and output, so it's not tied to qemuxml2argv results.
      
      This is just a straight copy of the current tests.
      e117bf64
    • C
      tests: Run test-wrap-argv with REGENERATE_OUTPUT · 3e9033f7
      Cole Robinson 提交于
      To get properly wrapped output
      3e9033f7
    • W
      rbd: Use %zu for uint64_t instead of casting to unsigned long long · 2aed051d
      Wido den Hollander 提交于
      This was only used in debugging messages and not in any real code.
      
      Ceph/RBD uses uint64_t for sizes internally and they can be printed
      with %zu without any need for casting.
      Signed-off-by: NWido den Hollander <wido@widodh.nl>
      2aed051d
    • W
      rbd: Code styling cleanup · f4981ebf
      Wido den Hollander 提交于
      Through the years the RBD storage pool code hasn't maintained the
      same or correct coding standard which applies to libvirt.
      
      This patch doesn't change any logic in the code, it only applies
      the proper coding standards to the code where possible without
      making large changes.
      
      This way the code style used in this storage pool is consistent
      throughout the whole file.
      Signed-off-by: NWido den Hollander <wido@widodh.nl>
      f4981ebf
    • M
      virSystemdGetMachineNameByPID: Initialize @reply · a3b168d0
      Michal Privoznik 提交于
      I've noticed that variable @reply is not initialized and if
      something at the beginning of the function fails, e.g.
      virDBusGetSystemBus(), the control jump straight to cleanup label
      where dbus_message_unref() is then called over this uninitialized
      variable.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      a3b168d0
  5. 05 2月, 2016 6 次提交
    • M
      virnetdevbandwidth: Compute quantum value · 065054da
      Michal Privoznik 提交于
      I've noticed couple of warning in dmesg while debugging
      something:
      
      [ 9683.973754] HTB: quantum of class 10001 is big. Consider r2q change.
      [ 9683.976460] HTB: quantum of class 10002 is big. Consider r2q change.
      
      I've read the HTB documentation and linux kernel code to find out
      what's wrong. Basically we need to pass another argument
      "quantum" to our tc cmd line because the default computed by HTB
      does not always work in which case the warning message is printed
      out.
      
      You can read more details here:
      
      http://luxik.cdi.cz/~devik/qos/htb/manual/userg.htm#sharingSigned-off-by: NMichal Privoznik <mprivozn@redhat.com>
      065054da
    • P
      conf: Extract code for parsing thread resource scheduler info · 173054ce
      Peter Krempa 提交于
      As the scheduler info elements are represented orthogonally to how it
      makes sense to actually store the information, the extracted code will
      be later used when converting between XML and internal definitions.
      173054ce
    • P
      e992aa21
    • P
      util: bitmap: Introduce bitmap subtraction · 9479642f
      Peter Krempa 提交于
      Performs binary subtraction of two bitmaps. Stores result in the first
      operand.
      9479642f
    • M
      systemd: Modernize machine naming · c3bd0019
      Martin Kletzander 提交于
      So, systemd-machined has this philosophy that machine names are like
      hostnames and hence should follow the same rules.  But we always allowed
      international characters in domain names.  Thus we need to modify the
      machine name we are passing to systemd.
      
      In order to change some machine names that we will be passing to systemd,
      we also need to call TerminateMachine at the end of a lifetime of a
      domain.  Even for domains that were started with older libvirt.  That
      can be achieved thanks to virSystemdGetMachineNameByPID().  And because
      we can change machine names, we can get rid of the inconsistent and
      pointless escaping of domain names when creating machine names.
      
      So this patch modifies the naming in the following way.  It creates the
      name as <drivername>-<id>-<name> where invalid hostname characters are
      stripped out of the name and if the resulting name is longer, it
      truncates it to 64 characters.  That way we can start domains we
      couldn't start before.  Well, at least on systemd.
      
      To make it work all together, the machineName (which is needed only with
      systemd) is saved in domain's private data.  That way the generation is
      moved to the driver and we don't need to pass various unnecessary
      arguments to cgroup functions.
      
      The only thing this complicates a bit is the scope generation when
      validating a cgroup where we must check both old and new naming, so a
      slight modification was needed there.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1282846Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      c3bd0019
    • J
      conf: add caps to virDomainSnapshotDefFormat · b8b03f64
      Joao Martins 提交于
      The virDomainSnapshotDefFormat calls into virDomainDefFormat,
      so should be providing a non-NULL virCapsPtr instance. On the
      qemu driver we change qemuDomainSnapshotWriteMetadata to also
      include caps since it calls virDomainSnapshotDefFormat.
      Signed-off-by: NJoao Martins <joao.m.martins@oracle.com>
      b8b03f64