Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt
切换分支/标签
  1. 15 11月, 2018 3 次提交
  3. 09 11月, 2018 1 次提交
  5. 30 10月, 2018 1 次提交
  7. 17 9月, 2018 2 次提交
  9. 05 9月, 2018 1 次提交
  11. 28 8月, 2018 1 次提交
  13. 24 8月, 2018 4 次提交
  15. 07 8月, 2018 1 次提交
  17. 31 7月, 2018 1 次提交
  19. 19 7月, 2018 1 次提交
  21. 10 7月, 2018 1 次提交
  23. 04 7月, 2018 1 次提交
  25. 29 5月, 2018 1 次提交
  27. 15 5月, 2018 2 次提交
  29. 14 5月, 2018 1 次提交
  31. 04 5月, 2018 1 次提交
  33. 06 4月, 2018 3 次提交
  35. 24 3月, 2018 1 次提交
  37. 16 3月, 2018 2 次提交
  39. 13 3月, 2018 1 次提交
  41. 07 3月, 2018 1 次提交
  43. 22 2月, 2018 1 次提交
  45. 20 2月, 2018 2 次提交
    • D
      Fix build with GCC 8 new switch fallthrough warnings · 75f4813c
      由 Daniel P. Berrangé 提交于 
      GCC 8 became more fussy about detecting switch
fallthroughs. First it doesn't like it if you have
a fallthrough attribute that is not before a case
statement. e.g.

   FOO:
   BAR:
   WIZZ:
      ATTRIBUTE_FALLTHROUGH;

Is unacceptable as there's no final case statement,
so while FOO & BAR are falling through, WIZZ is
not falling through. IOW, GCC wants us to write

  FOO:
  BAR:
    ATTRIBUTE_FALLTHROUGH;
  WIZZ:

Second, it will report risk of fallthrough even if you
have a case statement for every single enum value, but
only if the switch is nested inside another switch and
the outer case statement has no final break. This is
is arguably valid because despite the fact that we have
cast from "int" to the enum typedef, nothing guarantees
that the variable we're switching on only contains values
that have corresponding switch labels. e.g.

   int domstate = 87539319;
   switch ((virDomainState)domstate) {
      ...
   }

will not match enum value, but also not raise any kind
of compiler warning. So it is right to complain about
risk of fallthrough if no default: is present.
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      75f4813c
    • D
      conf: add enum constants for default controller models · a302480d
      由 Daniel P. Berrangé 提交于 
      The controller model is slightly unusual in that the default value is
-1, not 0. As a result the default value is not covered by any of the
existing enum cases. This in turn means that any switch() statements
that think they have covered all cases, will in fact not match the
default value at all. In the qemuDomainDeviceCalculatePCIConnectFlags()
method this has caused a serious mistake where we fallthrough from the
SCSI controller case, to the VirtioSerial controller case, and from
the USB controller case to the IDE controller case.

By adding explicit enum constant starting at -1, we can ensure switches
remember to handle the default case.
Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      a302480d
  47. 09 2月, 2018 1 次提交
    • D
      conf: expand network device callbacks to cover resolving NIC type · a455d41e
      由 Daniel P. Berrangé 提交于 
      Currently the QEMU driver will call directly into the network driver
impl to modify resolve the atual type of NICs with type=network. It
has todo this before it has allocated the actual NIC. This introduces
a callback system to allow us to decouple the QEMU driver from the
network driver.

This is a short term step, as it ought to be possible to achieve the
same end goal by simply querying XML via the public network API. The
QEMU code in question though, has no virConnectPtr conveniently
available at this time.
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      a455d41e
  49. 01 2月, 2018 5 次提交
    • J
      qemu: Update qemuDomainFindSCSIControllerModel return · 5b5bff35
      由 John Ferlan 提交于 
      Now that the controller model is updated during post parse callback,
this code no longer needs to fetch the model based on the capabilities
and can just return the model directly if the controller is found.

Removal of @qemuCaps cascades through various callers which are now
updated to not pass the capabilities.
      5b5bff35
    • J
      qemu: Reduce need to call qemuDomainGetSCSIControllerModel · de8fac5f
      由 John Ferlan 提交于 
      Now that post parse processing handles setting the SCSI controller
model, there's no need to call qemuDomainGetSCSIControllerModel to
get the "default controller" when building the command line controller
string or when assigning the spaprvio address since the controller
model value will already be filled in.
      de8fac5f
    • J
      qemu: Introduce qemuDomainSetSCSIControllerModel · 62f8c947
      由 John Ferlan 提交于 
      During post parse processing, let's force setting the controller
model to default value if not already set for defined controllers
(e.g. the non implicit ones).
      62f8c947
    • J
      qemu: Introduce qemuDomainGetSCSIControllerModel · fadfb4f9
      由 John Ferlan 提交于 
      Rename and rework qemuDomainSetSCSIControllerModel since we're
really not setting the SCSI controller model. Instead the code
is either returning the existing SCSI controller model value, the
default value based on the capabilities, or -1 with the error set.
      fadfb4f9
    • J
      qemu: Introduce qemuDomainFindSCSIControllerModel · 6ae6ffd8
      由 John Ferlan 提交于 
      Rather than repeat multiple steps in order to find the SCSI
controller model, let's combine them into one helper that will
return either the model from the definition or the default
model based on the capabilities.

This patch adds an extra check/error that the controller
that's being found actually exists. This just clarifies that
the error was because the controller doesn't exist rather
than the more generic error that we were unable to determine
the model from qemuDomainSetSCSIControllerModel when a -1
was passed in and the capabilities were unable to find one.
      6ae6ffd8