Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 12 5月, 2016 5 次提交
    • J
      Fill out default vram in DeviceDefPostParse · 538012c8
      由 Ján Tomko 提交于 
      Move filling out the default video (v)ram to DeviceDefPostParse.

This means it can be removed from virDomainVideoDefParseXML
and qemuParseCommandLine. Also, we no longer need to special case
VIR_DOMAIN_VIRT_XEN, since the per-driver callback gets called
before the generic one.
      538012c8
    • J
      Call per-device post-parse callback even on implicit video · 3e428670
      由 Ján Tomko 提交于 
      Commit 6879be48 moved adding of an implicit video device after XML
parsing. As a result, libxlDomainDeviceDefPostParse() is no longer
called to set the default vram when adding an implicit device.
Commit 6879be48 assumes virDomainVideoDefaultRAM() will set the
default vram, but it returns 0 if the domain virtType is
VIR_DOMAIN_VIRT_XEN. Attempting to start an HVM domain with vram=0
results in

error: unsupported configuration: videoram must be at least 4MB for CIRRUS

The default vram setting for Xen HVM domains depends on the device
model used (qemu-xen vs qemu-traditional), hence setting the
default is deferred to libxlDomainDeviceDefPostParse().

Call the device post-parse callback even for implicit video,
to fill out the default vram even for VIR_DOMAIN_VIRT_XEN.

https://bugzilla.redhat.com/show_bug.cgi?id=1334557Most-of-commit-message-by: NJim Fehlig <jfehlig@suse.com>
      3e428670
    • J
      Move virDomainDefPostParseInternal after virDomainDeviceDefPostParse · e4d131b8
      由 Ján Tomko 提交于 
      Future commit will call DeviceDefPostParse on a device auto-added
in DomainDefPostParse.
      e4d131b8
    • E
      util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL · e711a391
      由 Erik Skultety 提交于 
      Both virGetLastError and virGetLastErrorMessage call virLastErrorObject method
that returns a thread-local error object. However, if a direct call to malloc
or pthread_setspecific (probably also due to malloc, since it sets ENOMEM)
fail, virLastErrorObject returns NULL which, although incorrectly interpreted
by virGetLastError as no error, still requires the caller to check for NULL
pointer. This isn't the case with virGetLastErrorMessage that also treated it
incorrectly as no error, but returned the literal "no error".
This patch tweaks the checks in the virGetLastErrorMessage function, so that
if virLastErrorObject failed, it returned "unknown error" which is equivalent
to the current approach with virGetLastError and if it returned NULL,
"unknown error" was set.
Signed-off-by: NErik Skultety <eskultet@redhat.com>
      e711a391
    • E
      spec: Fix broken indentation reported by syntax-check · df4d908d
      由 Erik Skultety 提交于 
      syntax-check complained about broken indentation in libvirt.spec.in which was
broken by commit 3694e038Signed-off-by: NErik Skultety <eskultet@redhat.com>
      df4d908d
  3. 11 5月, 2016 35 次提交