1. 25 2月, 2010 4 次提交
    • J
      build: fix typos in makefile variable names · 5365ff40
      Jim Meyering 提交于
      * configure.ac: Fix typos:
      s/DRIVER_MODULES_CFLAGS/DRIVER_MODULE_CFLAGS/
      s/DRIVER_MODULES_LIBS/DRIVER_MODULE_LIBS/
      5365ff40
    • J
      build: ensure that MKINSTALLDIRS is AC_SUBST-defined · 89bdf84b
      Jim Meyering 提交于
      since we're using gettext-0.14.1, which uses that now-obsolete
      automake symbol.  Otherwise, make distcheck would fails like this:
      
          make[2]: Entering directory `/t/libvirt-0.7.6/_build/po'
          /bin/sh @MKINSTALLDIRS@ /t/libvirt-0.7.6/_inst/share
          /bin/sh: @MKINSTALLDIRS@: No such file or directory
          make[2]: *** [install-data-yes] Error 127
      
      * configure.ac (MKINSTALLDIRS): Define.
      For reference, we're currently hamstrung by our desire
      to support RHEL5, which still uses gettext-0.14:
      http://bugzilla.redhat.com/523713
      89bdf84b
    • E
      maint: relax git minimum version · c560fc49
      Eric Blake 提交于
      Requiring git 1.6.4, just for the optional GNULIB_SRCDIR support,
      was too harsh.  Resynchronize from gnulib.
      
      * .gnulib: Import from latest gnulib.
      * bootstrap: Re-synchronize from .gnulib/build-aux.
      * bootstrap.conf: Drop git to 1.5.5.
      * README-hacking: Document use of GNULIB_SRCDIR.
      c560fc49
    • R
      Ignore SIGWINCH in remote client call to poll(2) (RHBZ#567931). · f4a43df5
      Richard Jones 提交于
      In bug 567931 we found that virt-top would exit occasionally
      when the terminal window was resized.  Tracking this down it
      turned out that SIGWINCH was being delivered to the process at
      exactly the point where the libvirt remote driver was calling
      poll(2) waiting for a reply from libvirtd.
      
      This caused the poll(2) call to be interrupted (returning errno
      EINTR).  However handling EINTR the same way as EAGAIN was not
      the solution to this problem since we found previously that this
      would break Ctrl-C handling (commit 47fec8ea).
      
      The correct solution is to mask out SIGWINCH for the duration
      of the poll(2) system call.  The per-thread mask is changed and
      restored immediately after the call.  Since we are using
      pthread_sigmask, this should not affect other threads, and
      since we restore the signal mask immediately afterwards it should
      not affect the current thread visibly either.  Other possibly
      problematic signals are SIGCHLD and SIGPIPE and these are
      masked too.
      
      Note use of ignore_value: It's not fatal if we cannot mask out
      SIGWINCH, and in any case pthread_sigmask never fails on Linux
      as long as you supply the correct arguments.
      
      I tested this patch and it cures the original problem with
      virt-top.
      f4a43df5
  2. 24 2月, 2010 8 次提交
    • S
      Add descriptions for macvtap direct type interfaces · c7b85e37
      Stefan Berger 提交于
      This adds a description about the 'direct' type of interface recently
      added for macvtap device type support on the host.
      c7b85e37
    • D
      Format FS pools on creation · b738016b
      Dave Allan 提交于
      Create the filesystem on the partition used by the pool
      * configure.ac: check for mkfs availability
      * libvirt.spec.in: add extra require on util-linux for mkfs
      * src/storage/storage_backend_fs.c: run mkfs with the expected
        fs type when creating a filesystem pool
      b738016b
    • E
      maint: sort .gitignore · 9ad255f9
      Eric Blake 提交于
      Fallout from the new bootstrap.
      
      * .gitignore: Commit sorting done by bootstrap.
      * build-aux/.gitignore: Likewise.
      * po/.gitignore: Likewise.
      9ad255f9
    • E
      maint: import modern bootstrap · 38c9440a
      Eric Blake 提交于
      Copy the latest gnulib bootstrap, which runs autoreconf and
      generates po/Makevars for us.  Other improvements include some
      improved prerequisite tool checking.
      
      This also fixes a bug in the .pot files, regarding the copyright holder.
      
      * bootstrap: Update to version in .gnulib/build-aux.
      * bootstrap.conf (MSGID_BUGS_ADDRESS, COPYRIGHT_HOLDER, SKIP_PO)
      (gnulib_mk, ACLOCAL, bootstrap_epilogue): Provide overrides.
      * autogen.sh (autoreconf): Avoid redundant autoreconf if bootstrap
      was run.
      * po/Makevars: Delete, now that bootstrap creates it.
      * po/.gitignore: Update.
      38c9440a
    • E
      maint: start factoring bootstrap · 1a51d05f
      Eric Blake 提交于
      Borrow ideas from gnulib/build-aux/bootstrap, in order to factor the
      specifics of libvirt into bootstrap.conf, while allowing future
      upgrades of bootstrap to happen with less effort.
      
      * bootstrap (gnulib_tool): Update invocation to be closer to
      gnulib's version.  Move libvirt specifics...
      * bootstrap.conf: ...into new file.
      1a51d05f
    • E
      maint: fix quoting in autogen.sh · f1ef0e31
      Eric Blake 提交于
      * autogen.sh (srcdir, THEDIR, OBJ_DIR): Use proper quoting.
      (.git-module-status): Abort if bootstrap fails.
      f1ef0e31
    • J
      build: update gnulib submodule to latest · d2a97734
      Jim Meyering 提交于
      * cfg.mk (local-checks-to-skip): Disable sc_prohibit_hash_without_use
      for now, since it fails with a false-positive match.
      d2a97734
    • J
      virFork: placate static analyzers: ignore pthread_sigmask return value · 0e69905d
      Jim Meyering 提交于
      * src/util/util.c: Include "ignore-value.h".
      (virFork): We really do want to ignore pthread_sigmask failure.
      0e69905d
  3. 23 2月, 2010 11 次提交
  4. 22 2月, 2010 1 次提交
    • J
      Create raw storage files with O_DSYNC (again) · 9568c1d9
      Jiri Denemark 提交于
      Recently we introduced O_DSYNC flag when creating raw storage files to
      avoid filling all disk cache with dirty pages. However, the patch got
      lost when virStorageBackendCreateRaw was reworked using
      virFileOperation. Let's use O_DSYNC again.
      9568c1d9
  5. 21 2月, 2010 2 次提交
  6. 20 2月, 2010 6 次提交
    • D
      Fix daemon-conf invalid failures · b4bf5125
      David Allan 提交于
      The daemon-conf test would fail on my system if there was a system libvirtd
      running.  In the course of troubleshooting that problem, I discovered that the
      daemon-conf script would always fail if run by itself because it found the line:
      
      \# that each "PARAMETER = VALUE" line in this file have the parameter
      
      which it mistook for a line containing a parameter.  I have changed the test to
      avoid mistaking a line containing \"PARAMETER = VALUE\" for a parameter line.
      
      The corrupted config tests turned out to be failing because the test daemon was
      discovering the pid file from the running daemon and exiting before it processed
      the test config file.  Specifying the pid file for the corrupt config tests in
      the same way as for the valid config test solved that problem.
      b4bf5125
    • J
      virsh.c: avoid leak on OOM error path · 27fc6782
      Jim Meyering 提交于
      * tools/virsh.c (cmdCPUBaseline): Also free "buffer" and "list" upon OOM.
      27fc6782
    • J
      virBufferVSprintf: do not omit va_end(argptr) call · 72919f3d
      Jim Meyering 提交于
      * src/util/buf.c (virBufferVSprintf): Do not omit va_end(argptr).
      Improved-by: Daniel Veillard.
      72919f3d
    • J
      xend_internal.c: don't dereference NULL for unexpected input · 14ee6a66
      Jim Meyering 提交于
      * src/xen/xend_internal.c (xenDaemonDomainSetAutostart): Avoid a NULL
      dereference upon non-SEXPR_VALUE'd on_xend_start.  This bug was
      introduced by commit 37ce5600.
      14ee6a66
    • L
      Use virFileOperation hook function in virStorageBackendFileSystemVolBuild · 6ef20bb7
      Laine Stump 提交于
      There were a few operations on the storage volume file that were still
      being done as root, which will fail if the file is on a root-squashed
      NFS share. The result was that attempts to create a storage volume of
      type "raw" on a root-squashed NFS share would fail.
      
      This patch uses the newly introduced "hook" function in
      virFileOperation to execute all those file operations in the child
      process that's run under the uid that owns the file (and, presumably,
      has permission to write to the NFS share)
      
      * src/storage/storage_backend.c: use virFileOperation() in
        virStorageBackendCreateRaw, turning virStorageBackendCreateRaw()
        into a new createRawFileOpHook() hook
      6ef20bb7
    • L
      Rename virFileCreate to virFileOperation, add hook function · fbadc2b6
      Laine Stump 提交于
      It turns out it is also useful to be able to perform other operations
      on a file created while running as a different uid (eg, write things
      to that file), and possibly to do this to a file that already
      exists. This patch adds an optional hook function to the renamed (for
      more accuracy of purpose) virFileOperation; the hook will be called
      after the file has been opened (possibly created) and gid/mode
      checked/set, before closing it.
      
      As with the other operations on the file, if the VIR_FILE_OP_AS_UID
      flag is set, this hook function will be called in the context of a
      child process forked from the process that called virFileOperation.
      The implication here is that, while all data in memory is available to
      this hook function, any modification to that data will not be seen by
      the caller - the only indication in memory of what happened in the
      hook will be the return value (which the hook should set to 0 on
      success, or one of the standard errno values on failure).
      
      Another piece of making the function more flexible was to add an
      "openflags" argument. This arg should contain exactly the flags to be
      passed to open(2), eg O_RDWR | O_EXCL, etc.
      
      In the process of adding the hook to virFileOperation, I also realized
      that the bits to fix up file owner/group/mode settings after creation
      were being done in the parent process, which could fail, so I moved
      them to the child process where they should be.
      
      * src/util/util.[ch]: rename and rework virFileCreate-->virFileOperation,
        and redo flags in virDirCreate
      * storage/storage_backend.c, storage/storage_backend_fs.c: update the
        calls to virFileOperation/virDirCreate to reflect changes in the API,
        but don't yet take advantage of the hook.
      fbadc2b6
  7. 19 2月, 2010 8 次提交
    • D
      qemu: Check for IA64 kvm · 269556e5
      Dustin Xiong 提交于
      ACPI feature bit dropped: I asked internally if the -no-acpi option
      had any meaning for IA64, and was told 'probably not'.
      269556e5
    • C
      remote: Print ssh stderr on connection failure · 7c7b194c
      Cole Robinson 提交于
      7c7b194c
    • Y
      fix multiple veth problem for OpenVZ · ead3410f
      Yuji NISHIDA 提交于
      Fix multiple veth problem.
      NETIF setting was overwritten after first CT because any CT could not be
      found by name.
      * src/openvz/openvz_conf.c src/openvz/openvz_conf.h: add the
        openvzGetVEID lookup function
      * src/openvz/openvz_driver.c: use it in openvzDomainSetNetwork()
      ead3410f
    • C
      Better error reporting for failed migration · b97c24b2
      Chris Lalancette 提交于
      If the hostname as returned by "gethostname" resolves
      to "localhost" (as it does with the broken Fedora-12
      installer), then live migration will fail because the
      source will try to migrate to itself.  Detect this
      situation up-front and abort the live migration before
      we do any real work.
      
      * src/util/util.h src/util/util.c: add a new virGetHostnameLocalhost
        with an optional localhost check, and rewire virGetHostname() to use
        it
      * src/libvirt_private.syms: expose the new function
      * src/qemu/qemu_driver.c: use it in qemudDomainMigratePrepare2()
      b97c24b2
    • C
      Make virDomainObjFormat static · 8ba9e794
      Chris Lalancette 提交于
      * src/conf/domain_conf.c: make function static
      * src/conf/domain_conf.h: remove it from header
      8ba9e794
    • C
      Make an error message in PCI util code clearer · ee38d7e0
      Chris Lalancette 提交于
      * src/util/pci.c: update 2 message on pciRead errors
      ee38d7e0
    • S
      macvtap mac_filter support · b3e7890a
      Stefan Berger 提交于
      This patch adds the mac_filter support to the macvtap device.
      b3e7890a
    • J
      virsh: be careful to return "FALSE" upon OOM · 62f4ae15
      Jim Meyering 提交于
      * tools/virsh.c (cmdCPUBaseline): Add an explicit "return" statement
      after the "no_memory:" label.
      62f4ae15