Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 15 11月, 2016 1 次提交
  3. 14 11月, 2016 4 次提交
    • M
      qemuDomainAttachNetDevice: Avoid @originalError leak · ca1ac664
      由 Michal Privoznik 提交于 
      Coverity identified that this variable might be leaked. And it's
right. If an error occurred and we have to roll back the control
jumps to try_remove label where we save the current error (see
0e82fa4c for more info). However, inside the code a jump onto
other label is possible thus leaking the error object.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      ca1ac664
    • E
      admin: Use the newly introduced close callback handling helpers · e555ed6f
      由 Erik Skultety 提交于 
      Use the newly introduced close callback helpers to make the code look just a
bit cleaner and more importantly, to fix the following memleak regarding a
dangling virAdmConnect object reference caused by assigning NULL to the close
callback data once the catch-disconnect routine used the callback followed
by a comparison of NULL to the originally defined close callback (which at that
moment had already been NULL'd by remoteAdminClientCloseFunc) in
virAdmConnectCloseCallbackUnregister.

717 (88 direct, 629 indirect) bytes in 1 blocks are definitely lost record
 110 of 141
    at 0x4C2A988: calloc (vg_replace_malloc.c:711)
    by 0x530696F: virAllocVar (viralloc.c:560)
    by 0x53689E6: virObjectNew (virobject.c:193)
    by 0x5368B5E: virObjectLockableNew (virobject.c:219)
    by 0x4E3E7EE: virAdmConnectNew (datatypes.c:900)
    by 0x4E398BB: virAdmConnectOpen (libvirt-admin.c:220)
    by 0x10D3E3: vshAdmConnect (virt-admin.c:161)
    by 0x10D624: vshAdmReconnect (virt-admin.c:215)
    by 0x10DB0A: cmdConnect (virt-admin.c:353)
    by 0x11288F: vshCommandRun (vsh.c:1313)
    by 0x10FDB6: main (virt-admin.c:1439)

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1357358Signed-off-by: NErik Skultety <eskultet@redhat.com>
      e555ed6f
    • E
      datatypes: Introduce some admin-related close callback handling helpers · 7cea74a3
      由 Erik Skultety 提交于 
      Well, there were three different spots where closeCallback->freeCallback was
called, not looking the same --> potential for bugs - and there indeed is a bug
with refcounting of the @conn object. So this patch partially follows the path
set by commit 24dbb69f by introducing some close callback helpers both to
replace all the spots where we call clean the close callback data with a
dedicated function and to be able to fix the refcounting bug causing a memleak.
Signed-off-by: NErik Skultety <eskultet@redhat.com>
      7cea74a3
    • E
      admin: Remove unnecessary @conn object locking · d46a1e5d
      由 Erik Skultety 提交于 
      The only place we change the @conn object is actually virAdmConnectOpen
routine, thus at the moment we don't really need to lock it, given the fact that
what we're trying to do here is to change the closeCallback object which is a
lockable object itself, so that should be enough to avoid races.
Signed-off-by: NErik Skultety <eskultet@redhat.com>
      d46a1e5d
  5. 12 11月, 2016 1 次提交
  7. 11 11月, 2016 5 次提交
    • P
      qemu: Generate memory device aliases according to slot number · b7798a07
      由 Peter Krempa 提交于 
      The memory device alias needs to be treated as machine ABI as qemu is
using it in the migration stream for section labels. To simplify this
generate the alias from the slot number unless an existing broken
configuration is detected.

With this patch the aliases are predictable and even certain
configurations which would not be migratable previously are fixed.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1359135
      b7798a07
    • P
      qemu: Assign slots to memory devices prior to usage · ce1ee02a
      由 Peter Krempa 提交于 
      As with other devices assign the slot number right away when adding the
device. This will make the slot numbers static as we do with other
addressing elements and it will ultimately simplify allocation of the
alias in a static way which does not break with qemu.
      ce1ee02a
    • P
      qemu: process: detect if dimm aliases are broken on reconnect · 93d9ff3d
      由 Peter Krempa 提交于 
      Detect on reconnect to a running qemu VM whether the alias of a
hotpluggable memory device (dimm) does not match the dimm slot number
where it's connected to. This is necessary as qemu is actually
considering the alias as machine ABI used to connect the backend object
to the dimm device.

This will require us to keep them consistent so that we can reliably
restore them on migration. In some situations it was currently possible
to create a mismatched configuration and qemu would refuse to restore
the migration stream.

To avoid breaking existing VMs we'll need to keep the old algorithm
though.
      93d9ff3d
    • P
      conf: Allow specifying only the slot number for hotpluggable memory · 810e9a80
      由 Peter Krempa 提交于 
      Simplify handling of the 'dimm' address element by allowing to specify
the slot number only. This will allow libvirt to allocate slot numbers
before starting qemu.
      810e9a80
    • D
      xen: remove legacy hack for RHEL-5 Xen · b353cc3c
      由 Daniel P. Berrange 提交于 
      We dropped support for RHEL-5 vintage Xen a while ago,
but forgot to remove some of the hacks for it.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      b353cc3c
  9. 10 11月, 2016 7 次提交
  11. 09 11月, 2016 6 次提交
  13. 08 11月, 2016 6 次提交
  15. 04 11月, 2016 3 次提交
  17. 03 11月, 2016 3 次提交
  19. 02 11月, 2016 4 次提交