Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 03 8月, 2017 1 次提交
  3. 02 8月, 2017 3 次提交
  5. 01 8月, 2017 1 次提交
  7. 31 7月, 2017 1 次提交
  9. 28 7月, 2017 1 次提交
  11. 27 7月, 2017 1 次提交
    • J
      storage: Disallow usage of the HBA for a fc_host backing · 43e6686c
      由 John Ferlan 提交于 
      Disallow providing the wwnn/wwpn of the HBA in the adapter XML:

  <adapter type='fc_host' [parent='scsi_hostN'] wwnn='HBA_wwnn'
    wwpn='HBA_wwpn'/>

This should be considered a configuration error since a vHBA
would not be created. In order to use the HBA as the backing the
following XML should be used:

  <adapter type='scsi_host' name='scsi_hostN'/>

So add a check prior to the checkParent call to validate that
the provided wwnn/wwpn resolves to a vHBA and not an HBA.
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      43e6686c
  13. 26 7月, 2017 2 次提交
  15. 24 7月, 2017 2 次提交
    • M
      docs: Span cells if there's not doc text for enum val · 099a5ef8
      由 Michal Privoznik 提交于 
      When generating HTML documentation we put enum values into a
table so that we can display the value's name, numerical value
and description (if it has one). Now the last part is problem. If
the value doesn't have description the table row has just two
cells and if it has one the row counts three cells. This makes
HTML engines render the description into very little space - for
instance see:

  html/libvirt-libvirt-domain.html#virDomainMemoryStatTags

We can avoid this problem if we let the cell that corresponds to
numerical value span over two cells if there's no description.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: NMartin Kletzander <mkletzan@redhat.com>
      099a5ef8
    • M
      apibuild.py: Handle enum comments properly · 6efdd94d
      由 Michal Privoznik 提交于 
      After f4cb85c6 we only have two options for placing enum
values descriptions. It's either:

    typedef enum {
        /* Some long description. Therefore it's placed before
         * the value. */
        VIR_ENUM_A_VAL = 1,
    } virEnumA;

or:

    typedef enum {
        VIR_ENUM_B_VAL = 1, /* Some short description */
    } virEnumB;

However, our apibuild.py script is not able to deal with the
former one. It messes up comments. To fix this couple of things
needs to be done:

a) DO NOT reset self.comment in parseEnumBlock(). This is a
result from our tokenizer. Upon calling token() if it finds a
comment block it stores it in self.comment and returns the next
token (which is not comment). Therefore, if we reset self.comment
we might lose the first comment in the enum block.

b) we need a variable to track if the current enum block uses
value descriptions before or after values. That is if it's type
virEnumA or virEnumB. Depending on that, it we're dealing with
virEnumA type and the current token is a comma ',' we can add the
value into the list as we already have everything needed:
comment, name and value.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: NMartin Kletzander <mkletzan@redhat.com>
      6efdd94d
  17. 21 7月, 2017 1 次提交
    • S
      qemu: Enable NUMA node tag in pci-root for PPC64 · e5a05799
      由 Shivaprasad G Bhat 提交于 
      This patch addresses the same aspects on PPC the bug 1103314 addressed
on x86.

PCI expander bus creates multiple primary PCI busses, where each of these
busses can be assigned a specific NUMA affinity, which, on x86 is
advertised through ACPI on a per-bus basis.

For SPAPR, a PHB's NUMA affinities are assigned on a per-PHB basis, and
there is no mechanism for advertising NUMA affinities to a guest on a
per-bus basis. So, even if qemu-ppc manages to get some sort of multi-bus
topology working using PXB, there is no way to expose the affinities
of these busses to the guest. It can only be exposed on a per-PHB/per-domain
basis.

So patch enables NUMA node tag in pci-root controller on PPC.

The way to set the NUMA node is through the numa_node option of
spapr-pci-host-bridge device. However for the implicit PHB, the only way
to set the numa_node is from the -global option. The -global option applies
to all the PHBs unless explicitly specified with the option on the
respective PHB of CLI. The default PHB has the emulated devices only, so
the patch prevents setting the NUMA node for the default PHB.
Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>
      e5a05799
  19. 19 7月, 2017 1 次提交
    • J
      docs: schema: make disk driver name attribute optional · b494e09d
      由 Jim Fehlig 提交于 
      /domain/devices/disk/driver/@name is not a required or mandatory
attribute according to formatdomain, and indeed it was agreed on
IRC that the attribute is "optional for input, recommended (but
not required) for output". Currently the schema requires the
attribute, causing virt-xml-validate to fail on disk config where
the driver name is not explicitly specified. E.g.

# cat test.xml | grep -A 5 cdrom
    <disk type='file' device='cdrom'>
      <driver type='raw'/>
      <target dev='hdb' bus='ide'/>
      <readonly/>
      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
    </disk>

# virt-xml-validate test.xml
Relax-NG validity error : Extra element devices in interleave
test.xml:21: element devices: Relax-NG validity error : Element domain failed to validate content
test.xml fails to validate

Relaxing the name attribute to be optional fixes the validation

# virt-xml-validate test.xml
test.xml validates
      b494e09d
  21. 18 7月, 2017 1 次提交
  23. 16 7月, 2017 1 次提交
  25. 15 7月, 2017 3 次提交
  27. 12 7月, 2017 1 次提交
  29. 11 7月, 2017 3 次提交
  31. 10 7月, 2017 2 次提交
  33. 08 7月, 2017 1 次提交
  35. 05 7月, 2017 3 次提交
  37. 04 7月, 2017 2 次提交
  39. 30 6月, 2017 2 次提交
  41. 29 6月, 2017 1 次提交
  43. 28 6月, 2017 1 次提交
  45. 27 6月, 2017 1 次提交
  47. 26 6月, 2017 3 次提交
    • A
      HACKING: Drop from the git repository · d6725518
      由 Andrea Bolognani 提交于 
      Despite being a generated file, HACKING has been tracked in
the git repository along with actual source files. As far as
I'm aware, it's the only generated file for which that happens.

Times and times again, people[1] have committed changes to
the source file without refreshing the generated copy at the
same time.

The rationale for tracking the generated file is to help out
people who just cloned the git repository looking to contribue;
however, README-hacking already contains enough information to
get perspective contributors to a place where they can simply
look at docs/hacking.html instead.

[1] Mostly me, to be honest
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      d6725518
    • A
      docs: Point to hacking.html from contribute.html · d76f4258
      由 Andrea Bolognani 提交于 
      People looking to help out should really go through the
contributor guidelines when getting started, so the more
documents point to them the better.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      d76f4258
    • A
      hacking: Improve 'git send-email' documentation · 79c1900f
      由 Andrea Bolognani 提交于 
      For the benefit of first time contributors, we point out that 'git
send-email' might have to be installed separately; however, we omit
the fact that some configuration will likely be needed before it
can successfully deliver patches to the mailing list.

Some minor tweaks to the existing contents are included as well.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
      79c1900f
  49. 20 6月, 2017 1 次提交