1. 21 11月, 2019 2 次提交
  2. 19 11月, 2019 2 次提交
  3. 15 11月, 2019 3 次提交
    • P
      replace use of gnulib snprintf by g_snprintf · 43b01ef2
      Pavel Hrdina 提交于
      Glib implementation follows the ISO C99 standard so it's safe to replace
      the gnulib implementation.
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      Reviewed-by: NPeter Krempa <pkrempa@redhat.com>
      43b01ef2
    • J
      Add API to change qemu agent response timeout · 95f5ac9a
      Jonathon Jongsma 提交于
      Some layered products such as oVirt have requested a way to avoid being
      blocked by guest agent commands when querying a loaded vm. For example,
      many guest agent commands are polled periodically to monitor changes,
      and rather than blocking the calling process, they'd prefer to simply
      time out when an agent query is taking too long.
      
      This patch adds a way for the user to specify a custom agent timeout
      that is applied to all agent commands.
      
      One special case to note here is the 'guest-sync' command. 'guest-sync'
      is issued internally prior to calling any other command. (For example,
      when libvirt wants to call 'guest-get-fsinfo', we first call
      'guest-sync' and then call 'guest-get-fsinfo').
      
      Previously, the 'guest-sync' command used a 5-second timeout
      (VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT), whereas the actual command that
      followed always blocked indefinitely
      (VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK). As part of this patch, if a
      custom timeout is specified that is shorter than
      5 seconds,  this new timeout is also used for 'guest-sync'. If there is
      no custom timeout or if the custom timeout is longer than 5 seconds, we
      will continue to use the 5-second timeout.
      Signed-off-by: NJonathon Jongsma <jjongsma@redhat.com>
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
      95f5ac9a
    • J
      Use g_mkstemp_full instead of mkostemp(s) · 4ac47730
      Ján Tomko 提交于
      With g_mkstemp_full, there is no need to distinguish between
      mkostemp and mkostemps (no suffix vs. a suffix of a fixed length),
      because the GLib function looks for the XXXXXX pattern everywhere
      in the string.
      
      Use S_IRUSR | S_IWUSR for the permissions and do not pass O_RDWR
      in flags since it's implied.
      Signed-off-by: NJán Tomko <jtomko@redhat.com>
      Reviewed-by: NPeter Krempa <pkrempa@redhat.com>
      4ac47730
  4. 14 11月, 2019 3 次提交
  5. 13 11月, 2019 1 次提交
  6. 12 11月, 2019 2 次提交
  7. 08 11月, 2019 1 次提交
  8. 07 11月, 2019 1 次提交
  9. 25 10月, 2019 2 次提交
  10. 24 10月, 2019 1 次提交
    • M
      Drop needless ret variable · 3b4df5d3
      Michal Privoznik 提交于
      In few places we have the following code pattern:
      
        int ret;
        ... /* @ret is not accessed here */
        ret = f(...);
        return ret;
      
      This pattern can be written less verbose:
      
        ...
        return f(...);
      
      This patch was generated with following coccinelle spatch:
      
        @@
        type T;
        constant C;
        expression f;
        identifier ret;
        @@
        -T ret = C;
         ... when != ret
        -ret = f;
        -return ret;
        +return f;
      
      Afterwards I needed to fix a few places, e.g. comment in
      virDomainNetIPParseXML() was removed too because coccinelle
      thinks it refers to @ret while in fact it doesn't. Also in few
      places it replaced @ret declaration with a few spaces instead of
      removing the line. But nothing terribly wrong.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
      3b4df5d3
  11. 21 10月, 2019 5 次提交
  12. 17 10月, 2019 7 次提交
  13. 16 10月, 2019 4 次提交
  14. 15 10月, 2019 3 次提交
  15. 08 10月, 2019 2 次提交
  16. 07 10月, 2019 1 次提交