1. 02 11月, 2018 1 次提交
  2. 31 10月, 2018 1 次提交
  3. 30 10月, 2018 3 次提交
  4. 23 10月, 2018 2 次提交
  5. 22 10月, 2018 1 次提交
  6. 20 10月, 2018 1 次提交
  7. 19 10月, 2018 3 次提交
  8. 18 10月, 2018 2 次提交
  9. 17 10月, 2018 3 次提交
  10. 15 10月, 2018 8 次提交
  11. 12 10月, 2018 5 次提交
    • P
      util: storage: Properly parse URIs with missing trailing slash · 6e7e965d
      Peter Krempa 提交于
      The URI parser used by libvirt does not populate uri->path if the
      trailing slash is missing. The code virStorageSourceParseBackingURI
      would then not populate src->path.
      
      As only NBD network disks are allowed to have the 'name' field in the
      XML defining the disk source omitted we'd generate an invalid XML which
      we'd not parse again.
      
      Fix it by populating src->path with an empty string if the uri is
      lacking slash.
      
      As pointed out above NBD is special in this case since we actually allow
      it being NULL. The URI path is used as export name. Since an empty
      export does not make sense the new approach clears the src->path if the
      trailing slash is present but nothing else.
      
      Add test cases now to cover all the various cases for NBD and non-NBD
      uris as there was to time only 1 test abusing the quirk witout slash for
      NBD and all other URIs contained the slash or in case of NBD also the
      export name.
      Signed-off-by: NPeter Krempa <pkrempa@redhat.com>
      6e7e965d
    • P
      util: storage: Rename '@path' argument of virStorageSourceParseBackingURI · 4471f770
      Peter Krempa 提交于
      The name is misleading. Change it to 'uristr' so that 'path' can be
      reused in the proper context later.
      Signed-off-by: NPeter Krempa <pkrempa@redhat.com>
      4471f770
    • E
      virsh: Fix regression with duplicated error messages · 35966308
      Eric Blake 提交于
      Commit 4f4c3b13 (v3.3) fixed an issue where performing cleanup of
      libvirt objects could sometimes lose error messages, by adding code
      to copy the libvirt error into last_error prior to cleanup paths.
      However, it caused a regression: on other paths, some errors are now
      printed twice, if libvirt still remembers in its thread-local
      storage that an error was set even after virsh cleared last_error.
      For example:
      
      $ virsh -c test:///default snapshot-delete test blah
      error: Domain snapshot not found: no domain snapshot with matching name 'blah'
      error: Domain snapshot not found: no domain snapshot with matching name 'blah'
      
      Fix things by telling libvirt to discard any thread-local errors at
      the same time virsh prints an error message (whether or not the libvirt
      error is the same as what is stored in last_error).
      
      Update the virsh-undefine testsuite (partially reverting portions of
      commit b620bdee, by removing -q, to more easily pinpoint which commands
      are causing which messages), now that there is only one error message
      instead of two.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
      35966308
    • O
      rpc: reproducible genprotocol output · 297ed93a
      Olaf Hering 提交于
      If the same source gets built twice ('build same source on different
      hosts at different times') the resulting files may differ.
      Fix this by sorting the hash keys before usage.
      Signed-off-by: NOlaf Hering <olaf@aepfle.de>
      297ed93a
    • J
      qemu: Remove unused qemuProcessAutostartAll · 86a6cb13
      John Ferlan 提交于
      The function was never defined in source, just the protoype.
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      86a6cb13
  12. 11 10月, 2018 1 次提交
  13. 10 10月, 2018 5 次提交
  14. 09 10月, 2018 2 次提交
  15. 08 10月, 2018 2 次提交