1. 18 6月, 2015 14 次提交
    • P
      conf: Introduce helper to help getting correct def for getter functions · 47171cd1
      Peter Krempa 提交于
      virDomainObjGetOneDef will help to retrieve the correct definition
      pointer from @vm in cases where VIR_DOMAIN_AFFECT_LIVE and
      VIR_DOMAIN_AFFECT_CONFIG are mutually exclusive. The function simply
      returns the correct pointer. This similarly to virDomainObjGetDefs will
      greatly simplify the code.
      47171cd1
    • P
      conf: Fix virDomainObjGetDefs when getting persistent config on a live vm · 63aaf69b
      Peter Krempa 提交于
      If @flags contains only VIR_DOMAIN_AFFECT_CONFIG and @vm is active, the
      function would return the active config rather than the persistent one
      that it should return. This happened due to the fact that
      virDomainObjGetDefs was checking the updated flags which may not contain
      VIR_DOMAIN_AFFECT_LIVE if it is not requested even if @vm is active.
      
      Additionally the function would not take the flags into account when
      setting the pointers which was later used to determine whether the code
      needs to update the given configuration.
      
      The mistake was caught by the virt-test suite.
      63aaf69b
    • J
      qemu: implement address for isa-serial · f486bb04
      James Cowgill 提交于
      I needed to specify the iobase address for certain exotic mips configurations.
      Signed-off-by: NJames Cowgill <james410@cowgill.org.uk>
      f486bb04
    • L
      qemu: Add a check for slot and base dimm address conflicts · cb7e13ff
      Luyao Huang 提交于
      When hotplugging a memory device, there wasn't a check to determine
      if there is a conflict with the address space being used by the to
      be added memory device and any existing device which is disallowed by qemu.
      
      This patch adds a check to ensure the new device address doesn't
      conflict with any existing device.
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      cb7e13ff
    • P
      daemon: Add the admin service to the admin server only if it was allocated · d7d910d9
      Peter Krempa 提交于
      If the admin service is disabled it would not be allocated, but the NULL
      pointer still would be added to the admin server. Since
      virNetServerAddService would dereference it, the daemon would crash.
      
      Move the service registration into the block that allocates it.
      d7d910d9
    • P
      rpc: Actually increase reference count on @srv in virNetDaemonAddServer · 4002395d
      Peter Krempa 提交于
      VIR_APPEND_ELEMENT would clear @srv to NULL after it successfully
      inserted it thus the reference count could not be increased afterwards.
      
      Switch to VIR_APPEND_ELEMENT_COPY. This fixes crash after terminating
      the daemon.
      4002395d
    • M
      parallels: Fix false error messages in libvirt log · 0c151004
      Mikhail Feoktistov 提交于
      There was many errors in libvirt.log caused by prlsdkDelNet function because
      job variable was always initialized as PRL_INVALID_HANDLE
      In this patch job variable gets return value of PrlSrv_DeleteVirtualNetwork function()
      0c151004
    • M
      parallels: Fix initialization of buflen variable in each loop iteration · fad9b77e
      Mikhail Feoktistov 提交于
      We need to initialize buflen every time when we get network adapter's
      friendly name because we call PrlVmDev_GetFriendlyName in a loop
      fad9b77e
    • J
      remove redundant condition · 6fab625f
      Ján Tomko 提交于
      If the address type is SPAPRVIO, it will match the != NONE condition.
      6fab625f
    • M
      virSysinfo: Introduce SMBIOS type 2 support · a9a27e60
      Michal Privoznik 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1220527
      
      This type of information defines attributes of a system
      baseboard. With one exception: board type is yet not implemented
      in qemu so it's not introduced here either.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      a9a27e60
    • J
      qemu: Report all supported machine types in capabilities · beca509e
      Jiri Denemark 提交于
      Some machine types are only reported as canonical names for other
      machine types, which make it a bit harder to find what machine types are
      supported by a specific QEMU binary. Ideally, one would just use
      /capabilities/guest/arch[@name='...']/machine/text() XPath to get a list
      of all supported machine types, but it doesn't work right now.
      
      For example, we report
      
          <machine canonical='pc-i440fx-2.3' maxCpus='255'>pc</machine>
      
      in guest capabilities, but the corresponding
      
          <machine maxCpus='255'>pc-i440fx-2.3</machine>
      
      is missing.
      
      This is a result of QMP probing. With "-machine ?" parsing QEMU sends
      us two lines:
      
      pc                   Standard PC (i440FX + PIIX, 1996) (alias of pc-i440fx-2.3)
      pc-i440fx-2.3        Standard PC (i440FX + PIIX, 1996) (default)
      
      while query-machines QMP command reports both in the same entry:
      
      {"name": "pc-i440fx-2.3", "is-default": true, "cpu-max": 255, "alias": "pc"}
      
      Let's make sure we always report separate <machine/> for both the
      canonical name and its alias and using the canonical name as the default
      machine type (i.e., inserting it before its alias) in case is-default is
      true.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1229666Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
      beca509e
    • M
      tests: Sort EXTRA_DIST in the Makefile · 7690a5a8
      Michal Privoznik 提交于
      We tend to keep the folders in the EXTRA_DIST sorted alphabetically.
      However, we've failed sometimes and the list is not ordered anymore.
      Reorder it back.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      7690a5a8
    • M
      daemon: Don't just include admin RPC · 13e5ea8b
      Michal Privoznik 提交于
      So, it's a little paradox that we use the file twice. Firstly to build
      libvirt-admin.la (a client side of the Admin API), then once again to
      build the server side. Well, the problem is, this does not play nicely
      with the distclean since the file is generated. So while it's removed
      in the src/ the distclean running in daemon/ will not find the file
      and fail. The file is needed because it contains the RPC wrappers. So
      let's leave the client code as is and from the daemon/ just link the
      client library. The linker will find desired symbols and use them.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      13e5ea8b
    • L
      nodedev: update netdev feature bits before each dumpxml · 30708179
      Laine Stump 提交于
      As with several other attributes of devices (link status, sriov VF
      list, IOMMU group list), the detdev feature bits aren't automatically
      updated in the nodedev driver's cache when they change. In order to
      get a properly up-to-date list when getting the XML of a device, we
      must reget them in update-caps prior to each dumpxml.
      
      This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1232880
      30708179
  2. 17 6月, 2015 8 次提交
  3. 16 6月, 2015 18 次提交