- 25 11月, 2017 10 次提交
-
-
由 John Ferlan 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1425757 The blockdev-add code provides a mechanism to sanely provide user and password-secret arguments for iscsi without placing them on the command line to be viewable by a 'ps -ef' type command or needing to create separate -iscsi devices for each disk/volume found. So modify the iSCSI command line building to check for the presence of the capability in order properly setup and use the domain master secret object to encrypt the password in a secret object and alter the parameters for the command line to utilize. Modify the xml2argvtest to exhibit the syntax for both disk and hostdev configurations.
-
由 John Ferlan 提交于
Detect the capability via the query-qmp-schema for blockdev-add to find the 'password-secret' parameter that will allow the iSCSI code to use the master secret object to encrypt the secret for an and only need to provide the object id of the secret on the command line thus obsfuscating the passphrase.
-
由 John Ferlan 提交于
Rather than building the "file" string in qemuBuildSCSIHostdevDrvStr build it in the called helper.
-
由 John Ferlan 提交于
Since it's not longer used to shuttle the @secinfo, let's remove the private hostdev completely.
-
由 John Ferlan 提交于
Rather than placing/using privateData about secinfo in the hostdev, let's use the virStorageSource private data instead.
-
由 John Ferlan 提交于
Rather than picking apart the two pieces we need/want (path, hosts, and auth)- let's allocate/use a virStorageSourcePtr for iSCSI storage. The end result is that qemuBuildSCSIiSCSIHostdevDrvStr doesn't need to "fake" one for the qemuBuildNetworkDriveStr call.
-
由 Ján Tomko 提交于
Utilize all the newly introduced function to create the evdev node and label it on hotplug and destroy it on hotunplug. This was forgotten in commits bc9ffafc and 67486bb2. https://bugzilla.redhat.com/show_bug.cgi?id=1509866
-
由 Ján Tomko 提交于
Introudce functions that will let us create the evdevs in namespaces and label the devices on input device hotplug/hotunplug.
-
由 Ján Tomko 提交于
Export qemuSetupInputCgroup and introduce qemuTeardownInputCgroup for hotunplug.
-
由 Ján Tomko 提交于
Use it to denadify qemuDomainSetupInput.
-
- 24 11月, 2017 17 次提交
-
-
由 Jason J. Herne 提交于
Libvirt prints an error on startup when it is missing host cpu model information for any queried qemu binary. On s390 we only have host cpu model information for kvm enabled qemu instances. So when virt type is not kvm, this is actually not an error on s390. This patch adds virt type as a parameter to virQEMUCapsInitCPUModelS390, and a new return code 2 for virQEMUCapsInitCPUModel and virQEMUCapsInitCPUModelS390. If the virt type is not kvm then we skip printing the scary error message and return 2 because this case is actually expected behavior. The new return code is meant to differentiate between the failure case and the case where we simply expect the cpu model information to be unattainable. Signed-off-by: NJason J. Herne <jjherne@linux.vnet.ibm.com> Reviewed-by: NBoris Fiuczynski <fiuczy@linux.vnet.ibm.com> Reviewed-by: NMarc Hartmayer <mhartmay@linux.vnet.ibm.com> Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
-
由 Peter Krempa 提交于
Move the setup of the disk attribute to the disk source prepare function which will allow proper usage with JSON props and move the fallback (legacy) generating code into the block which is executed with legacy options. As a side-effect of this change we can clean up propagation of 'cfg' into the command generator. Also it's nice to see that the test output is the same even when the value is generated in a different place.
-
由 Peter Krempa 提交于
Aggregate setup of various aspects of a disk source (secrets, TLS, ...) into one function so that we don't need to call multiple across the code base.
-
由 Peter Krempa 提交于
Match the prefix of the file and choose a name which better describes what happens.
-
由 Peter Krempa 提交于
Improve the formatter so that we can use the 'debug' property straight away when using json.
-
由 Peter Krempa 提交于
The 'file.password-secret' injection should be used only if we are using the old formatter. When formatting the source string from the JSON properties, the property should be added there. Also drop the comment which refers to stuff that will not be used in libvirt since -blockdev is the way to go.
-
由 Peter Krempa 提交于
Qemu has now an internal mechanism for locking images to fix specific cases of disk corruption. This requires libvirt to mark the image as shared so that qemu lifts certain restrictions. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1378242
-
由 Peter Krempa 提交于
'share-rw' for the disk device configures qemu to allow concurrent access to the backing storage. The capability is checked in various supported disk frontend buses since it does not make sense to partially backport it.
-
由 Peter Krempa 提交于
Pivoting to a unsupported storage type might break the assumption that shared disks will not corrupt metadata. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480
-
由 Peter Krempa 提交于
Creating a snapshot would introduce a possibly unsupported member for sharing into the backing chain. Add a check to prevent that from happening. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480
-
由 Peter Krempa 提交于
Disk sharing between two VMs may corrupt the images if the format driver does not support it. Check that the user declared use of a supported storage format when they want to share the disk. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480
-
由 Peter Krempa 提交于
Storage source format backing a shared device (e.g. running a cluster filesystem) needs to support the sharing so that metadata are not corrupted. Add a central function for checking this.
-
由 Peter Krempa 提交于
Use a style that will discourage from adding inline checks.
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
-
由 Peter Krempa 提交于
Move network device validation into a separate function.
-
由 Peter Krempa 提交于
Move the code so that both the new image and old image can be verified in the same function.
-
- 23 11月, 2017 12 次提交
-
-
由 Michal Privoznik 提交于
Since we already have such support for libxl all we need is qemu driver adjustment. And a test case. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Michal Privoznik 提交于
This capability says if qemu is capable of specifying distances between NUMA nodes on the command line. Unfortunately, there's no real way to check this and thus we have to go with version check. QEMU introduced this in 0f203430dd8 (and friend) which was released in 2.10.0. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Jiri Denemark 提交于
When QEMU dies, we read its output stored in a log file and use it for reporting a hopefully useful error. However, virReportError will trim the message to (VIR_ERROR_MAX_LENGTH - 1) characters, which means the end of the log (which likely contains the error message we want to report) may get lost. We should trim the beginning of the log instead. https://bugzilla.redhat.com/show_bug.cgi?id=1335534Signed-off-by: NJiri Denemark <jdenemar@redhat.com> Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Jiri Denemark 提交于
When reading QEMU log for reporting it as an error message, we want to skip "char device redirected to" line. However, this string is not printed at the beginning of a line, which means STRPREFIX will never find it. Signed-off-by: NJiri Denemark <jdenemar@redhat.com> Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Peter Krempa 提交于
Explain that certain attributes formatted with -drive are in fact attributes of the drive itself and not the storage backing it.
-
由 Peter Krempa 提交于
That's a disk frontend attribute. Move the code to a separate function since it's non-trivial and call it from the frontend attribute formatter.
-
由 Peter Krempa 提交于
Isolate it from the other code.
-
由 Peter Krempa 提交于
Move all logic depending on whether we are solely formatting -drive (no -device along with it) into one block.
-
由 Peter Krempa 提交于
Move together sections which are conditionaly executed depending on whether -device will be used together with the -drive.
-
由 Peter Krempa 提交于
Disk serial is not a property of the image but of the disk frontend. Account for this appropriately.
-
由 Peter Krempa 提交于
Historically we've formatted a lot of the attributes of a disk (disk geometry, etc) with -drive. Since we use -device now, they should be formatted there. Extract them to a separate function for keeping compatibility with SDcards which still use only -drive. Start this by moving the geometry into a separate function.
-
由 Peter Krempa 提交于
When doing block commit we need to allow write for members of the backing chain so that we can commit the data into them. qemuDomainDiskChainElementPrepare was used for this which since commit 786d8d91 calls qemuDomainNamespaceSetupDisk which has very adverse side-effects, namely it relabels the nodes to the same label it has in the main namespace. This was messing up permissions for the commit operation since its touching various parts of a single backing chain. Since we are are actually not introducing new images at that point add a flag for qemuDomainDiskChainElementPrepare which will refrain from calling to the namespace setup function. Calls from qemuDomainSnapshotCreateSingleDiskActive and qemuDomainBlockCopyCommon do introduce new members all calls from qemuDomainBlockCommit do not, so the calls are anotated accordingly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1506072
-
- 20 11月, 2017 1 次提交
-
-
由 Michal Privoznik 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1434451 Just like in 9324f67a we need to put default pci-root alias onto the command line instead of the one provided by user. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-