1. 26 4月, 2016 17 次提交
    • J
      secret: Introduce virSecretObjGetValue and virSecretObjGetValueSize · 43d3e3c1
      John Ferlan 提交于
      Introduce the final accessor's to _virSecretObject data and move the
      structure from virsecretobj.h to virsecretobj.c
      
      The virSecretObjSetValue logic will handle setting both the secret
      value and the value_size. Some slight adjustments to the error path
      over what was in secretSetValue were made.
      
      Additionally, a slight logic change in secretGetValue where we'll
      check for the internalFlags and error out before checking for
      and erroring out for a NULL secret->value. That way, it won't be
      obvious to anyone that the secret value wasn't set rather they'll
      just know they cannot get the secret value since it's private.
      43d3e3c1
    • J
      secret: Introduce virSecretObj{Get|Set}Def · 9e1e5621
      John Ferlan 提交于
      Introduce fetch and set accessor to the secretObj->def field for usage
      by the driver to avoid the driver needing to know the format of virSecretObj
      9e1e5621
    • J
      secret: Introduce virSecretObjSave{Config|Data} · ac9ffd60
      John Ferlan 提交于
      Move and rename the secretRewriteFile, secretSaveDef, and secretSaveValue
      from secret_driver to virsecretobj
      
      Need to make some slight adjustments since the secretSave* functions
      called secretEnsureDirectory, but otherwise mostly just a move of code.
      ac9ffd60
    • J
      secret: Introduce virSecretObjDelete{Config|Data} · d467ac07
      John Ferlan 提交于
      Move and rename secretDeleteSaved from secret_driver into virsecretobj and
      split it up into two parts since there is error path code that looks to
      just delete the secret data file
      d467ac07
    • J
      secret: Move and rename secretLoadAllConfigs · 85ec94f8
      John Ferlan 提交于
      Move to secret_conf.c and rename to virSecretLoadAllConfigs. Also includes
      moving/renaming the supporting virSecretLoad, virSecretLoadValue, and
      virSecretLoadValidateUUID.
      85ec94f8
    • J
      secret: Use the hashed virSecretObjList · 993f9128
      John Ferlan 提交于
      This patch replaces most of the guts of secret_driver.c with recently
      added secret_conf.c APIs in order manage secret lists and objects
      using the hashed virSecretObjList* lookup API's.
      993f9128
    • J
      secret: Introduce virSecretObjListGetUUIDs · bb1fba62
      John Ferlan 提交于
      Add function to return counted listed of uuids to from the hashed secrets
      object list. This will replace the guts of secretConnectListSecrets.
      bb1fba62
    • J
      secret: Introduce virSecretObjListExport · d12c6721
      John Ferlan 提交于
      Add function to return a "match" filtered list of secret objects. This
      function replaces the guts of secretConnectListAllSecrets.
      
      Need to also move and make global virSecretUsageIDForDef since it'll
      be used by both secret_driver.c and secret_conf.c
      d12c6721
    • J
      secret: Introduce virSecretObjListNumOfSecrets · 5249d076
      John Ferlan 提交于
      Add function to count the hashed secret obj list with filters. This
      will replace the guts of secret_driver's secretConnectNumOfSecrets.
      5249d076
    • J
      secret: Introduce virSecretObjListAdd* and virSecretObjListRemove · d4287b98
      John Ferlan 提交于
      Add the functions to add/remove elements from the hashed secret obj list.
      These will replace secret_driver functions secretAssignDef and secretObjRemove.
      
      The virSecretObjListAddLocked will perform the necessary lookups and
      decide whether to replace an existing hash entry or create a new one.
      This includes setting up the configPath and base64Path as well as being
      able to support the caller's need to restore from a previous definition
      in case something goes wrong in the caller.
      d4287b98
    • J
      secret: Introduce virSecretUsageIDForDef · 615c8cce
      John Ferlan 提交于
      Move the driver specific secretUsageIDForDef into secret_conf.c. It could
      be more of a general purpose API.
      615c8cce
    • J
      secret: Introduce virSecretObjListFindBy{UUID|Usage} support · 00a3f0d0
      John Ferlan 提交于
      New API's including unlocked and Locked versions in order to be able
      to use in either manner.
      
      Support for searching hash object lists instead of linked lists will
      replace existing secret_driver functions secretFindByUUID and
      secretFindByUsage
      00a3f0d0
    • J
      secret: Create virsecretobj.c and virsecretconf.h · 4652b158
      John Ferlan 提交于
      Move virSecretObj from secret_driver.c to virsecretobj.h
      
      To support being able to create a hashed secrets list, move the
      virSecretObj to virsecretobj.h so that the code can at least find
      the definition.
      
      This should be a temporary situation while the virsecretobj.c code
      is patched in order to support a hashed secret object while still
      having the linked list support in secret_driver.c. Eventually, the
      goal is to move the virSecretObj into virsecretobj.c, although it
      is notable that the existing model from which virSecretObj was
      derived has virDomainObj in src/conf/domain_conf.h and virNetworkObj
      in src/conf/network_conf.h, so virSecretObj wouldn't be unique if
      it were to remain in virsecretobj.h  Still adding accessors to fetch
      and store hashed object data will be the end goal.
      
      Add definitions and infrastucture in virsecretobj.c to create and
      handle a hashed virSecretObj and virSecretObjList including the class,
      object, lock setup, and disposal API's. Nothing will call these yet.
      
      This infrastructure will replace the forward linked list logic
      within the secret_driver, eventually.
      4652b158
    • M
      wireshark: Fix distcheck · dc3002b4
      Michal Privoznik 提交于
      Our distcheck is broken. Well, it works but only by pure chance.
      When wireshark plugin is enabled, we try to query which path
      should the plugin be installed into. Firstly, we try to ask
      pkg-config as some releases of wireshark already sets
      corresponding variable in their pkg-config files. However, if we
      obtained no value from there we try to construct the path on our
      own. Based on our observations it usually is:
      $libdir/wireshark/plugins/$version/.
      Now, the problem is in the way we are deciding whether we have
      obtained the plugin directory from pkg-config or not. Simply
      said, we are checking wrong variable. The variable we are
      checking has never been set, thus in our test is empty and
      therefore we will always construct the plugin dir path on our
      own, regardless of its presence in the pkg-config file.
      To make things worse, after fixing this problem, VPATH build was
      broken as it now tried to install plugin into correct directory.
      Yes, this is problem, because --prefix was not honoured and
      everything but the plugin was installed into given prefix. I've
      managed to resolve this issue by replacing plugin dir prefix with
      our own. So when doing regular installation (our prefix ==
      wireshark prefix), nothing changes. When doing VPATH build &
      installation plugin is installed into correctly prefixed dir.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      dc3002b4
    • M
      tools: Introduce install-nss targets · 90bf5f5c
      Michal Privoznik 提交于
      We do have something similar for installing init system files.
      Basically I'm trying to avoid the following warning produced by
      automake:
      
      tools/Makefile.am:429: warning: uninstall-local was already defined in condition TRUE, which includes condition WITH_BSD_NSS ...
      tools/Makefile.am:292: ... 'uninstall-local' previously defined here
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      90bf5f5c
    • M
      Makefile: Enable distuninstallcheck again · a977cbb4
      Michal Privoznik 提交于
      This target has been disabled historically for whatever reason.
      Now that we do uninstall properly enable the test again.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      a977cbb4
    • M
      qemuProcessCreatePretendCmd: Rework FIPS handling · 927d047e
      Michal Privoznik 提交于
      This function - in contrast with qemuBuildCommandLine - merely
      constructs our internal command representation of a domain. This
      is then later compared against expected output. Or, this function
      is used also in virConnectDomainXMLToNative(). But due to a copy
      paste error this function, just like its image - has @forceFips
      argument that if enabled forces FIPS, otherwise mimics FIPS state
      in the host. If FIPS is enabled or forced the generated command
      line is different to state in which FIPS is disabled. Problem is,
      while this could be desired in the virConnectDomainXMLToNative()
      case, this is undesirable in the test suite as it will produce
      unpredicted results.
      Solution to this is to rename argument to @enableFips to
      specifically tell whether we expect command line to be build in
      either of fashions and make virConnectDomainXMLToNative()
      implementation fetch FIPS state and pass it to
      qemuProcessCreatePretendCmd().
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      927d047e
  2. 25 4月, 2016 19 次提交
  3. 24 4月, 2016 3 次提交
    • C
      tests: consistently source test-lib.sh in scripts · 856e84a5
      Cole Robinson 提交于
      This unifies the test scripts to all use the similar pattern added for
      schematests in ace4aecd. This gives the following
      
      - Enables running all tests from outside of tests/ dir
      - Drops redundant abs_* definitions, which are set by test-lib.sh
      - Drops unnecessary srcdir variable which was only used for sourcing
          test-lib.sh
      
      Behavior changes:
      
      - srcdir can no longer be overwritten, but I don't know why anyone would
          really need to...
      - Script VERBOSE setting no longer prints commands executed by test-lib.sh.
          if anyone cares I suggest handling this in test-lib.sh which already
          has other verbose style handling
      856e84a5
    • C
      vbox: VIR_WARN if we don't support the API version · 18644491
      Cole Robinson 提交于
      We presently don't give any indication if the VirtualBox version
      isn't in our support whitelist.
      18644491
    • C
      tests: remove 'reconnect' and 'statstest' · fa90464f
      Cole Robinson 提交于
      These old tests expect to run against a real xen connection via
      xend running on the host. Our intentions for the test suite are
      that it doesn't require interacting with any specific host resources,
      so these don't really belong here.
      fa90464f
  4. 23 4月, 2016 1 次提交