And at the same time, do that from .c rather than .h file.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: Chen Hanxiao<chenhanxiao@gmail.com>
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>

The setuid-rpc-client.la is intended to be small and contain only
bare minimum of source files. virarptable.c is not one of them.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: Chen Hanxiao<chenhanxiao@gmail.com>
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>

As of 2499d1a0 we don't link against libpolkit anymore, so
we only need the polkit package to be available during build.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>

Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>

We can use:
  domifaddr f26-cloud --source arp
to get the address.
Acked-by: NMichal Privoznik <mprivozn@redhat.com>
Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>

introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the message of netlink RTM_GETNEIGH
Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

introduce helper to parse RTM_GETNEIGH query message and
store it in struct virArpTable.
Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

use RTM_GETNEIGH to query arp table entry by netlink socket
Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>

Libvirt provides full path to the backing file since commit
fec8f9c4. This made qemu create the backend object but did not
delete it. This was fixed for unplug case in 4d83a672 but not in case
of failure to hotplug the frontend. We'd leave the files behind which
would make memory unusable in case of hugepages.

https://bugzilla.redhat.com/show_bug.cgi?id=1553085Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Having to repeat "./job[1]/" XPath prefix for every single element or
attribute we want to parse is suboptimal. And even more so once we
further extract code from qemuDomainObjPrivateXMLParseJob into separate
functions.
Signed-off-by: NJiri Denemark <jdenemar@redhat.com>

Commit dc567cc2 introduced qemuDomainObjPrivateXMLParseJob, but forgot
to move "./job[1]/@type" parsing into it.
Signed-off-by: NJiri Denemark <jdenemar@redhat.com>

The daemonStreamHandleWriteData() function is called whenever
server side of stream is able to receive some data. Nevertheless,
it calls virStreamSend() (to pass data down to virFDStream) and
depending on its return value it may abort the stream. However,
the functions it called when doing so are public APIs and as such
reset any error set previously. Therefore, if there was any error
in writing data to stream (i.e. repored in virStreamSend) it is
reset before virNetServerProgramSendReplyError() can get to it.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>

Some fields reported by dmidecode have plenty of useless spaces
(in fact some have nothing but spaces). To deal with this we have
introduced virSkipSpacesBackwards() and use it in
virSysinfoParseX86Processor() and virSysinfoParseX86Memory().
However, other functions (e.g. virSysinfoParseX86Chassis()) don't
use it at all and thus we are reporting nonsense:

  <sysinfo type='smbios'>
    <chassis>
      <entry name='manufacturer'>FUJITSU</entry>
      <entry name='version'>                      </entry>
      <entry name='serial'>                </entry>
      <entry name='asset'>                                        </entry>
      <entry name='sku'>Default string</entry>
    </chassis>
  </sysinfo>
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Commit 596fc3e3 introduced the ability to detect xenstore
using pkg-config for systems with Xen 4.9, but accidentally broke
detection for all other systems. Fix the logic so that it works
in all cases.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>

We read from the agent until seeing a \r\n pair to indicate a completed
reply or event. To avoid memory denial-of-service though, we must have a
size limit on amount of data we buffer. 10 MB is large enough that it
ought to cope with normal agent replies, and small enough that we're not
consuming unreasonable mem.

This is identical to the flaw we had reading from the QEMU monitor
as CVE-2018-5748, so rather embarrassing that we forgot to fix
the agent code at the same time.
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>

All we need is D-Bus.
Signed-off-by: NJán Tomko <jtomko@redhat.com>

There is just one polkit now.
Signed-off-by: NJán Tomko <jtomko@redhat.com>

This essentially reverts commit <e1019e9e>, which added
an extra step for generating the policy file.
Signed-off-by: NJán Tomko <jtomko@redhat.com>

Policy-Kit has been replaced by polkit (referred to, respectively,
as POLKIT0 and POLKIT1 in our Makefiles).

The last build fix with old Policy-Kit was in May 2013:
commit <442eb2ba> and build with -Wunused-label was broken
since April 2016: commit <84371303>
Signed-off-by: NJán Tomko <jtomko@redhat.com>

Split out the parser and separate it from the private data part so that
it can be later reused in other parts of the code.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Since seclabels are formatted along with the source element and will
also make sense to be passed for the backing chain we should parse them
in the place where we parse the disk source. Same applies for
validation.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Rather than checking that the security label is legal when parsing it
move the code into a separate function.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Since we already parse the <backingStore> of a disk source, we should
also validate the configuration for the whole backing chain and not only
for the top level image.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Move out formatting of 'startuPolicy' which is a property of the disk
out of the <source> element. Extracting the code formating the content
and attributes will also allow reuse in other parts of the code.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Move it to a single location which also allows to get rid of the
temporrary variable.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

The wrapper functionality can be moved to the only user
virDomainDiskSourceFormatInternal. Also removes comment which does not
reflect the truth any more.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Call the formatter function only once.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Now that the function is using virXMLFormatElement we don't need to
conditionally format anything, since we'll format the element according
to the presence of content.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

This is the only Python script which we invoke directly, which
works pretty fine in general but becomes a problem if the user
has explicitly overridden Python binary detection at configure
time.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>

Since Xen 4.9 a pkgconfig file exists to gather info about building
against libxenstore.so. Use it if available.
Signed-off-by: NOlaf Hering <olaf@aepfle.de>

Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>

Commit 99e30acf added 'qemustatusxml2xmloutdata' to EXTRA_DIST but
the directory added in the commit is called 'qemustatusxml2xmldata'
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

We're freeing individual items in it but not the array itself.

==19200== 40 bytes in 1 blocks are definitely lost in loss record 847 of 1,059
==19200==    at 0x4C2D12F: realloc (vg_replace_malloc.c:785)
==19200==    by 0x52C5532: virReallocN (viralloc.c:245)
==19200==    by 0x52C5628: virExpandN (viralloc.c:294)
==19200==    by 0x52C58FC: virInsertElementsN (viralloc.c:436)
==19200==    by 0x542856B: virSecurityDACChownListAppend (security_dac.c:115)
==19200==    by 0x54286B4: virSecurityDACTransactionAppend (security_dac.c:167)
==19200==    by 0x542902F: virSecurityDACSetOwnershipInternal (security_dac.c:560)
==19200==    by 0x54295D6: virSecurityDACSetOwnership (security_dac.c:650)
==19200==    by 0x542AEE0: virSecurityDACSetInputLabel (security_dac.c:1472)
==19200==    by 0x542B61D: virSecurityDACSetAllLabel (security_dac.c:1693)
==19200==    by 0x542DD67: virSecurityManagerSetAllLabel (security_manager.c:869)
==19200==    by 0x54279C2: virSecurityStackSetAllLabel (security_stack.c:361)
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Probably due to copy-paste error we're storing asset tag into
def->sku which we even use in the next step to store SKU number
and thus the asset tag leaks.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Commit 1b280383 forgot to fix the arguments for this one caller.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

https://bugzilla.redhat.com/show_bug.cgi?id=1554876

This is missing in 6bc4a371 and therefore we are effectively
overwriting user provided aliases for <input/> devices.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Similarly to the formatter extract the parser code.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Modernize the code by using the clever formatter rather than checking
manually when to format the end of the element.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

Remove one level of nesting by returing early.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>

The code overwrote the internal job type and then fixed it back. Since
the job type is not accessed in the code this does not make much sense.
Use the temporary value instead.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>