1. 04 6月, 2015 14 次提交
    • P
      conf: Add new helpers to resolve virDomainModificationImpact to domain defs · 3d021381
      Peter Krempa 提交于
      virDomainLiveConfigHelperMethod that is used for this job now does
      modify the flags but still requires the callers to extract the correct
      definition objects.
      
      In addition coverity and other static analyzers are usually unhappy as
      they don't grasp the fact that @flags are upadted according to the
      correct def to be present.
      
      To work this issue around and simplify the calling chain let's add a new
      helper that will work only on drivers that always copy the persistent
      def to a transient at start of a vm. This will allow to drop a few
      arguments. The new function syntax will also fill two definition
      pointers rather than modifying the @flags parameter.
      3d021381
    • P
      libxl: Don't remove vcpu pin definition in libxlDomainCleanup · 8db0f438
      Peter Krempa 提交于
      The vCPU pinning definition gets removed when the domain definition is
      being freed later. If there is no next configuration it would remove the
      configured pinning.
      8db0f438
    • P
      Revert "cputune: Support cputune for xend driver" · 5ce28b6d
      Peter Krempa 提交于
      This reverts commit 01692bb1.
      
      Quoting the original commit message:
      
      "Not sure if it's the correct way to add cputune xml for xend driver..."
      
      It is not. The defition created that is converted from the internal xend
      structures would also be leaked since it isn't used any more.
      
      Revert the commit since it does not make sense to keep the info
      internally.
      5ce28b6d
    • P
      qemu: libxl: vcpupin: Don't reset pinning when pinning to all pcpus · a02a161b
      Peter Krempa 提交于
      In the pre-NUMA ages pinning a vCPU to all pCPUs was eaqual to deleting
      the pinning info. Now it does not entirely work that way. Pinning a vCPU
      to all pCPUs might be a desired operation. Additionally removal of the
      pinning will result into using the default pinning information at the
      next boot which might be different from all vcpus.
      
      This patch removes the false assumption that we should remove the
      pinning after pinning to all vCPUs and tweaks the documentation for
      virsh.
      
      A later patch will implement a new flag for the virDomainPinVcpuFlags
      API that will allow to remove the pinning in a sane way.
      a02a161b
    • P
      lib: virDomainPinIOThread: Remove spurious overflow check · efaa7197
      Peter Krempa 提交于
      Internal structures use unsigned int, so there's no need for this legacy
      check that was copied from the vCPU pinning api.
      efaa7197
    • P
      conf: Store cpu count as unsigned int · fbbea798
      Peter Krempa 提交于
      While we probably won't see machines with more than 65536 cpus for a
      while lets store the cpu count as an integer so that we can avoid quite
      a lot of overflow checks in our code.
      fbbea798
    • P
      qemu: Refactor qemuDomainGetInfo · d3889db0
      Peter Krempa 提交于
      Since the returned structure uses "unsigned long" for memory sizes add a
      few overflow checks to notify the user in case we are not able to
      represent given values.
      d3889db0
    • P
      qemu: Add helper to update domain balloon size and refactor usage places · eaf43208
      Peter Krempa 提交于
      When qemu does not support the balloon event the current memory size
      needs to be queried. Since there are two places that implement the same
      logic, split it out into a function and reuse.
      eaf43208
    • P
      qemu: process: Update current balloon state to maximum on vm startup · 641a145d
      Peter Krempa 提交于
      After libvirt issues the balloon resize command, the current balloon
      size needs to be changed to the maximum memory size since the vCPUs were
      not started and thus the balloon driver could not return the memory.
      
      Since GetXMLDesc and other APIs return the balloon size without updating
      it in case they are not able to obtain the job and the memory balloon
      does not support the asynchronous event the sizing might be incorrect.
      641a145d
    • J
      Always add 'console' matching the 'serial' device · 8728a78e
      Ján Tomko 提交于
      We have been formatting the first serial device also
      as a console device, but only if there were no other consoles.
      
      If there is a <serial> device present in the XML, but no serial
      <console>, or if there isn't any <console> at all but the domain
      definition hasn't gone through a parse->format->parse round-trip,
      the <console> device would not be formatted.
      
      Change the code to always add the stub device for the first
      serial device.
      
      Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1089914
      8728a78e
    • J
      maint: remove incorrect apostrophes from 'its' · 12b949df
      Ján Tomko 提交于
      12b949df
    • J
      docs: php: remove reference to Red Hat · 22cdbec0
      Ján Tomko 提交于
      Also remove the redudant apostrophe from "it's".
      22cdbec0
    • S
      check if console/channel PTY is null before attempting to open · eac9445e
      Shivaprasad G Bhat 提交于
      Console/channel devices have their pty devices assigned when the emulator is
      actually started. If time is spent in guest preparation, someone attempts
      to open the console/channel, the libvirt crashes in virChrdevLockFilePath().
      The patch attempts to fix the crash by adding a check before attempting to
      open.
      Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
      eac9445e
    • L
      virnetdev: fix moving of 802.11 phys · 81b19ce4
      Lubomir Rintel 提交于
      There was a couple of problems with the style fixes applied to the original
      patch:
      
      1.) virFileReadAllQuiet comparison was incorrectly parenthesized when moved
      into a condition, causing the len to be set to the result of comparison. This,
      together with the removed underflow check would underflow the phy buffer.
      
      2.) The logic was broken. Failure to call "ip" would abort the function, thus
      the "iw" branch would never be reached.
      
      This aims to fix the issues and work around possible style complains :)
      Signed-off-by: NLubomir Rintel <lkundrak@v3.sk>
      81b19ce4
  2. 03 6月, 2015 26 次提交