1. 23 11月, 2010 22 次提交
    • D
      Stop iSCSI targets automatically logging back in after logout · 3c12b654
      Daniel P. Berrange 提交于
      The Linux iSCSI initiator toolchain has the dubious feature that
      if you ever run the 'sendtargets' command to merely query what
      targets are available from a server, the results will be recorded
      in /var/lib/iscsi. Any time the '/etc/init.d/iscsi' script runs
      in the future, it will then automatically login to all those
      targets. /etc/init.d/iscsi is automatically run whenever a NIC
      comes online.
      
      So from the moment you ask a server what targets are available,
      your client will forever more automatically try to login to all
      targets without ever asking if you actually want it todo this.
      
      To stop this stupid behaviour, we need to run
      
        iscsiadm --portal $PORTAL --target $TARGET
         --op update --name node.startup --value manual
      
      For every target on the server.
      
      * src/storage/storage_backend_iscsi.c: Disable automatic login
        for targets found as a result of a 'sendtargets' command
      3c12b654
    • D
      Refactor iSCSI driver code to facilitate future changes · 59446096
      Daniel P. Berrange 提交于
      The following series of patches are adding significant
      extra functionality to the iSCSI driver. THe current
      internal helper methods are not sufficiently flexible
      to cope with these changes. This patch refactors the
      code to avoid needing to have a virStoragePoolObjPtr
      instance as a parameter, instead passing individual
      target, portal and initiatoriqn parameters.
      
      It also removes hardcoding of port 3260 in the portal
      address, instead using the XML value if any.
      
      * src/storage/storage_backend_iscsi.c: Refactor internal
        helper methods
      59446096
    • D
      Fix parsing of port attribute in storage XML configuration · b6e5a0a2
      Daniel P. Berrange 提交于
      The XML docs describe a 'port' attribute for the
      storage source <host> element, but the parser never
      handled it.
      
      * docs/schemas/storagepool.rng: Define port attribute
      * src/conf/storage_conf.c: Add missing parsing/formatting
        of host port number
      * src/conf/storage_conf.h: Remove bogus/unused 'protocol' field
      b6e5a0a2
    • D
      Don't catch SIGCHLD in libvirtd · 375ba36e
      Daniel P. Berrange 提交于
      libvirtd no longer deals with SIGCHLD in its signal handler
      since the QEMU driver switched to always daemonize processes.
      Thus remove the sigaction for it, to avoid warning log
      messages
      
      * daemon/libvirtd.c: Don't catch SIGCHLD
      375ba36e
    • D
      Ensure logfile isn't truncated by shutdown message. · 7f9cebc0
      Daniel P. Berrange 提交于
      When running non-root, the QEMU log file is usually opened with
      truncation, since there is no logrotate for non-root usage.
      This means that when libvirt logs the shutdown timestamp, the
      log is accidentally truncated
      
      * src/qemu/qemu_driver.c: Never truncate log file with shutdown
        message
      7f9cebc0
    • D
      Remove trailing ':' from timestamp · dbf405bf
      Daniel P. Berrange 提交于
      The QEMU logger appends a ':' to the timestamp when it deems
      it neccessary, so the virTimestamp API should not duplicate
      this
      
      * src/util/util.c: Remove trailing ':' from timestamp
      dbf405bf
    • D
      Log all errors at level INFO to stop polluting syslog · 04bd0360
      Daniel P. Berrange 提交于
      Everytime a public API returns an error, libvirtd pollutes
      syslog with that error message. Reduce the error logging
      level to INFO so these don't appear by default.
      
      * src/util/virterror.c: Log all errors at INFO
      04bd0360
    • D
      Ensure virExec preserves logging environment · 882f78c3
      Daniel P. Berrange 提交于
      The virFork call resets all logging handlers that may have been
      set. Re-enable them after fork in virExec, so that env variables
      fir LIBVIRT_LOG_OUTPUTS and LIBVIRT_LOG_FILTERS take effect
      until the execve()
      
      * src/util/util.c: Preserve logging in child in virExec
      882f78c3
    • D
      Include a thread identifier in log messages · 9288c31b
      Daniel P. Berrange 提交于
      To allow messages from different threads to be untangled,
      include an integer thread identifier in log messages.
      
      * src/util/logging.c: Include thread ID
      * src/util/threads.h, src/util/threads.h, src/util/threads-pthread.c:
        Add new virThreadSelfID() function
      * configure.ac: Check for sys/syscall.h
      9288c31b
    • C
      qemu: setvcpus: Save config changes to disk · 388fa625
      Cole Robinson 提交于
      Currently changes to the persistent config aren't flushed to disk, meaning
      they are lost if the domain is redefined or libvirtd is restarted.
      388fa625
    • C
      qemu: setvcpus: Simplify altering the persistent config · 39b62654
      Cole Robinson 提交于
      Do this by adding a helper function to get the persistent domain config. This
      should be useful for other functions that may eventually want to alter
      the persistent domain config (attach/detach device). Also make similar changes
      to the test drivers setvcpus command.
      
      A caveat is that the function will return the running config for a transient
      domain, rather than error. This simplifies callers, as long as they use
      other methods to ensure the guest is persistent.
      39b62654
    • C
      qemu: setvcpus: Fix maxvcpus check · d7520291
      Cole Robinson 提交于
      Doing 'virsh setvcpus $vm --config 10' doesn't check the value against the
      domains maxvcpus value. A larger value for example will prevent the guest
      from starting.
      
      Also make a similar change to the test driver.
      d7520291
    • C
      conf: domain: Improve vcpus validation reporting · 81e6f68d
      Cole Robinson 提交于
      81e6f68d
    • C
      Make state driver device hotplug/update actually transient · 45ec297d
      Cole Robinson 提交于
      The current semantics of non-persistent hotplug/update are confusing: the
      changes will persist as long as the in memory domain definition isn't
      overwritten. This means hotplug changes stay around until the domain is
      redefined or libvirtd is restarted.
      
      Call virDomainObjSetDefTransient at VM startup, so that we properly discard
      hotplug changes when the VM is shutdown.
      45ec297d
    • C
      domain_conf: Add virDomainObjSetDefTransient · 08a72a7d
      Cole Robinson 提交于
      This function sets the running domain definition as transient, by reparsing
      the persistent config and assigning it to newDef. This ensures that any
      changes made to the running definition and not the persistent config are
      discarded when the VM is shutdown.
      08a72a7d
    • C
      xend: Escape reserved sexpr characters · 3afe5d40
      Cole Robinson 提交于
      If we don't escape ' or \ xend can't parse the generated sexpr. This
      might over apply the EscapeSexpr routine, but it shouldn't hurt.
      3afe5d40
    • C
      buf: Simplify virBufferEscapeString · 0af02cb2
      Cole Robinson 提交于
      We are about to copy this function, so clean it up before we do.
      0af02cb2
    • C
      xend: urlencode: Properly escape '&' · c8b2a23c
      Cole Robinson 提交于
      Since we send the sexpr to xend via HTTP, we need to properly escape
      '&'
      c8b2a23c
    • C
      conf: Fix parsing python style triple quotes · 21108d37
      Cole Robinson 提交于
      An incorrect check broke matching the closing set of quotes. Update
      tests to cover this case for XM config files.
      21108d37
    • C
      conf: Convert ParseString to use STRPREFIX · f57c0b23
      Cole Robinson 提交于
      f57c0b23
    • C
      schemas: domain: Add more valid file path chars · 4610a2d5
      Cole Robinson 提交于
      Also, standardize path usage on 'filePath' and 'absFilePath'
      4610a2d5
    • A
      qed: Minor updates to QED support patches · a76234f3
      Adam Litke 提交于
      This patch makes two corrections to the newly-added QED support patch series:
      
       - Correct the QED header field offsets
       - Remove XML parsing for VIR_STORAGE_FILE_AUTO_SAFE
      Signed-off-by: NAdam Litke <agl@us.ibm.com>
      a76234f3
  2. 22 11月, 2010 1 次提交
  3. 20 11月, 2010 5 次提交
  4. 19 11月, 2010 9 次提交
    • E
      maint: tighten strncmp syntax check · d2af8ffc
      Eric Blake 提交于
      Using 'int ret = strcmp(a, b)' in a qsort function is a valid use of
      str[n]cmp that should _not_ be turned to STREQ, but it was falling
      foul of our specific syntax-check.  Meanwhile, gnulib's maint.mk
      already has a tighter bound for strcmp, so we can copy that regex and
      just check for strncmp, which results in fewer false positives that
      require exceptions.
      
      * cfg.mk (sc_prohibit_strcmp_and_strncmp): Rename...
      (sc_prohibit_strncmp): ...to this, and tighten, to mirror
      maint.mk's sc_prohibit_strcmp's better regex.
      * Makefile.am (syntax_check_exceptions): Update exception rule.
      * .x-sc_prohibit_strcmp_and_strncmp: Rename...
      * .x-sc_prohibit_strncmp: ...and trim.
      d2af8ffc
    • D
    • E
      capabilities, cpu: use new array API · aca20efb
      Eric Blake 提交于
      * src/conf/capabilities.h (_virCaps, _virCapsHost, _virCapsGuest)
      (_virCapsGuestArch): Add additional fields.
      * src/conf/cpu_conf.h (_virCPUDef): Likewise.
      * src/conf/capabilities.c (virCapabilitiesFormatXML): Reflect
      updated type.
      (virCapabilitiesAddGuest, virCapabilitiesAddHostFeature)
      (virCapabilitiesAddHostMigrateTransport)
      (virCapabilitiesAddHostNUMACell, virCapabilitiesAddGuestFeature)
      (virCapabilitiesAddGuestDomain): Use new array APIs.
      * src/conf/cpu_conf.c (virCPUDefAddFeature, virCPUDefCopy)
      (virCPUDefParseXML): Likewise.
      * tests/testutilsqemu.c (testQemuCapsInit): Adjust test.
      aca20efb
    • E
      daemon: use safer memory growth macros · e6b68d74
      Eric Blake 提交于
      * daemon/libvirtd.h (qemud_server): Change types of members
      tracking array sizes, and add allocation trackers.
      * daemon/event.c (virEventLoop): Likewise.
      (virEventAddHandleImpl, virEventAddTimeoutImpl)
      (virEventCleanupTimeouts, virEventCleanupHandles): Use
      VIR_RESIZE_N instead of VIR_REALLOC_N.  Tweak debug messages to
      match type changes.
      * daemon/libvirtd.c (qemudDispatchServer, qemudRunLoop): Likewise.
      e6b68d74
    • E
      memory: make it easier to avoid quadratic scaling of arrays · 269d3b72
      Eric Blake 提交于
      * src/util/memory.h (VIR_RESIZE_N): New macro.
      * src/util/memory.c (virResizeN): New function.
      * src/libvirt_private.syms: Export new helper.
      * docs/hacking.html.in: Document it.
      * HACKING: Regenerate.
      269d3b72
    • E
      memory: make it safer to expand arrays · 5a0beacc
      Eric Blake 提交于
      * src/util/memory.h (VIR_REALLOC_N): Update docs.
      (VIR_EXPAND_N, VIR_SHRINK_N): New macros.
      (virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some
      gcc attributes.
      * src/util/memory.c (virExpandN, virShrinkN): New functions.
      (virReallocN): Update docs.
      * src/libvirt_private.syms: Export new helpers.
      * docs/hacking.html.in: Prefer newer interfaces over
      VIR_REALLOC_N, since uninitialized memory can bite us.
      * HACKING: Regenerate.
      5a0beacc
    • O
      doc: Add doc for missed options of migrate · b503022e
      Osier Yang 提交于
      * tools/virsh.pod (add doc for options like "--p2p", "--direct",
      "--copy-storage-all", "dname", etc.)
      b503022e
    • O
      doc: add doc for missed parameters of attach-disk · 84146be4
      Osier Yang 提交于
      * tools/virsh.pod (add docs for --persistent and --sourcetype
      of attach-disk, break the long lines in the meantime)
      84146be4
    • D
      Fix a failure to restore SELinux label for character devices · 83fa1184
      Daniel Veillard 提交于
      The code in SELinuxRestoreSecurityChardevLabel() was trying to
      use SELinuxSetFilecon directly for devices or file types while
      it should really use SELinuxRestoreSecurityFileLabel encapsulating
      routine, which avoid various problems like resolving symlinks,
      making sure he file exists and work around NFS problems
      83fa1184
  5. 18 11月, 2010 3 次提交
    • M
      virt-aa-helper: Fix several compile errors · c505eafe
      Matthias Bolte 提交于
      Include locale.h for setlocale().
      
      Revert the usage string back to it's original form.
      
      Use puts() instead of fputs(), as fputs() expects a FILE*.
      
      Add closing parenthesis to some vah_error() calls.
      
      Use argv[0] instead of an undefined argv0.
      c505eafe
    • E
      build: fix autobuild failures on gcov upgrade · 38afe8f5
      Eric Blake 提交于
      Last time I ran ./autobuild.sh was on F13; and upgrading to F14
      exposed these leftovers due to a newer gcov than what was in the stale
      files, in the form of spurious messages that break 'make check':
      
      +profiling:/home/remote/eblake/libvirt-tmp/tools/virsh-console.gcda:Version mismatch - expected 405R got 404R
      
      and concluding with a bug in the autobuild.sh script itself:
      
      ./autobuild.sh: line 44: test: =: unary operator expected
      
      * autobuild.sh: avoid syntax error on failed test
      * tools/Makefile.am (CLEANFILES): Clean coverage files.
      38afe8f5
    • O
      doc: update virsh manual · ed0b7073
      Osier Yang 提交于
      * tools/virsh.pod (change things like "edit domain.xml" into
        "vi domain.xml", so that it's more clear for user)
      ed0b7073