1. 05 3月, 2018 11 次提交
  2. 02 3月, 2018 3 次提交
  3. 01 3月, 2018 7 次提交
  4. 28 2月, 2018 5 次提交
    • M
      vshCommandOpt: Do more checking if skipChecks is set · 846d3b58
      Michal Privoznik 提交于
      Currently if cmd->skipChecks is set (done only from completers)
      some basic checks are skipped because we're working over
      partially parsed command. See a26ff63a for more detailed
      explanation. Anyway, the referenced commit was too aggressive in
      disabling checks and effectively returned success even in clear
      case of failure. For instance:
      
        # domif-getlink --interface <TAB><TAB>
      
      causes virshDomainInterfaceCompleter() to be called, which calls
      virshDomainGetXML() which eventually calls
      vshCommandOptStringReq(.., name = "domain"); The --domain
      argument is required for the command and if not present -1 should
      be returned to tell the caller the argument was not found. Well,
      zero is returned meaning the argument was not found but it's not
      required either.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      846d3b58
    • N
    • J
      virsh: fixing segfault by pool autocompleter function. · 8fe09a53
      Julio Faracco 提交于
      The commands which requires a pool to perform any action for a volume is
      throwing a segfault when you pass the volume name before a pool name or
      without the argument '--pool'.
      
      An example that works:
      virsh # vol-list loops-pool
       Name                 Path
      -------------------------------------------------------------------
       loop0                /mnt/loop0
      
      virsh # vol-info --pool loops-pool lo<TAB>
      
      An example that does not work:
      virsh # vol-list loops-pool
       Name                 Path
      -------------------------------------------------------------------
       loop0                /mnt/loop0
      
      virsh # vol-info lo<TAB>
      Segmentation Fault
      
      The example 'vol-info' can be executed as 'vol-info loop0 --pool
      loops-pool'. So, this commit fixes this problem when the arguments are
      inverted and avoids the segfault.
      Signed-off-by: NJulio Faracco <jcfaracco@gmail.com>
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      8fe09a53
    • Z
      qemu: fix memory leak of @vporttype during migration. · f7399de1
      Zhangzijian 提交于
      12 bytes in 1 blocks are definitely lost in loss record 188 of 1,145
      at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      by 0x5D2CD77: xmlStrndup (in /lib/x86_64-linux-gnu/libxml2.so.2.7.8)
      by 0x514E137: virXMLPropString (virxml.c:506)
      by 0x234F51: qemuMigrationCookieNetworkXMLParse qemu_migration.c:1001)
      by 0x235FF8: qemuMigrationCookieXMLParse (qemu_migration.c:1333)
      by 0x236214: qemuMigrationCookieXMLParseStr (qemu_migration.c:1372)
      by 0x2365D2: qemuMigrationEatCookie (qemu_migration.c:1456)
      by 0x243DBA: qemuMigrationFinish (qemu_migration.c:6381)
      by 0x204032: qemuDomainMigrateFinish3 (qemu_driver.c:13228)
      by 0x521CCBB: virDomainMigrateFinish3 (libvirt-domain.c:4788)
      by 0x1936DE: remoteDispatchDomainMigrateFinish3 (remote.c:4580)
      by 0x16DBB1: remoteDispatchDomainMigrateFinish3Helper(remote_dispatch.h:7582)
      Signed-off-by: NZhangZijian <zhang.zijian@h3c.com>
      f7399de1
    • L
      nwfilter: save error from DHCP snoop thread to report in main thread · 1297db74
      Laine Stump 提交于
      A problem encountered due to a bug in libpcap was reported to the
      caller as:
      
         An error occurred, but the cause is unknown
      
      This was because the error had been logged in the DHCPSnoop
      thread. The worker thread handling the API call to start a domain
      spins up the DHCPSnoop thread which watches for dhcp packets with
      libpcap, then uses virCondSignal() to notify the worker thread (which
      has been waiting with virCondWait()). The worker thread knows that
      there was an error (because threadStatus != THREAD_STATUS_OK), but the
      error info had been stored in thread-specific storage for the other
      thread, so the worker thread can only report that there was a failure,
      but it doesn't know why.
      
      The solution is to save the error that was logged (with
      virErrorPreserveLast() into the object the is used to share info
      between the threads, then we can set the error in the worker thread
      using virErrorRestore().
      
      In the case of the error I was looking at, this changed the "unknown"
      message into:
      
          internal error: pcap_setfilter: can't remove kernel filter:
          Bad file descriptor
      Signed-off-by: NLaine Stump <laine@laine.org>
      1297db74
  5. 27 2月, 2018 3 次提交
  6. 26 2月, 2018 7 次提交
  7. 24 2月, 2018 1 次提交
    • J
      libxl: round memory values to next 1MiB increment · ef71caea
      Jim Fehlig 提交于
      libxl requires the memory sizes to be rounded to 1MiB increments.
      Attempting to start a domain that violates this requirement will
      fail with the marginally helpful error
      
      2018-02-22 01:55:32.921+0000: xc: panic: xc_dom_boot.c:141: xc_dom_boot_mem_init: can't allocate low memory for domain: Out of memory
      2018-02-22 01:55:32.921+0000: libxl: libxl_dom.c:671:libxl__build_dom: xc_dom_boot_mem_init failed: No such file or directory
      
      Round the maximum and current memory values to the next 1MiB
      increment when generating the libxl_domain_config object.
      Signed-off-by: NJim Fehlig <jfehlig@suse.com>
      ef71caea
  8. 23 2月, 2018 3 次提交