1. 15 8月, 2014 38 次提交
  2. 14 8月, 2014 2 次提交
    • J
      Maximum vlanid should be 4095 in interface.rng · 2a8fabba
      Jianwei Hu 提交于
      The correct vlanid range is 0~4095.
      
      After merging this patch, we can not validate a interface xml with vlanid >= 4096.
      [root@localhost ~]# cat vlan.xml
      <interface type='vlan' name='eno1.4096'>
         <start mode='onboot'/>
         <protocol family='ipv4'>
          <dhcp/>
         </protocol>
         <vlan tag='4096'>
           <interface name='eno1'/>
         </vlan>
      </interface>
      [root@localhost ~]# virt-xml-validate vlan.xml
      vlan.xml:1: element interface: Relax-NG validity error : Invalid sequence in interleave
      vlan.xml:6: element vlan: Relax-NG validity error : Element interface failed to validate content
      vlan.xml:6: element vlan: Relax-NG validity error : Element vlan failed to validate attributes
      vlan.xml fails to validate
      [root@localhost ~]#
      
      Here is a ip command help on this.
      [root@localhost /]# ip link add link eno1 name eno1.90 type vlan help
      Usage: ... vlan [ protocol VLANPROTO ] id VLANID                [ FLAG-LIST ]
                      [ ingress-qos-map QOS-MAP ] [ egress-qos-map QOS-MAP ]
      
      VLANPROTO: [ 802.1Q / 802.1ad ]
      VLANID := 0-4095
      FLAG-LIST := [ FLAG-LIST ] FLAG
      FLAG := [ reorder_hdr { on | off } ] [ gvrp { on | off } ] [ mvrp { on | off } ]
              [ loose_binding { on | off } ]
      QOS-MAP := [ QOS-MAP ] QOS-MAPPING
      QOS-MAPPING := FROM:TO
      2a8fabba
    • R
      LXC: Fix virLXCControllerSetupDevPTS() wrt user namespaces · 41885a02
      Richard Weinberger 提交于
      The gid value passed to devpts has to be translated by hand as
      virLXCControllerSetupDevPTS() is called before setting up the user
      and group mappings.
      Otherwise devpts will use an unmapped gid and openpty()
      will fail within containers.
      Linux kernel commit 23adbe12
      ("fs,userns: Change inode_capable to capable_wrt_inode_uidgid")
      uncovered that issue.
      Signed-off-by: NRichard Weinberger <richard@nod.at>
      Signed-off-by: NJán Tomko <jtomko@redhat.com>
      41885a02