1. 24 11月, 2010 5 次提交
    • O
      define internal driver API · 37a02efd
      Osier Yang 提交于
      * src/driver.h (new typedef, new callback member for "_virDriver")
      * src/esx/esx_driver.c
      * src/lxc/lxc_driver.c
      * src/opennebula/one_driver.c
      * src/openvz/openvz_driver.c
      * src/phyp/phyp_driver.c
      * src/qemu/qemu_driver.c
      * src/remote/remote_driver.c
      * src/test/test_driver.c
      * src/uml/uml_driver.c
      * src/vbox/vbox_tmpl.c
      * src/xen/xen_driver.c
      * src/xenapi/xenapi_driver.c
      37a02efd
    • O
      virDomainIsUpdated: define the new public API · 347d73f2
      Osier Yang 提交于
      introduce new public API "virDomainIsUpdated"
      
      * src/conf/domain_conf.h (new member "updated" for "virDomainObj")
      * src/libvirt_public.syms
      * include/libvirt/libvirt.h.in
      347d73f2
    • E
      maint: sort exports · 2ed149a6
      Eric Blake 提交于
      * src/libvirt_private.syms (buf.h): Sort.
      2ed149a6
    • M
      remote: Fix TLS transport on Windows · 9abe1e43
      Matthias Bolte 提交于
      gnulib wraps Windows' SOCKET handle based send() and recv() functions
      into file descriptor based ones that are used in libvirt.
      
      Even though GnuTLS is using gnulib too, it explicitly doesn't use
      gnulib's replacement functions on Windows. By default GnuTLS uses the
      SOCKET handle based send() and recv(). This makes gnutls_handshake()
      fail internally with a WSAENOTSOCK error because libvirt passes a
      file descriptor; GnuTLS needs the SOCKET handle.
      
      To avoid this mismatch make sure that GnuTLS uses gnulib's replacment
      functions, by setting custom pull() and push() functions for GnuTLS.
      9abe1e43
    • C
      tests: Fix dispatching internal error reports · b2399b06
      Cole Robinson 提交于
      Without this fix, the test suite doesn't print error messages when a libvirt
      function fails. Additionally, only print error reports if DEBUG or VERBOSE
      requested.
      b2399b06
  2. 23 11月, 2010 33 次提交
    • E
      libvirtd: fix bug when shrinking number of clients · 149c4921
      Eric Blake 提交于
      * daemon/libvirtd.c (qemudRunLoop): Pass allocation size, not
      current count, to VIR_SHRINK_N.
      * docs/hacking.html.in: Update doc example.
      * HACKING: Regenerate.
      149c4921
    • D
      Rename 'remove' param to 'toremove' to avoid clash with stdio.h · c73bd6f3
      Daniel P. Berrange 提交于
      The stdio.h header has a function called 'remove' declared. This
      clashes with the 'remove' parameter in virShrinkN
      
      * src/util/memory.c: Rename 'remove' to 'toremove'
      c73bd6f3
    • D
      Fix 32-bit int truncation in QED header check · f86c7801
      Daniel P. Berrange 提交于
      * src/util/memory.c: Avoid 32-bit truncation extracting a 64bit int
      f86c7801
    • D
      Fix error handling in virsh when listing storage volumes · 227ed266
      Daniel P. Berrange 提交于
      virsh was not checking for a error code when listing storage
      volumes. So when listing volumes in a pool that was shutoff,
      no output was displayed
      
      * tools/virsh.c: Fix error handling when listing volumes
      227ed266
    • D
      Improve SCSI volume name generation · 174d737d
      Daniel P. Berrange 提交于
      The SCSI volumes currently get a name like '17:0:0:1' based
      on $host:$bus:$target:$lun. The names are intended to be unique
      per pool and stable across pool restarts. The inclusion of the
      $host component breaks this, because the $host number for iSCSI
      pools is dynamically allocated by the kernel at time of login.
      This changes the name to be 'unit:0:0:1', ie removes the leading
      host component. The 'unit:' prefix is just to ensure the volume
      name doesn't start with a number and make it clearer when seen
      out of context.
      
      * src/storage/storage_backend_scsi.c: Improve volume name
        field value stability and uniqueness
      174d737d
    • D
      Fix error codes returned when a storage pool is inactive · e4c97a10
      Daniel P. Berrange 提交于
      Many operations are not valid on inactive storage pools. The
      storage driver is currently returning VIR_ERR_INTERNAL_ERROR
      in these cases, rather than the more suitable error code
      VIR_ERR_OPERATION_INVALID
      
      * src/storage/storage_driver.c: Fix error code when pool
        is not active
      e4c97a10
    • D
      Check whether pools are already active upon libvirtd startup · 1b7e0b1a
      Daniel P. Berrange 提交于
      When libvirt starts up all storage pools default to the inactive
      state, even if the underlying storage is already active on the
      host. This introduces a new API into the internal storage backend
      drivers that checks whether a storage pool is already active. If
      the pool is active at libvirtd startup, the volume list will be
      immediately populated.
      
      * src/storage/storage_backend.h: New internal API for checking
        storage pool state
      * src/storage/storage_driver.c: Check whether a pool is active
        upon driver startup
      * src/storage/storage_backend_fs.c, src/storage/storage_backend_iscsi.c,
        src/storage/storage_backend_logical.c, src/storage/storage_backend_mpath.c,
        src/storage/storage_backend_scsi.c: Add checks for pool state
      1b7e0b1a
    • D
      Remove bogus port handling code in virsh · 4d0350fc
      Daniel P. Berrange 提交于
      The "find-storage-pool-sources-as" command takes two arguments,
      a hostname and a port number. For some reason the code would
      also then look for a port number appended to the hostname
      string by searching for ':'. This totally breaks if the user
      gives an IPv6 address, and is redundant, since you can already
      provide a port as a separate argument
      
      * tools/virsh.c: Remove bogus port number handling code
      4d0350fc
    • D
      Allow iSCSI IQN to be set with find-storage-pool-sources-as command · 9a7caeff
      Daniel P. Berrange 提交于
      Allow an iSCSI initiator IQN to be set with the XML for the
      find-storage-pool-sources-as virsh command
      
      * tools/virsh.c: Add iSCSI IQN support
      9a7caeff
    • D
      Switch the virsh XML generation to use virBuffer instead of virAsprintf · 1bae28e4
      Daniel P. Berrange 提交于
      The code generating XML for storage pool source discovery is
      hardcoded to only allow a hostname and optional port number.
      Refactor this code to make it easier to add support for extra
      parameters.
      
      * tools/virsh.c: Refactor XML generator
      1bae28e4
    • D
      Add support for iSCSI target auto-discovery · 1da8c567
      Daniel P. Berrange 提交于
      Since the previous patch added support for parsing the output of
      the 'sendtargets' command, it is now trivial to support the
      storage pool discovery API.
      
      Given a hostname and optional portnumber and initiator IQN,
      the code can return a full list of storage pool source docs,
      each one representing a iSCSI target.
      
      * src/storage/storage_backend_iscsi.c: Wire up target
        auto-discovery
      1da8c567
    • D
      Stop iSCSI targets automatically logging back in after logout · 3c12b654
      Daniel P. Berrange 提交于
      The Linux iSCSI initiator toolchain has the dubious feature that
      if you ever run the 'sendtargets' command to merely query what
      targets are available from a server, the results will be recorded
      in /var/lib/iscsi. Any time the '/etc/init.d/iscsi' script runs
      in the future, it will then automatically login to all those
      targets. /etc/init.d/iscsi is automatically run whenever a NIC
      comes online.
      
      So from the moment you ask a server what targets are available,
      your client will forever more automatically try to login to all
      targets without ever asking if you actually want it todo this.
      
      To stop this stupid behaviour, we need to run
      
        iscsiadm --portal $PORTAL --target $TARGET
         --op update --name node.startup --value manual
      
      For every target on the server.
      
      * src/storage/storage_backend_iscsi.c: Disable automatic login
        for targets found as a result of a 'sendtargets' command
      3c12b654
    • D
      Refactor iSCSI driver code to facilitate future changes · 59446096
      Daniel P. Berrange 提交于
      The following series of patches are adding significant
      extra functionality to the iSCSI driver. THe current
      internal helper methods are not sufficiently flexible
      to cope with these changes. This patch refactors the
      code to avoid needing to have a virStoragePoolObjPtr
      instance as a parameter, instead passing individual
      target, portal and initiatoriqn parameters.
      
      It also removes hardcoding of port 3260 in the portal
      address, instead using the XML value if any.
      
      * src/storage/storage_backend_iscsi.c: Refactor internal
        helper methods
      59446096
    • D
      Fix parsing of port attribute in storage XML configuration · b6e5a0a2
      Daniel P. Berrange 提交于
      The XML docs describe a 'port' attribute for the
      storage source <host> element, but the parser never
      handled it.
      
      * docs/schemas/storagepool.rng: Define port attribute
      * src/conf/storage_conf.c: Add missing parsing/formatting
        of host port number
      * src/conf/storage_conf.h: Remove bogus/unused 'protocol' field
      b6e5a0a2
    • D
      Don't catch SIGCHLD in libvirtd · 375ba36e
      Daniel P. Berrange 提交于
      libvirtd no longer deals with SIGCHLD in its signal handler
      since the QEMU driver switched to always daemonize processes.
      Thus remove the sigaction for it, to avoid warning log
      messages
      
      * daemon/libvirtd.c: Don't catch SIGCHLD
      375ba36e
    • D
      Ensure logfile isn't truncated by shutdown message. · 7f9cebc0
      Daniel P. Berrange 提交于
      When running non-root, the QEMU log file is usually opened with
      truncation, since there is no logrotate for non-root usage.
      This means that when libvirt logs the shutdown timestamp, the
      log is accidentally truncated
      
      * src/qemu/qemu_driver.c: Never truncate log file with shutdown
        message
      7f9cebc0
    • D
      Remove trailing ':' from timestamp · dbf405bf
      Daniel P. Berrange 提交于
      The QEMU logger appends a ':' to the timestamp when it deems
      it neccessary, so the virTimestamp API should not duplicate
      this
      
      * src/util/util.c: Remove trailing ':' from timestamp
      dbf405bf
    • D
      Log all errors at level INFO to stop polluting syslog · 04bd0360
      Daniel P. Berrange 提交于
      Everytime a public API returns an error, libvirtd pollutes
      syslog with that error message. Reduce the error logging
      level to INFO so these don't appear by default.
      
      * src/util/virterror.c: Log all errors at INFO
      04bd0360
    • D
      Ensure virExec preserves logging environment · 882f78c3
      Daniel P. Berrange 提交于
      The virFork call resets all logging handlers that may have been
      set. Re-enable them after fork in virExec, so that env variables
      fir LIBVIRT_LOG_OUTPUTS and LIBVIRT_LOG_FILTERS take effect
      until the execve()
      
      * src/util/util.c: Preserve logging in child in virExec
      882f78c3
    • D
      Include a thread identifier in log messages · 9288c31b
      Daniel P. Berrange 提交于
      To allow messages from different threads to be untangled,
      include an integer thread identifier in log messages.
      
      * src/util/logging.c: Include thread ID
      * src/util/threads.h, src/util/threads.h, src/util/threads-pthread.c:
        Add new virThreadSelfID() function
      * configure.ac: Check for sys/syscall.h
      9288c31b
    • C
      qemu: setvcpus: Save config changes to disk · 388fa625
      Cole Robinson 提交于
      Currently changes to the persistent config aren't flushed to disk, meaning
      they are lost if the domain is redefined or libvirtd is restarted.
      388fa625
    • C
      qemu: setvcpus: Simplify altering the persistent config · 39b62654
      Cole Robinson 提交于
      Do this by adding a helper function to get the persistent domain config. This
      should be useful for other functions that may eventually want to alter
      the persistent domain config (attach/detach device). Also make similar changes
      to the test drivers setvcpus command.
      
      A caveat is that the function will return the running config for a transient
      domain, rather than error. This simplifies callers, as long as they use
      other methods to ensure the guest is persistent.
      39b62654
    • C
      qemu: setvcpus: Fix maxvcpus check · d7520291
      Cole Robinson 提交于
      Doing 'virsh setvcpus $vm --config 10' doesn't check the value against the
      domains maxvcpus value. A larger value for example will prevent the guest
      from starting.
      
      Also make a similar change to the test driver.
      d7520291
    • C
      conf: domain: Improve vcpus validation reporting · 81e6f68d
      Cole Robinson 提交于
      81e6f68d
    • C
      Make state driver device hotplug/update actually transient · 45ec297d
      Cole Robinson 提交于
      The current semantics of non-persistent hotplug/update are confusing: the
      changes will persist as long as the in memory domain definition isn't
      overwritten. This means hotplug changes stay around until the domain is
      redefined or libvirtd is restarted.
      
      Call virDomainObjSetDefTransient at VM startup, so that we properly discard
      hotplug changes when the VM is shutdown.
      45ec297d
    • C
      domain_conf: Add virDomainObjSetDefTransient · 08a72a7d
      Cole Robinson 提交于
      This function sets the running domain definition as transient, by reparsing
      the persistent config and assigning it to newDef. This ensures that any
      changes made to the running definition and not the persistent config are
      discarded when the VM is shutdown.
      08a72a7d
    • C
      xend: Escape reserved sexpr characters · 3afe5d40
      Cole Robinson 提交于
      If we don't escape ' or \ xend can't parse the generated sexpr. This
      might over apply the EscapeSexpr routine, but it shouldn't hurt.
      3afe5d40
    • C
      buf: Simplify virBufferEscapeString · 0af02cb2
      Cole Robinson 提交于
      We are about to copy this function, so clean it up before we do.
      0af02cb2
    • C
      xend: urlencode: Properly escape '&' · c8b2a23c
      Cole Robinson 提交于
      Since we send the sexpr to xend via HTTP, we need to properly escape
      '&'
      c8b2a23c
    • C
      conf: Fix parsing python style triple quotes · 21108d37
      Cole Robinson 提交于
      An incorrect check broke matching the closing set of quotes. Update
      tests to cover this case for XM config files.
      21108d37
    • C
      conf: Convert ParseString to use STRPREFIX · f57c0b23
      Cole Robinson 提交于
      f57c0b23
    • C
      schemas: domain: Add more valid file path chars · 4610a2d5
      Cole Robinson 提交于
      Also, standardize path usage on 'filePath' and 'absFilePath'
      4610a2d5
    • A
      qed: Minor updates to QED support patches · a76234f3
      Adam Litke 提交于
      This patch makes two corrections to the newly-added QED support patch series:
      
       - Correct the QED header field offsets
       - Remove XML parsing for VIR_STORAGE_FILE_AUTO_SAFE
      Signed-off-by: NAdam Litke <agl@us.ibm.com>
      a76234f3
  3. 22 11月, 2010 1 次提交
  4. 20 11月, 2010 1 次提交
    • S
      nwfilter: re-order lock grabbed by IP addr. learn thread · 52834904
      Stefan Berger 提交于
      The IP address learning thread was causing a deadlock when it instantiated a filter while a filter update/change was ongoing. The reason for this was the ordering of locks due to the following calls
      
      virNWFilterUnlockFilterUpdates()
      virNWFilterPoolObjFindByName()
      
      The below patch now puts the order of the locks in the above shown order when instantiating the filter from the IP address learning thread.
      52834904