1. 09 7月, 2014 9 次提交
    • J
    • J
      Actually fix the spec file · a3a2080e
      Ján Tomko 提交于
      There was a '%' missing before the last {rhel}.
      Tested on RHEL-7 this time.
      a3a2080e
    • J
      libxl: fix crash in migrate confirm for transient domains · 72a84539
      Jim Fehlig 提交于
      In libxlDomainMigrationConfirm(), a transient domain is removed
      from the domain list after successful migration.  Later in cleanup,
      the domain object is unlocked, resulting in a crash
      
      Program received signal SIGSEGV, Segmentation fault.
      [Switching to Thread 0x7fb4208ed700 (LWP 12044)]
      0x00007fb4267251e6 in virClassIsDerivedFrom (klass=0xdeadbeef,
        parent=0x7fb42830d0c0) at util/virobject.c:169
      169	        if (klass->magic == parent->magic)
      (gdb) bt
      0  0x00007fb4267251e6 in virClassIsDerivedFrom (klass=0xdeadbeef,
        parent=0x7fb42830d0c0) at util/virobject.c:169
      1  0x00007fb42672591b in virObjectIsClass (anyobj=0x7fb4100082b0,
        klass=0x7fb42830d0c0) at util/virobject.c:365
      2  0x00007fb42672583c in virObjectUnlock (anyobj=0x7fb4100082b0)
        at util/virobject.c:338
      3  0x00007fb41a8c7d7a in libxlDomainMigrationConfirm (driver=0x7fb4100404c0,
        vm=0x7fb4100082b0, flags=1, cancelled=0) at libxl/libxl_migration.c:583
      
      Fix by setting the virDomainObjPtr to NULL after removing it from
      the domain list.
      72a84539
    • J
      libxl: acquire job though begin phase only · bab7ad4c
      Jim Fehlig 提交于
      During migration, the libxl driver starts a modify job in the
      begin phase, ending the job in the confirm phase.  This is
      essentially VIR_MIGRATE_CHANGE_PROTECTION semantics, but the
      driver does not support that flag.  Without CHANGE_PROTECTION
      support, the job would never be terminated in error conditions
      where migrate confirm phase is not executed.  Further attempts
      to modify the domain would result in failure to acquire a job
      after LIBXL_JOB_WAIT_TIME.
      
      Similar to the qemu driver, end the job in the begin phase.
      Protecting the domain object across all phases of migration can
      be done in a future patch adding CHANGE_PROTECTION support.
      bab7ad4c
    • J
      libxl: remove domain when migration prepare fails · c4f66bb8
      Jim Fehlig 提交于
      In libxlDomainMigrationPrepare(), a new virDomainObj is created
      from the incoming domain def and added to the driver's domain
      list, but never removed if there are subsequent failures during
      the prepare phase.
      
      targethost# virsh list --all
      
      sourcehost# virsh migrate --live dom xen+ssh://targethost/system
         error: operation failed: Fail to create socket for incoming migration.
      
      targethost# virsh list --all
      error: Failed to list domains
      error: name in virGetDomain must not be NULL
      
      After adding code to remove the domain on prepare failure, noticed
      that libvirtd crashed due to double free of the virDomainDef.  Similar
      to the qemu driver, pass a pointer to virDomainDefPtr so it can be set
      to NULL once a virDomainObj is created from it.
      c4f66bb8
    • J
      libxl: rename goto label · 92cd6b67
      Jim Fehlig 提交于
      In libxlDomainMigrationPrepare(), the cleanup label handles error
      conditions and should be renamed as such for clarity.
      92cd6b67
    • C
      LXC: fix an improper comments for lxcDomainDestroyFlags · 110b959f
      Chen Hanxiao 提交于
      Currently @flag is not used yet.
      Signed-off-by: NChen Hanxiao <chenhanxiao@cn.fujitsu.com>
      110b959f
    • G
      qemu: raise an eror when using aio=native without cache=none · 05838400
      Giuseppe Scrivano 提交于
      Qemu will fallback to aio=threads when the cache mode doesn't use
      O_DIRECT, even if aio=native was explictly set.
      
      Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086704Signed-off-by: NGiuseppe Scrivano <gscrivan@redhat.com>
      05838400
    • E
      maint: update to latest gnulib · 0ea6512d
      Eric Blake 提交于
      When run under an environment that inherits an ignored SIGPIPE
      (hello, annoying buildbots), a syntax-check was producing quite
      a bit of noise, such as:
      
      > prohibit_argmatch_without_use
      > grep: write error
      > grep: write error
      > /bin/sed: couldn't write 25 items to stdout: Broken pipe
      > sed: couldn't write 1 item to stdout: Broken pipe
      > 0.46 prohibit_argmatch_without_use
      
      This has been fixed upstream in gnulib.  There are several other
      portability improvements in our regular submodule update.
      
      * .gnulib: Update to latest, in part for quieter syntax-check.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      0ea6512d
  2. 08 7月, 2014 21 次提交
  3. 07 7月, 2014 9 次提交
  4. 05 7月, 2014 1 次提交