1. 01 3月, 2010 4 次提交
  2. 26 2月, 2010 1 次提交
  3. 27 2月, 2010 3 次提交
  4. 26 2月, 2010 8 次提交
    • C
      Only build virDomainObjFormat if not building proxy. · 1204e41f
      Chris Lalancette 提交于
      While building under RHEL-5, I got a compile warning because
      virDomainObjFormat was defined but not used.  That came about
      because in RHEL-5 we build with "#define PROXY", and
      virDomainObjFormat is only used with !PROXY.  Move the
      define.
      Signed-off-by: NChris Lalancette <clalance@redhat.com>
      1204e41f
    • J
      openvzGetVEID: don't leak (memory + file descriptor) · f3439c7e
      Jim Meyering 提交于
      * src/openvz/openvz_conf.c (openvzGetVEID): Always call fclose.
      Diagnose parse failure also when vzlist output is empty.
      If somehow we read a -1, diagnose that (albeit as a parse failure).
      f3439c7e
    • C
      Use standard spacing for user/pass prompt · 8ac0334e
      Cole Robinson 提交于
      Kind of minor, but it annoys me that the default auth callback
      doesn't put a space between the prompt and the input, like a typical
      terminal, ssh, etc. This patch changes the current prompt:
      
      Please enter your authentication name:myuser
      
      to
      
      Please enter your authentication name: myuser
      8ac0334e
    • C
      libvirtd: Better initscript error reporting · b39c2068
      Cole Robinson 提交于
      From time to time I bork my install, and hate it when the initscript
      returns no info. This patch removes the sanity check, which lets
      the shell give us 'command not found' or 'permission denied' errors.
      b39c2068
    • C
      qemu: Report binary path if error parsing -help · a09af3b0
      Cole Robinson 提交于
      a09af3b0
    • C
      remote: Improve daemon startup error reporting · 67b2eb10
      Cole Robinson 提交于
      If I toggle enable_tcp in libvirtd.conf and add --listen in
      /etc/init.d/libvirtd, I get the unhelpful error:
      
      Starting libvirtd daemon: error: Unable to initialize network sockets.
      
      Running without --daemon provides much more useful info:
      
      sudo libvirtd --listen
      11:29:26.117: error : remoteCheckCertFile:270 : Cannot access CA certificate '/etc/pki/CA/cacert.pem': No such file or directory
      
      The daemon architecture makes it difficult to report this useful
      info if daemonized, so point users to /var/log/messages and
      dropping the --daemon flag if they want more info.
      67b2eb10
    • C
      virsh: Show errors reported by nonAPI functions · 48286963
      Cole Robinson 提交于
      Only API calls trigger the error callback, which is required for
      proper virsh error reporting. Since we use non API functions from
      util/, make sure we properly report these errors.
      
      Fixes lack of error message from 'virsh create idontexit.xml'
      48286963
    • C
      remote: Improve error message when libvirtd isn't running · c56cf8d5
      Cole Robinson 提交于
      While this could lead people in the wrong direction, people most commonly
      hit this error when libvirtd isn't running, so let's mention a possible
      fix.
      c56cf8d5
  5. 25 2月, 2010 13 次提交
    • J
      build: avoid warning about unused variables · 8ddff3e6
      Jim Meyering 提交于
      * tools/virsh.c (cmdCPUBaseline): Remove declarations of unused
      variables, p and cur.
      8ddff3e6
    • J
      build: avoid "make rpm" failure in docs/ · a79fb1c4
      Jim Meyering 提交于
      Add missing rule to build html/libvirt-libvirt.html.
      Use a GNU Make pattern rule to avoid running apibuild.py once
      for each out-of-date target, in a parallel build.
      * docs/Makefile.am
      a79fb1c4
    • J
      build: teach apibuild.py to work in a non-srcdir build · ace4dca5
      Jim Meyering 提交于
      * docs/Makefile.am (libvirt-api.xml libvirt-refs.xml): Generalize
      apibuild.py to work in a non-srcdir build.  Pass "srcdir" to it.
      * docs/apibuild.py (rebuild): Honor the $srcdir envvar.
      ace4dca5
    • J
      build: avoid non-srcdir "make distcheck" failures (CLEANFILES) · f064dca7
      Jim Meyering 提交于
      * docs/Makefile.am (MAINTAINERCLEANFILES): Use this variable
      for generated-and-distributed files, not "CLEANFILES".
      Besides, "make clean" and "make distclean" should not delete
      distributed files.
      f064dca7
    • J
      build: make git submodule checking more reliable · 0f88dade
      Jim Meyering 提交于
      * cfg.mk (_curr_status): Accommodate leading "+" or "-" in the output
      of git submodule status.
      * autogen.sh: Likewise.
      0f88dade
    • J
      build: avoid non-srcdir "make distcheck" failures (srcdir vs wildcard) · 083b901e
      Jim Meyering 提交于
      * tests/xencapsdata/Makefile.am: Use $(wildcard in $(srcdir)-aware manner
      * tests/xmconfigdata/Makefile.am: Likewise.
      * tests/xml2sexprdata/Makefile.am: Likewise.
      * tests/sexpr2xmldata/Makefile.am (EXTRA_DIST): Likewise.
      * Makefile.am (XML_EXAMPLES): Use $(wildcard in $(srcdir)-aware manner.
      083b901e
    • J
      build: avoid non-srcdir "make distcheck" failure (test_conf.sh) · 327d5fe0
      Jim Meyering 提交于
      * tests/confdata/Makefile.am (EXTRA_DIST): Apply $(wildcard... to
      $(srcdir)/..., and then remove the prefix.
      327d5fe0
    • J
      build: avoid non-srcdir installation failure (sitemap.html.in) · 0a42b9e2
      Jim Meyering 提交于
      * docs/Makefile.am (EXTRA_DIST): Add sitemap.html.in.
      0a42b9e2
    • J
      build: avoid non-srcdir installation failure (apibuild.py) · 53ed2c4c
      Jim Meyering 提交于
      * docs/Makefile.am (libvirt-api.xml): Insert missing "$(srcdir)/".
      Also, remove unnecessary sub-shell.
      53ed2c4c
    • J
      build: fix typos in makefile variable names · 5365ff40
      Jim Meyering 提交于
      * configure.ac: Fix typos:
      s/DRIVER_MODULES_CFLAGS/DRIVER_MODULE_CFLAGS/
      s/DRIVER_MODULES_LIBS/DRIVER_MODULE_LIBS/
      5365ff40
    • J
      build: ensure that MKINSTALLDIRS is AC_SUBST-defined · 89bdf84b
      Jim Meyering 提交于
      since we're using gettext-0.14.1, which uses that now-obsolete
      automake symbol.  Otherwise, make distcheck would fails like this:
      
          make[2]: Entering directory `/t/libvirt-0.7.6/_build/po'
          /bin/sh @MKINSTALLDIRS@ /t/libvirt-0.7.6/_inst/share
          /bin/sh: @MKINSTALLDIRS@: No such file or directory
          make[2]: *** [install-data-yes] Error 127
      
      * configure.ac (MKINSTALLDIRS): Define.
      For reference, we're currently hamstrung by our desire
      to support RHEL5, which still uses gettext-0.14:
      http://bugzilla.redhat.com/523713
      89bdf84b
    • E
      maint: relax git minimum version · c560fc49
      Eric Blake 提交于
      Requiring git 1.6.4, just for the optional GNULIB_SRCDIR support,
      was too harsh.  Resynchronize from gnulib.
      
      * .gnulib: Import from latest gnulib.
      * bootstrap: Re-synchronize from .gnulib/build-aux.
      * bootstrap.conf: Drop git to 1.5.5.
      * README-hacking: Document use of GNULIB_SRCDIR.
      c560fc49
    • R
      Ignore SIGWINCH in remote client call to poll(2) (RHBZ#567931). · f4a43df5
      Richard Jones 提交于
      In bug 567931 we found that virt-top would exit occasionally
      when the terminal window was resized.  Tracking this down it
      turned out that SIGWINCH was being delivered to the process at
      exactly the point where the libvirt remote driver was calling
      poll(2) waiting for a reply from libvirtd.
      
      This caused the poll(2) call to be interrupted (returning errno
      EINTR).  However handling EINTR the same way as EAGAIN was not
      the solution to this problem since we found previously that this
      would break Ctrl-C handling (commit 47fec8ea).
      
      The correct solution is to mask out SIGWINCH for the duration
      of the poll(2) system call.  The per-thread mask is changed and
      restored immediately after the call.  Since we are using
      pthread_sigmask, this should not affect other threads, and
      since we restore the signal mask immediately afterwards it should
      not affect the current thread visibly either.  Other possibly
      problematic signals are SIGCHLD and SIGPIPE and these are
      masked too.
      
      Note use of ignore_value: It's not fatal if we cannot mask out
      SIGWINCH, and in any case pthread_sigmask never fails on Linux
      as long as you supply the correct arguments.
      
      I tested this patch and it cures the original problem with
      virt-top.
      f4a43df5
  6. 24 2月, 2010 8 次提交
    • S
      Add descriptions for macvtap direct type interfaces · c7b85e37
      Stefan Berger 提交于
      This adds a description about the 'direct' type of interface recently
      added for macvtap device type support on the host.
      c7b85e37
    • D
      Format FS pools on creation · b738016b
      Dave Allan 提交于
      Create the filesystem on the partition used by the pool
      * configure.ac: check for mkfs availability
      * libvirt.spec.in: add extra require on util-linux for mkfs
      * src/storage/storage_backend_fs.c: run mkfs with the expected
        fs type when creating a filesystem pool
      b738016b
    • E
      maint: sort .gitignore · 9ad255f9
      Eric Blake 提交于
      Fallout from the new bootstrap.
      
      * .gitignore: Commit sorting done by bootstrap.
      * build-aux/.gitignore: Likewise.
      * po/.gitignore: Likewise.
      9ad255f9
    • E
      maint: import modern bootstrap · 38c9440a
      Eric Blake 提交于
      Copy the latest gnulib bootstrap, which runs autoreconf and
      generates po/Makevars for us.  Other improvements include some
      improved prerequisite tool checking.
      
      This also fixes a bug in the .pot files, regarding the copyright holder.
      
      * bootstrap: Update to version in .gnulib/build-aux.
      * bootstrap.conf (MSGID_BUGS_ADDRESS, COPYRIGHT_HOLDER, SKIP_PO)
      (gnulib_mk, ACLOCAL, bootstrap_epilogue): Provide overrides.
      * autogen.sh (autoreconf): Avoid redundant autoreconf if bootstrap
      was run.
      * po/Makevars: Delete, now that bootstrap creates it.
      * po/.gitignore: Update.
      38c9440a
    • E
      maint: start factoring bootstrap · 1a51d05f
      Eric Blake 提交于
      Borrow ideas from gnulib/build-aux/bootstrap, in order to factor the
      specifics of libvirt into bootstrap.conf, while allowing future
      upgrades of bootstrap to happen with less effort.
      
      * bootstrap (gnulib_tool): Update invocation to be closer to
      gnulib's version.  Move libvirt specifics...
      * bootstrap.conf: ...into new file.
      1a51d05f
    • E
      maint: fix quoting in autogen.sh · f1ef0e31
      Eric Blake 提交于
      * autogen.sh (srcdir, THEDIR, OBJ_DIR): Use proper quoting.
      (.git-module-status): Abort if bootstrap fails.
      f1ef0e31
    • J
      build: update gnulib submodule to latest · d2a97734
      Jim Meyering 提交于
      * cfg.mk (local-checks-to-skip): Disable sc_prohibit_hash_without_use
      for now, since it fails with a false-positive match.
      d2a97734
    • J
      virFork: placate static analyzers: ignore pthread_sigmask return value · 0e69905d
      Jim Meyering 提交于
      * src/util/util.c: Include "ignore-value.h".
      (virFork): We really do want to ignore pthread_sigmask failure.
      0e69905d
  7. 23 2月, 2010 3 次提交