1. 07 1月, 2010 6 次提交
    • M
      Don't free an uninitalized pointer in update_driver_name() · 338e7c3c
      Matthias Bolte 提交于
      This invalid free results in heap corruption. Some symptoms I saw
      because of this were libvirtd crashing and virt-manager hanging
      while trying to enumerate devices.
      338e7c3c
    • J
      xend_internal: don't let invalid input provoke NULL dereference · 7679f064
      Jim Meyering 提交于
      * src/xen/xend_internal.c (xenDaemonOpen_unix): Do not dereference
      a NULL "conn".  Move first deref to follow the "conn == NULL" test.
      7679f064
    • A
      qemu: Always enable the virtio balloon driver · 7a90f216
      Adam Litke 提交于
      The behavior for the qemu balloon device has changed.  Formerly, a virtio
      balloon device was provided by default.  Now, '-balloon virtio' must be
      specified on the command line to enable it.  This patch causes libvirt to
      add '-balloon virtio' to the command line whenever the -balloon option is
      available.
      * src/qemu/qemu_conf.c src/qemu/qemu_conf.h: check for the new flag and
        add "-baloon vitio" to qemu command when needed
      * tests/qemuhelptest.c: add the new flag for detection
      7a90f216
    • D
      Don't update vol details after build · 1c06eb18
      David Allan 提交于
      This patch removes the call to vol update after the volume build completes.
      The update call is currently meaningless anyway because the vol build is passed
      a copy of the definition, so the update result is thrown away.  More
      importantly, if the user specified a selinux label for the volume, the update
      call results in a double free of the label
      * src/storage/storage_backend_fs.c: remove the update call
      1c06eb18
    • D
      Disable building of static Python module · 8838ee39
      Diego Elio Pettenò 提交于
      * python/Makefile.am: python modules are loaded at runtime so the static
        version is not needed, avoid building it
      8838ee39
    • M
      Fix parsing of 'info chardev' line endings · c0a9b6a5
      Matthew Booth 提交于
      This change makes the 'info chardev' parser ignore any trailing
      whitespace on a line. This fixes a specific problem handling a '\r\n'
      line ending.
      
      * src/qemu/qemu_monitor_text.c: Ignore trailing whitespace in
        'info chardev' output.
      c0a9b6a5
  2. 06 1月, 2010 4 次提交
  3. 05 1月, 2010 1 次提交
  4. 28 12月, 2009 1 次提交
  5. 24 12月, 2009 1 次提交
  6. 23 12月, 2009 7 次提交
  7. 22 12月, 2009 16 次提交
    • O
      fix some error report when on remote access · 54f868c1
      Olivier Fourdan 提交于
      When querying about a domain from 0.3.3 (or RHEL 5.3) domain located
      on a 0.6.3 (RHEL-5) machine, the errors are not properly reported.
      This patch from Olivier Fourdan <ofourdan@redhat.com> , slightly
      modified to not change the semantic when the domain os details cannot
      be provided
      
      * src/xen/proxy_internal.c src/xen/xen_hypervisor.c: add some missing
        error reports
      54f868c1
    • M
      Fix undefined reference to 'close_used_without_including_unistd_h' · 457d4ad9
      Matthias Bolte 提交于
      Found while trying to cross-compile libvirt on Fedora 12 for Windows.
      gnulib redefines 'close' to 'close_used_without_including_unistd_h'
      in sys/socket.h if winsock2.h is present and unistd.h has not been
      included before sys/socket.h. Reorder some includes to fix this.
      457d4ad9
    • M
      9501a45f
    • M
      Define ATTRIBUTE_SENTINEL for GCC < 4.0 too · a3bd8bbb
      Matthias Bolte 提交于
      ATTRIBUTE_SENTINEL was defined for GCC >= 4.0 only, resulting in
      compile errors when using GCC < 4.0.
      a3bd8bbb
    • M
      Fix compilation with configure --disable-nls · d4c1e5ae
      Matthias Bolte 提交于
      d4c1e5ae
    • M
      cpu: Fix memory leaks in x86FeatureLoad and x86ModelLoad · 434daaff
      Matthias Bolte 提交于
      Also backup and restore the original ctxt->node value in x86FeatureLoad.
      434daaff
    • M
      Fix configure check for SASL · 156e36a2
      Matthias Bolte 提交于
      The option --with-sasl defaults to 'check', but an inverted test logic
      lets the SASL check fail with an error instead of disabling SASL.
      Fix the test logic so SASL support gets disabled if SASL is missing and
      --with-sasl is set to check.
      156e36a2
    • M
      Fix GnuTLS pkg-config check · cf30da7a
      Matthias Bolte 提交于
      The testlogic for $PKG_CONFIG was inverted, checking for an empty string
      before using PKG_CHECK_MODULES. Use -x instead of -z and add an else branch
      to the if checking for $GNUTLS_FOUND = no to add -lgcrypt in case the
      GnuTLS libraries are detected by pkg-config.
      cf30da7a
    • M
      Report an error if no XDR library can be found · 188852c9
      Matthias Bolte 提交于
      188852c9
    • D
      Disable JSON mode monitor until QEMU is more mature · 27c357bc
      Daniel P. Berrange 提交于
      * src/qemu/qemu_conf.h: Remove QEMU_CMD_FLAG_0_12 and just leave
        the lone JSON flag
      * src/qemu/qemu_conf.c: Enable JSON on QEMU 0.13 or later, but
        leave it disabled for now
      27c357bc
    • J
      Only probe for CPU models if required · 8153c72b
      Jiri Denemark 提交于
      * src/qemu/qemu_conf.c: CPU models should be probed only if the
        a guest's XML contains CPU model, not each time a qemu command line
        is generated.
      8153c72b
    • D
      Add some people missing from the AUTHORS list · 5dbb208a
      Daniel Veillard 提交于
      5dbb208a
    • J
      Add cpu_map.xml to libvirt.spec · ab007c3d
      Jiri Denemark 提交于
      * libvirt.spec.in: embbed it in the main libvirt binary rpm
      ab007c3d
    • J
      Install cpu_map.xml · bfeeb9a6
      Jiri Denemark 提交于
      * src/Makefile.am: install it in $(pkgdatadir) i.e. /usr/share/libvirt/
        usually
      bfeeb9a6
    • C
      Make Xen VT-d PCI attach/detach work · e9f468d3
      Chris Lalancette 提交于
      The Xen code for making HVM VT-d PCI passthrough attach and detach
      wasn't working properly:
      
      1)  In xenDaemonAttachDevice(), we were always trying to reconfigure
      a PCI passthrough device, even the first time we added it.  This was
      because the code in virDomainXMLDevID() was not checking xenstore for
      the existence of the device, and always returning 0 (meaning that
      the device already existed).
      
      2)  In xenDaemonDetachDevice(), we were trying to use "device_destroy"
      to detach a PCI device.  While you would think that is the right
      method to call, it's actually wrong for PCI devices.  In particular,
      in upstream Xen (and soon in RHEL-5 Xen), device_configure is actually
      used to destroy a PCI device.
      
      To fix the attach
      problem I add a lookup into xenstore to see if the device we are
      trying to attach already exists.  To fix the detach problem I change
      it so that for PCI detach (only), we use device_configure with the
      appropriate sxpr to do the detachment.
      
      * src/xen/xend_internal.c: don't use device_destroy for PCI devices
        and fix the other issues.
      * src/xen/xs_internal.c src/xen/xs_internal.h: add
        xenStoreDomainGetPCIID()
      e9f468d3
    • D
      Fix detection of JSON when restarting libvirtd · c90e545f
      Daniel P. Berrange 提交于
      The XML XPath for detecting JSON in the running VM statefile was
      wrong causing all VMs to get JSON mode enabled at libvirtd restart.
      
      In addition if a VM was running a JSON enabled QEMU once, and then
      altered to point to a non-JSON enabled QEMU later the 'monJSON'
      flag would not get reset to 0.
      
      * src/qemu/qemu_driver.c: Fix setting/detection of JSON mode
      c90e545f
  8. 21 12月, 2009 4 次提交
    • A
      Document the dommemstat command in the virsh man page · cc3618d7
      Adam Litke 提交于
      * tools/virsh.pod: Provide a basic mention of the dommemstat command in
        the virsh man page.
      cc3618d7
    • D
      Change virsh dommemstats command to dommemstat · a858474f
      Daniel Veillard 提交于
      As Paul Jenner pointed out all other statistics commands use the
      singular form
      
      * tools/virsh.c: rename dommemstats to dommemstat as well as function
        name and associated structures
      a858474f
    • D
      Fix reporting of TLS connection errors · 469b6b3a
      Daniel P. Berrange 提交于
      The code for connecting to a server tries each socket in turn
      until it finds one that connects. Unfortunately for TLS sockets
      if it connected, but failed TLS handshake it would treat that
      as a failure to connect, and try the next socket. This is bad,
      it should have reported the TLS failure immediately.
      
      $ virsh -c qemu://somehost.com/system
      error: unable to connect to libvirtd at 'somehost.com': Invalid argument
      error: failed to connect to the hypervisor
      
      $ ./tools/virsh -c qemu://somehost.com/system
      error: server certificate failed validation: The certificate hasn't got a known issuer.
      error: failed to connect to the hypervisor
      
       * src/remote/remote_driver.c: Stop trying to connect if the
         TLS handshake fails
      469b6b3a
    • D
      Fix typo in qemudDomainAttachHostPciDevice() · 9b2c299a
      Daniel Veillard 提交于
      * src/qemu/qemu_driver.c: The 'if' statement is supposed to check return
        value of pci = pciGetDevice(conn, ...); , but check uses if (!dev),
        fix it
      9b2c299a