- 24 7月, 2010 1 次提交
-
-
由 Chris Lalancette 提交于
Since we are adding a new "per-hypervisor" protocol, we make it so that the qemu remote protocol uses a new PROTOCOL and PROGRAM number. This allows us to easily distinguish it from the normal REMOTE protocol. This necessitates changing the proc in remote_message_header from a "remote_procedure" to an "unsigned", which should be the same size (and thus preserve the on-wire protocol). Changes since v1: - Fixed up a couple of script problems in remote_generate_stubs.pl - Switch an int flag to a bool in dispatch.c Changes since v2: - None Changes since v3: - Change unsigned proc to signed proc, to conform to spec Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
- 02 6月, 2010 1 次提交
-
-
由 Eric Blake 提交于
* cfg.mk (sc_check_author_list): Look in correct location.
-
- 28 5月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_check_AUTHOR_list): New rule. * .mailmap: New file, to tell git log how to map email addresses.
-
- 22 5月, 2010 1 次提交
-
-
由 Jim Fehlig 提交于
V2: - Move bitmap impl to src/util/bitmap.[ch] - Use CHAR_BIT instead of explicit '8' - Use size_t instead of unsigned int - Fix calculation of bitmap size in virBitmapAlloc - Ensure bit is within range of map in the set, clear, and get operations - Use bool in virBitmapGetBit - Add virBitmapFree to free-like funcs in cfg.mk V3: - Check for overflow in virBitmapAlloc - Fix copy and paste bug in virBitmapAlloc - Use size_t in prototypes - Add ATTRIBUTE_NONNULL in prototypes where appropriate and remove NULL check from impl V4: - Add ATTRIBUTE_RETURN_CHECK in prototypes where appropriate.
-
- 21 5月, 2010 2 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_prohibit_gettext_markup): Just like VIR_WARN*.
-
由 Jim Meyering 提交于
* cfg.mk (msg_gen_function): Add VIR_ERROR and VIR_ERROR0, so that sc_libvirt_unmarked_diagnostics will check them, too.
-
- 20 5月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_prohibit_newline_at_end_of_diagnostic): New rule. Idea proposed by Jiri Denemark.
-
- 19 5月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_prohibit_gettext_markup): New rule, to enforce this policy. Contrary to most diagnostic-emitting functions, where we require _(...) markup, here, we require that _() *not* be used for certain functions (or function-like macros).
-
- 18 5月, 2010 2 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (useless_free_options): Add many vir*Free* function names, and then remove the useless if-before-free tests exposed by running make syntax-check. * src/conf/interface_conf.c (virInterfaceDefFree): Remove useless "if". (virInterfaceAssignDef): Likewise. * src/conf/network_conf.c (virNetworkAssignDef): Likewise. * src/conf/storage_conf.c (virStoragePoolObjAssignDef): Likewise. * src/node_device/node_device_hal.c (dev_create): Likewise. * src/security/virt-aa-helper.c (vahDeinit): Likewise. * src/test/test_driver.c (testNodeDeviceCreateXML): Likewise. * src/util/conf.c (virConfSetValue): Likewise.
-
由 Jim Meyering 提交于
This makes the useless-if-before-free test in maint.mk spot uses of virCgroupFree just like it does for free and the other listed functions. * cfg.mk (useless_free_options): Add virCgroupFree. Prompted by suggestion from Eric Blake.
-
- 11 5月, 2010 1 次提交
-
-
由 Eric Blake 提交于
Some shells warn about missing programs before redirection; the idiomatic way to silence them is to run the program check inside a subshell, with the redirections outside the subshell. But a subshell is only needed in places where it is reasonable to expect the use of such a noisy shell in the first place. * src/Makefile.am (remote_protocol-structs): Use subshell, for FreeBSD 8.0 /bin/sh. * cfg.mk (sc_preprocessor_indentation): Avoid subshell, since the only users running cfg.mk can be assumed to have decent tools.
-
- 28 4月, 2010 1 次提交
-
-
由 Eric Blake 提交于
* cfg.mk (gnulib_srcdir): Override maint.mk default. (_update_required): Run in correct directory.
-
- 22 4月, 2010 2 次提交
-
-
由 Eric Blake 提交于
Noticed because virt-pki-validate was very inconsistent on using tabs vs. 8 spaces, sometimes mixing both paradigms on a single line. 'git diff -b' shows significant changes only in cfg.mk. * cfg.mk (sc_TAB_in_indentation): Add a few files. * daemon/libvirtd.init.in: Avoid tabs. * tools/virt-pki-validate.in: Likewise.
-
由 Eric Blake 提交于
* .gitignore: Add exemption. * cfg.mk (local-checks-to-skip): Ignore a test to silence a skip warning.
-
- 09 4月, 2010 2 次提交
-
-
由 Matthias Bolte 提交于
Remove symbols that don't exist anymore (e.g. ERROR0) or aren't message generating functions (e.g. VIR_FREE) or are now reported as unmarked because the grep command is different, but that should not be marked at all (e.g. DEBUG0). Also don't restrict one of the grep lines in the libvirt_unmarked_diagnostics rule to match exactly one space between function name and opening parenthesis.
-
由 Matthias Bolte 提交于
Also unify error/errorf to remoteError and update cfg.mk accordingly.
-
- 07 4月, 2010 4 次提交
-
-
由 Eric Blake 提交于
Tested by running 'git submodule foreach git pull origin master' and 'git add .gnulib', then seeing that 'make clean' skips autogen although 'make' properly runs it. * cfg.mk (_clean_requested): New check, to speed up 'make clean' even if gnulib submodule is outdated. Suggested by Daniel P. Berrange.
-
由 Matthias Bolte 提交于
Also rename ReportError to macvtapError.
-
由 Matthias Bolte 提交于
Also define ESX_ERROR and ESX_VI_ERROR in a central place, instead of defining them in each source file. Add ESX_ERROR and ESX_VI_ERROR to the msg_gen_function list in cfg.mk. Update po/POTFILES.in accordingly.
-
由 Matthias Bolte 提交于
Add vboxError to the msg_gen_function list in cfg.mk.
-
- 05 4月, 2010 1 次提交
-
-
由 David Allan 提交于
* Since the file pattern matches RNG schemas as well as C sources, the error message should mention both.
-
- 03 4月, 2010 2 次提交
-
-
由 Eric Blake 提交于
git reset --hard 96e5a2d4 ./autogen.sh make -s git pull make -s <-- expecting auto-bootstrap here, doesn't happen Use git diff to expose whether the submodule has untracked changes, which are typical on an incremental pull if .gnulib was updated but the user did not manually run 'git submodule update'. After this patch is applied, I encountered a new problem when following the reproducing pattern. Basically, the change to .gnulib between libvirt's commit 96e5a2d4 and this patch introduced a change to sys_ioctl.in.h, but gnulib (intentionally) does not make the replacement headers depend on Makefile changes. Therefore, I ended up with the generated replacement header being broken: gnulib/lib/sys/ioctl.h complained about a use of @. But that seems like something that should be fixed upstream in gnulib's bootstrap script (that is, when doing a gnulib update, all files created from .in.h file should probably be deleted). Without the benefit of that proposed gnulib fix, I worked around the problem by manually removing the stale gnulib/lib/sys/ioctl.h. * autogen.sh (t): Also run bootstrap if the gnulib submodule needs to be updated. * cfg.mk (_autogen): Likewise. Reported by Matthias Bolte.
-
由 Eric Blake 提交于
A lot of syntax check rules have to be rewritten, but the result is easier to maintain. I tested each syntax rule by intentionally introducing a temporary violation of the rule. Additionally, some false positives for unmarked_diagnostics crept in, and an improved copyright_format test caught some bugs. * .gnulib: Update to latest. * cfg.mk (sc_prohibit_test_minus_ao): Delete, it was moved into gnulib's maint.mk. (sc_avoid_write, sc_prohibit_strcmp_and_strncmp) (sc_prohibit_asprintf, sc_prohibit_strncpy, sc_prohibit_readlink) (sc_prohibit_gethostname, sc_prohibit_gettext_noop) (sc_prohibit_VIR_ERR_NO_MEMORY, sc_prohibit_nonreentrant) (sc_prohibit_ctype_h, sc_TAB_in_indentation) (sc_avoid_ctype_macros) (sc_prohibit_virBufferAdd_with_string_literal) (sc_prohibit_gethostby, sc_copyright_format): Rewrite in terms of new maint.mk macros. (sc_libvirt_unmarked_diagnostics): Fix whitespace. * .x-sc_unmarked_diagnostics: New file. * tests/object-locking.ml: Fix copyright. * tools/virt-pki-validate.in: Likewise. * tools/virt-xml-validate.in: Likewise.
-
- 01 4月, 2010 1 次提交
-
-
由 Eric Blake 提交于
* cfg.mk (sc_prohibit_test_minus_ao): Also check for [. * docs/Makefile.am (%.html, html/index.html): Avoid non-portable test usage. * libvirt.spec.in (%post): Likewise. * tools/virt-pki-validate.in (servercert.pem): Likewise. * configure.ac (LOGNAME): Use test, not [, in files processed by autoconf. Detected by Matthias Bolte.
-
- 31 3月, 2010 2 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (msg_gen_function): Add xenapiSessionErrorHandler. * po/POTFILES.in: Add src/xenapi/xenapi_driver.c * src/xenapi/xenapi_driver.c: Mark strings for translation. * src/xenapi/xenapi_utils.c (xenapiUtil_ParseQuery):
-
由 Eric Blake 提交于
Automate the reuse of autogen.sh, rather than just erroring out. * cfg.mk (_update_required): Run autogen.sh, rather than just warning about it. (_autogen): New target.
-
- 27 3月, 2010 1 次提交
-
-
由 Eric Blake 提交于
Picks up fixes for gethostname compilation problems on mingw. * .gnulib: Update to latest. * build-aux/.gitignore: Regenerate. * cfg.mk (local-checks-to-skip): Avoid new test not relevent to libvirt.
-
- 26 3月, 2010 2 次提交
-
-
由 Eric Blake 提交于
* cfg.mk (sc_prohibit_test_minus_a): Rename... (sc_prohibit_test_minus_ao): ...and flag '-o', too.
-
由 Jim Meyering 提交于
* cfg.mk (useless_free_options): Add virDomainDefFree to the list of free-like functions. * src/test/test_driver.c (testDomainCreateXML): Remove useless-if- before-virDomainDefFree. * src/conf/domain_conf.c (virDomainAssignDef): Likewise
-
- 24 3月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_prohibit_test_minus_a): New rule.
-
- 19 3月, 2010 1 次提交
-
-
由 Eric Blake 提交于
* cfg.mk (sc_copyright_format): New rule.
-
- 18 3月, 2010 2 次提交
-
-
由 Eric Blake 提交于
* cfg.mk (sc_prohibit_gettext_noop): Fix typo
-
由 Eric Blake 提交于
* cfg.mk (sc_prohibit_gettext_noop): New rule applied in "make syntax-check"
-
- 11 3月, 2010 2 次提交
-
-
由 Eric Blake 提交于
* autogen.sh (curr_status): Also include hash of bootstrap.conf when checking for changes that require bootstrap rerun. * cfg.mk (_update_required): Likewise.
-
由 Eric Blake 提交于
Since cppi is not part of Fedora Core 12, the check is conditional: without cppi, running 'make syntax-check' merely warns: $ make sc_preprocessor_indentation preprocessor_indentation maint.mk: skipping test sc_preprocessor_indentation: cppi not installed * cfg.mk (sc_preprocessor_indentation): New syntax-check rule. (preprocessor_exempt): New macro, with first exemption.
-
- 02 3月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (sc_TAB_in_indentation): Also check .rng files.
-
- 25 2月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (_curr_status): Accommodate leading "+" or "-" in the output of git submodule status. * autogen.sh: Likewise.
-
- 24 2月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (local-checks-to-skip): Disable sc_prohibit_hash_without_use for now, since it fails with a false-positive match.
-
- 22 1月, 2010 1 次提交
-
-
由 Chris Lalancette 提交于
Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
- 18 1月, 2010 1 次提交
-
-
由 Jim Meyering 提交于
The latter is not officially "wrong", but *is* terribly anachronistic. I think automake documentation or comments call that syntax obsolescent. * cfg.mk (_makefile_at_at_check_exceptions): Exempt @SCHEMADIR@ and @SYSCONFDIR@ uses -- there are no Makefile variables for those. * docs/Makefile.am: Use $(INSTALL), not @install@. * examples/dominfo/Makefile.am: Similar. * examples/domsuspend/Makefile.am: Similar. * proxy/Makefile.am: Similar. * python/Makefile.am: Similar. * python/tests/Makefile.am: Similar. * src/Makefile.am: Similar. * tests/Makefile.am: Similar.
-