1. 17 6月, 2015 1 次提交
  2. 22 5月, 2015 1 次提交
    • T
      conf: fix issue on virCPUDefCopy · bd1a133f
      Thibaut Collet 提交于
      The cpu xml copy is incorrect: the memAccess field is not copied.
      The lack of copy of this memAccess field can cause unexpected behaviour for live
      migration when vhost user is used.
      
      For example if guest has the following configuration:
      ....
      <cpu>
      <model>Westmere</model>
      <topology sockets="1" cores="4" threads="1"/>
      <numa>
      <cell id='0' cpus='0-3' memory='2097152' memAccess='shared'/>
      </numa>
      </cpu>
      ....
      
      The used configuration on the remote host in case of live migration is:
      ....
        <cpu mode='custom' match='exact'>
          <model fallback='allow'>Westmere</model>
          <topology sockets='1' cores='4' threads='1'/>
          <numa>
            <cell id='0' cpus='0-3' memory='2097152' unit='KiB'/>
          </numa>
        </cpu>
      ....
      
      On the remote host the lack of memAccess info can cause unexpected error on the
      qemu backend vhost user driver.
      
      Fixes: def6b359 ("docs, conf, schema: add support for shared memory mapping")
      
      This issue is present only for libvirt1.2.9 to libvirt1.2.12
      With patch 181742d4 ("conf: Move all NUMA configuration to virDomainNuma")
      present since libvirt1.2.13 the problem does not exist anymore as NUMA
      information are no more in the CPU configuration.
      Signed-off-by: NThibaut Collet <thibaut.collet@6wind.com>
      bd1a133f
  3. 17 3月, 2015 1 次提交
    • E
      daemon: avoid memleak when ListAll returns nothing · 34538870
      Eric Blake 提交于
      Commit 4f25146b (v1.2.8) managed to silence Coverity, but at the
      cost of a memory leak detected by valgrind:
      ==24129== 40 bytes in 5 blocks are definitely lost in loss record 355 of 637
      ==24129==    at 0x4A08B1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
      ==24129==    by 0x5084B8E: virReallocN (viralloc.c:245)
      ==24129==    by 0x514D5AA: virDomainObjListExport (domain_conf.c:22200)
      ==24129==    by 0x201227DB: qemuConnectListAllDomains (qemu_driver.c:18042)
      ==24129==    by 0x51CC1B6: virConnectListAllDomains (libvirt-domain.c:6797)
      ==24129==    by 0x14173D: remoteDispatchConnectListAllDomains (remote.c:1580)
      ==24129==    by 0x121BE1: remoteDispatchConnectListAllDomainsHelper (remote_dispatch.h:1072)
      
      In short, every time a client calls a ListAll variant and asks
      for the resulting list, but there are 0 elements to return, we
      end up leaking the 1-entry array that holds the NULL terminator.
      
      What's worse, a read-only client can access these functions in a
      tight loop to cause libvirtd to eventually run out of memory; and
      this can be considered a denial of service attack against more
      privileged clients.  Thankfully, the leak is so small (8 bytes per
      call) that you would already have some other denial of service with
      any guest calling the API that frequently, so an out-of-memory
      crash is unlikely enough that this did not warrant a CVE.
      
      * daemon/remote.c (remoteDispatchConnectListAllDomains)
      (remoteDispatchDomainListAllSnapshots)
      (remoteDispatchDomainSnapshotListAllChildren)
      (remoteDispatchConnectListAllStoragePools)
      (remoteDispatchStoragePoolListAllVolumes)
      (remoteDispatchConnectListAllNetworks)
      (remoteDispatchConnectListAllInterfaces)
      (remoteDispatchConnectListAllNodeDevices)
      (remoteDispatchConnectListAllNWFilters)
      (remoteDispatchConnectListAllSecrets)
      (remoteDispatchNetworkGetDHCPLeases): Plug leak.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      (cherry picked from commit 3c2ff502)
      34538870
  4. 19 2月, 2015 1 次提交
  5. 17 2月, 2015 1 次提交
  6. 12 2月, 2015 3 次提交
    • P
      util: bitmap: Tolerate NULL bitmaps in virBitmapEqual · 0e1054a1
      Peter Krempa 提交于
      After virBitmapEqual is able to compare NULL bitmaps few bits of code
      can be cleaned up.
      
      (cherry picked from commit 20448c2a)
      Signed-off-by: NJán Tomko <jtomko@redhat.com>
      
      Partial backport without the cleanup.
      0e1054a1
    • D
      qemu: do upfront check for vcpupids being null when querying pinning · 1021df28
      Daniel P. Berrange 提交于
      The qemuDomainHelperGetVcpus attempted to report an error when the
      vcpupids info was NULL. Unfortunately earlier code would clamp the
      value of 'maxinfo' to 0 when nvcpupids was 0, so the error reporting
      would end up being skipped.
      
      This lead to 'virsh vcpuinfo <dom>' just returning an empty list
      instead of giving the user a clear error.
      
      (cherry picked from commit 9358b63a)
      1021df28
    • D
      qemu: fix setting of VM CPU affinity with TCG · b89978d5
      Daniel P. Berrange 提交于
      If a previous commit I fixed the incorrect handling of vcpu pids
      for TCG mode QEMU:
      
        commit b07f3d82
        Author: Daniel P. Berrange <berrange@redhat.com>
        Date:   Thu Dec 18 16:34:39 2014 +0000
      
          Don't setup fake CPU pids for old QEMU
      
          The code assumes that def->vcpus == nvcpupids, so when we setup
          fake CPU pids for old QEMU with nvcpupids == 1, we cause the
          later code to read off the end of the array. This has fun results
          like sche_setaffinity(0, ...) which changes libvirtd's own CPU
          affinity, or even better sched_setaffinity($RANDOM, ...) which
          changes the affinity of a random OS process.
      
      The intent was that this would merely disable the ability to set
      per-vCPU affinity. It should still have been possible to set VM
      level host CPU affinity.
      
      Unfortunately, when you set  <vcpu cpuset='0-1'>4</vcpu>, the XML
      parser will internally take this & initialize an entry in the
      def->cputune.vcpupin array for every VCPU. IOW this is implicitly
      being treated as
      
        <cputune>
          <vcpupin cpuset='0-1' vcpu='0'/>
          <vcpupin cpuset='0-1' vcpu='1'/>
          <vcpupin cpuset='0-1' vcpu='2'/>
          <vcpupin cpuset='0-1' vcpu='3'/>
        </cputune>
      
      Even more fun, the faked cputune elements are hidden from view when
      querying the live XML, because their cpuset mask is the same as the
      VM default cpumask.
      
      The upshot was that it was impossible to set VM level CPU affinity.
      
      To fix this we must update qemuProcessSetVcpuAffinities so that it
      only reports a fatal error if the per-VCPU cpu mask is different
      from the VM level cpu mask.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      (cherry picked from commit a103bb10)
      b89978d5
  7. 27 1月, 2015 2 次提交
  8. 26 1月, 2015 4 次提交
  9. 23 1月, 2015 18 次提交
    • R
      aarch64: Support versioned machine types. · ee4c13ce
      Richard W.M. Jones 提交于
      For distros that want to add versioned machine types, they will add
      (downstream) machine types like "virt-foo-1.2.3".  Detect these as
      MMIO too.
      Signed-off-by: NRichard W.M. Jones <rjones@redhat.com>
      ee4c13ce
    • E
      qemu: Add check for PCI bridge placement if there are too many PCI devices · b7e6f2fc
      Erik Skultety 提交于
      Previous patch of this series fixed the issue with adding a new PCI bridge
      when all the slots were reserved by devices with user specified addresses.
      In case there are still some PCI devices waiting to get a slot reserved
      by qemuAssignDevicePCISlots, this means a new bus needs to be
      created along with a corresponding bridge controller. By adding an
      additional check, this scenario now results in a reasonable error
      instead of generating wrong qemu command line.
      b7e6f2fc
    • E
      qemu: Fix auto-adding PCI bridge when all slots are reserved · 5d6904b9
      Erik Skultety 提交于
      Commit 93c8ca tried to fix the issue with auto-adding of a PCI bridge
      controller, but didn't work properly in all scenarios.
      
      This patch provides a better fix of the issue when all slots on a PCI bus
      are reserved by devices with user specified addresses and no additional
      bridges need to be created.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1132900
      5d6904b9
    • E
      qemu: move PCI slot assignment for PIIX3, Q35 into a separate function · a3ecd63e
      Erik Skultety 提交于
      In order to be able to test for fully reserved PCI buses, assignment of
      PCI slots for integrated devices needs to be moved to a separate function.
      This also might be a good preparation if we decide to add support for
      other chipsets as well.
      a3ecd63e
    • E
      qemu: reorder PCI slot assignment functions · 3fb2a692
      Erik Skultety 提交于
      Move qemuDomainAssignPCIAddresses after the definition
      of the static function qemuDomainValidateDevicePCISlotsQ35.
      
      This lets us define a new static function using
      qemuDomainValidateDevicePCISlots* and use it in
      qemuDomainAssignPCIAddresses without a forward declaration.
      Signed-off-by: NJán Tomko <jtomko@redhat.com>
      3fb2a692
    • P
      schemas: Move definition of 'hexuint' to basictypes · 6e01534b
      Peter Krempa 提交于
      Allow reuse of the type.
      6e01534b
    • P
      util: json: Make argument of virJSONValueArraySize const · 60e4e578
      Peter Krempa 提交于
      The function doesn't allow to modify the array in any way, thus the
      argument can be const.
      60e4e578
    • P
      qemu: command: Honor const-correctnes in qemuBuildNumaArgStr · 165c3477
      Peter Krempa 提交于
      @def is modified in the function indirectly although it's marked as
      const.
      165c3477
    • P
      conf: Fix comment mentioning actual type of @multi member of virDevicePCIAddress · f18f1183
      Peter Krempa 提交于
      After refactor to use the virTristateSwitch enum the comment in the
      struct was not adjusted.
      f18f1183
    • M
      Grant access to helpers · 338b07af
      Mike Latimer 提交于
      Apparmor must not prevent access to required helper programs. The following
      helpers should be allowed to run in unconfined execution mode:
      
       - libvirt_parthelper
       - libvirt_iohelper
      338b07af
    • M
      Fix apparmor issues for tck · c0273cd6
      Mike Latimer 提交于
      The network and nwfilter tests contained in the libvirt-TCK testkit can fail
      unless access to raw network packets is granted. Without this access, the
      following apparmor error can be seen while running the tests:
      
        apparmor="DENIED" operation="create" parent=1 profile="/usr/sbin/libvirtd"
        pid=94731 comm="libvirtd" family="packet" sock_type="raw" protocol=768
      c0273cd6
    • M
      Fix apparmor issues for Xen · b61fb8e8
      Mike Latimer 提交于
      In order for apparmor to work properly in Xen environments, the following
      access rights need to be allowed:
      
       - Allow CAP_SYS_PACCT, which is required when resetting some multi-port
         Broadcom cards by writting to the PCI config space
      
       - Allow CAP_IPC_LOCK, which is required to lock/unlock memory. Without
         this setting, an error 'Resource temporarily unavailable' can be seen
         while attempting to mmap memory. At the same time, the following
         apparmor message is seen:
      
         apparmor="DENIED" operation="capable" parent=1 profile="/usr/sbin/libvirtd"
         pid=2097 comm="libvirtd" pid=2097 comm="libvirtd" capability=14
         capname="ipc_lock"
      
       - Allow access to distribution specific directories:
           /usr/{lib,lib64}/xen/bin
      b61fb8e8
    • E
      conf: virDomainDefMaybeAddController tweak return code · 852cea52
      Erik Skultety 提交于
      Previously the function returned either -1 in case of an error or 0 on
      success. However, we should also distinguish between a case we
      successfully added a controller and a case there wasn't a need to add any
      controller
      852cea52
    • E
      qemu: Remove dead code in qemuDomainAssignPCIAddresses revert patch · 2fbfb3ac
      Erik Skultety 提交于
      As it turned out, fix of dead code 419a22 changed the affected condition
      from "never true" to "always true", so better fix would be to change the
      return code of virDomainMaybeAddController from 0 to 1 if
      a new bridge has been added, thus distinguishing case when we didn't need to
      add any controller and case we successfully added one.
      
      The return code is changed in the next commit
      2fbfb3ac
    • J
      Fix build with older gcc · d66e136b
      Ján Tomko 提交于
      My commit af1c98e4 broke the build on RHEL-6:
      vircgrouptest.c: In function 'testCgroupGetPercpuStats':
      vircgrouptest.c:566: error: nested extern declaration of
      '_gl_verify_function2' [-Wnested-externs]
      
      The only thing that needs checking is that the array size
      is at least EXPECTED_NCPUS, to prevent access beyond the array.
      
      We can ensure the minimum size also by specifying the array
      size upfront.
      d66e136b
    • P
      esx_vi: fix possible segfault · 3baeea62
      Pavel Hrdina 提交于
      Clang found possible dereference of NULL pointer which is right.
      Function 'esxVI_LookupTaskInfoByTask' should find a task info. The issue
      is that we could return 0 and leave 'taksInfo' pointer NULL because if
      there is no match we simply end the search loop end set 'result' to 0.
      Every caller count on the fact that if the return value is 0 than it's
      safe to dereference 'taskInfo'. We should return 0 only in case we found
      something and the '*taskInfo' is not NULL.
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      3baeea62
    • P
      xenapi_driver: fix copy-paste typo · 828e485b
      Pavel Hrdina 提交于
      Clang found that we are passing variable with wrong enum type to
      'xenapiCrashExitEnum2virDomainLifecycle' function. This is probably
      copy-paste typo as the correct variable exists in the code, but it isn't
      used.
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      828e485b
    • J
      Fix virCgroupGetPercpuStats with non-continuous present CPUs · af1c98e4
      Ján Tomko 提交于
      Per-cpu stats are only shown for present CPUs in the cgroups,
      but we were only parsing the largest CPU number from
      /sys/devices/system/cpu/present and looking for stats even for
      non-present CPUs.
      This resulted in:
      internal error: cpuacct parse error
      af1c98e4
  10. 22 1月, 2015 3 次提交
  11. 21 1月, 2015 2 次提交
    • J
      qemu: format server interface without a listen address · 280ece4a
      Ján Tomko 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1130390
      
      The listen address is not mandatory for <interface type='server'>
      but when it's not specified, we've been formatting it as:
      -netdev socket,listen=(null):5558,id=hostnet0
      which failed with:
      Device 'socket' could not be initialized
      
      Omit the address completely and only format the port in the listen
      attribute.
      
      Also fix the schema to allow specifying a model.
      280ece4a
    • J
      tests: fix xlconfigtest build failure · e274d588
      Jim Fehlig 提交于
      When libvirt is configured --without-xen, building the xlconfigtest
      fails with
      
        CCLD   xlconfigtest
        /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/crt1.o
        In function `_start': (.text+0x20): undefined reference to `main'
        collect2: error: ld returned 1 exit status
      
      Introduced in commit 4ed5fb91 by too much copy and paste from
      xmconfigtest.
      e274d588
  12. 20 1月, 2015 2 次提交
    • J
      Fix virCgroupNewMachine prototype on non-Linux · c803c070
      Ján Tomko 提交于
      Commit 318df5a0 changed the prototype of virCgroupNewMachine
      without adjusting the stub function for platforms without
      cgroups.
      c803c070
    • J
      network: Let domains be restricted to local DNS · 298fa485
      Josh Stone 提交于
      This adds a new "localOnly" attribute on the domain element of the
      network xml.  With this set to "yes", DNS requests under that domain
      will only be resolved by libvirt's dnsmasq, never forwarded upstream.
      
      This was how it worked before commit f69a6b98, and I found that
      functionality useful.  For example, I have my host's NetworkManager
      dnsmasq configured to forward that domain to libvirt's dnsmasq, so I can
      easily resolve guest names from outside.  But if libvirt's dnsmasq
      doesn't know a name and forwards it to the host, I'd get an endless
      forwarding loop.  Now I can set localOnly="yes" to prevent the loop.
      Signed-off-by: NJosh Stone <jistone@redhat.com>
      298fa485
  13. 19 1月, 2015 1 次提交
    • G
      Make ZFS storage pool XML tests optional · e11490e3
      Gary R Hook 提交于
      Do not run ZFS tests when ZFS is unsupported in the environment.
      
      The recent patch b4af4022 adds tests
      to storagepoolxml2xmltest for the optional ZFS feature. When ZFS is
      not included in the configuration these tests should not / cannot be
      run. Modify the test source file to check for use of the feature and
      compile in the tests accordingly.
      Signed-off-by: NGary R Hook <gary.hook@nimboxx.com>
      e11490e3