- 24 6月, 2016 39 次提交
-
-
由 Ján Tomko 提交于
Prefer virDirOpen.
-
由 Ján Tomko 提交于
Remove all the remaining usage of opendir.
-
由 Ján Tomko 提交于
A helper function that does not report any errors.
-
由 Ján Tomko 提交于
Use it instead of opendir everywhere we need to check for ENOENT.
-
由 Ján Tomko 提交于
Just like virDirOpen, but it returns 0 without reporting an error on ENOENT.
-
由 Ján Tomko 提交于
Switch from opendir to virDirOpen everywhere we need to report an error.
-
由 Ján Tomko 提交于
A helper that calls opendir and reports an error if it fails.
-
由 Cole Robinson 提交于
After commit e808d3f2 cbdata is always available here, so the check is pointless
-
由 Martin Kletzander 提交于
It may cause unwanted behaviour (of course, is there any wanted one for that case?) so we should rather disable the possibility of doing so. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1320893Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
-
由 Ján Tomko 提交于
Put the 'continue' statement on a separate line.
-
由 Andrea Bolognani 提交于
Unfortunately, we can't just call qemuDomainMachineIsPSeries() here, because we don't have a virDomainDef instance; that said, the open-coded check should match said function as closely as possible.
-
由 Andrea Bolognani 提交于
This new function checks for both the architecture and the machine type, so we can use it instead of writing the same checks over and over again.
-
由 Andrea Bolognani 提交于
Remove all external architecture checks that have been made redundant by this change.
-
由 Andrea Bolognani 提交于
Since we're already passing the full virDomainDef, it doesn't make sense to also pass def->os.arch and def->os.machine as separate arguments.
-
由 Martin Pietsch 提交于
-
由 Ján Tomko 提交于
Add SASL at the end to make the format obvious.
-
由 Ján Tomko 提交于
Add SASL at the end to make the format obvious.
-
由 Ján Tomko 提交于
Rename them to virNetSocket{Local,Remote}AddrStringSASL to make their format more obvious.
-
由 Ján Tomko 提交于
Make it more obvious that these are in the SASL format.
-
由 Ján Tomko 提交于
-
由 Ján Tomko 提交于
Use it in virNetServerClientGetInfo to switch back to using the URI-format (separated by ':') instead of the SASL format (separated by ';'). Also use it in the error message reported by virNetServerAddClient.
-
由 Ján Tomko 提交于
It will return the socket address and port in a URI-like format: [::1]:1234 Add a test case to virnetsockettest.
-
由 Ján Tomko 提交于
This partially reverts commit 9b45c9f0. It changed the default format of socket address from the one SASL requires, but did not adjust all the callers. It also removed the test coverage for it. Revert most of the changes except the virSocketAddrFormatFull support for URI-formatted strings. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1345743 while reverting the format used by virt-admin's client-info command from the URI one to the SASL one. https://bugzilla.redhat.com/show_bug.cgi?id=1345743
-
由 Ján Tomko 提交于
'.' and '..' are skipped by virDirRead already.
-
由 Ján Tomko 提交于
This fixes the disappearance of domains and networks starting with a dot. https://bugzilla.redhat.com/show_bug.cgi?id=1333248
-
由 Ján Tomko 提交于
The device names are unlikely to start with a dot. '.' and '..' are already skipped by virDirRead.
-
由 Ján Tomko 提交于
The directories we iterate over are unlikely to contain any entries starting with a dot, other than '.' and '..' which is already skipped by virDirRead.
-
由 Ján Tomko 提交于
'.' and '..' are now skipped by virDirRead, there's no need to mention them in the comment.
-
由 Ján Tomko 提交于
It skips those directory entries.
-
由 Ján Tomko 提交于
All of the callers either skip these explicitly, skip all entries starting with a dot or match the entry name against stricter patterns.
-
由 Ján Tomko 提交于
Introduce a helper that only calls closedir if DIR* is non-NULL and sets it to NULL afterwards.
-
由 Ján Tomko 提交于
The only possible error is EBADFD. Since we only use the directory stream returned by opendir, this should never happen.
-
由 Ján Tomko 提交于
The virUSBDeviceFind* callers do not check errno after calling this function.
-
由 Peter Krempa 提交于
In cases where we expect parse failure of the test input file the testsuite can't differentiate if the parser failed when parsing or when opening the file. Add a call to virFileExists and error out on missing input files. Missing output files are partially expected when regenerating test output.
-
由 Peter Krempa 提交于
Commit b1fc6a7b added a test file but used a different name in the actual test.
-
由 John Ferlan 提交于
Add 'encinfo' to the extended disk structure. This will contain the encryption secret (if present). Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Add utility to format the virSecretLookupTypeDefPtr in XML Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Move to virsecret.c and rename to virSecretLookupParseSecret. Also convert to usage xmlNodePtr and virXMLPropString rather than virXPathString. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Move the enum into a new src/util/virsecret.h, rename it to be virSecretLookupType. Add a src/util/virsecret.h in order to perform a couple of simple operations on the secret XML and virSecretLookupTypeDef for clearing and copying. This includes quite a bit of collateral damage, but the goal is to remove the "virStorage*" and replace with the virSecretLookupType so that it's easier to to add new lookups that aren't necessarily storage pool related. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
- 23 6月, 2016 1 次提交
-
-
由 Cole Robinson 提交于
Every driver provides a refreshPool impl, and many other critical places in the code unconditionally call it without checking if it exists, so this check is pointless
-