- 21 5月, 2010 14 次提交
-
-
由 Jim Meyering 提交于
* cfg.mk (msg_gen_function): Add VIR_ERROR and VIR_ERROR0, so that sc_libvirt_unmarked_diagnostics will check them, too.
-
由 Jim Meyering 提交于
These changes avoid false-positive syntax-check failure, and also make the resulting diagnostics more comprehensible.
-
由 Jim Meyering 提交于
-
由 Jim Meyering 提交于
Handle concatenated strings manually.
-
由 Jim Meyering 提交于
Run this: git grep -l 'VIR_ERROR\s*("'|xargs perl -pi -e \ 's/(VIR_ERROR)\s*\((".*?"),/$1(_($2),/'
-
由 Jim Meyering 提交于
Run this: git grep -l 'VIR_ERROR0\s*("'|xargs perl -pi -e \ 's/(VIR_ERROR0)\s*\((".*?")\)/$1(_($2))/'
-
由 Jim Meyering 提交于
Change VIR_ERROR("%s", "..." to VIR_ERROR0("..." and Change VIR_ERROR("%s", _("...") to VIR_ERROR0(_("...") Use this command: git grep -E -l 'VIR_ERROR\("%s", (_\()?"'|xargs perl -pi -e \ 's/VIR_ERROR\("%s", (_\()?"/VIR_ERROR0($1"/'
-
由 Chris Wright 提交于
* src/qemu/qemu_conf.c (qemudParseHelpStr): Fix errors that made it impossible to diagnose invalid minor and micro version number components. Signed-off-by: NChris Wright <chrisw@redhat.com>
-
由 Cole Robinson 提交于
Fedora bug https://bugzilla.redhat.com/show_bug.cgi?id=565238 - Avahi service is called 'avahi-daemon' - chkconfig descriptions must use \ for line continuations
-
由 Cole Robinson 提交于
The current cleanup: in StartVMDaemon path is a poor duplication. qemuShutdownVMDaemon can handle teardown for inactive VMs, so let's use it. v2: Remove old abort: label, only use cleanup:
-
由 Chris Lalancette 提交于
Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Chris Lalancette 提交于
This involved a few fixes. To start with, an virDomainSnapshot object is really tied to a domain, not a connection, so we have to generate a slightly different object so that we can get at self._dom for the object. Next, we had to "dummy" up an override piece of XML with a bogus argument that the function doesn't actually take. That's so that the generator places virDomainRevertToSnapshot underneath the correct class (namely, the virDomain class). Finally, we had to hand-implement the virDomainRevertToSnapshot implementation, ignoring the bogus pointer we are being passed. With all of this in place, I was able to successfully take a snapshot and revert to it using only the Python bindings. Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Jim Meyering 提交于
* src/qemu/qemu_conf.c (QEMU_VERSION_STR_1, QEMU_VERSION_STR_2): Define these instead of... (QEMU_VERSION_STR): ... this. Remove definition. (qemudParseHelpStr): Check first for the new, shorter prefix, "QEMU emulator version", and then for the old one, "QEMU PC emulator version" when trying to parse the version number. Based on a patch by Chris Wright.
-
由 Jim Meyering 提交于
* src/lxc/lxc_controller.c (ignorable_epoll_accept_errno): New function. (lxcControllerMain): Handle a failed accept carefully: most errno values indicate legitimate failure and must be fatal. However, ignore a special case: that in which an incoming client quits between the poll() indicating its presence, and our accept() which is trying to process it.
-
- 20 5月, 2010 13 次提交
-
-
由 Cole Robinson 提交于
Clients that require this already seem to do so. Calling this function with pid < 1 also should not cause problems.
-
由 Cole Robinson 提交于
This only exists for a certain cleanup path in StartVMDaemon, but is unneeded since domain_conf.c handles this for us automatically.
-
由 Cole Robinson 提交于
Everything after hostdev setup needs to jump to cleanup on error.
-
由 Jim Meyering 提交于
* daemon/libvirtd.c (main): Diagnose virInitialize failure and exit nonzero.
-
由 Alex Williamson 提交于
There doesn't seem to be anything specific to tap devices for this array of file descriptors which need to stay open of the guest to use. Rename then for others to make use of. Signed-off-by: NAlex Williamson <alex.williamson@redhat.com> Signed-off-by: NChris Lalancette <clalance@redhat.com>
-
由 Jim Meyering 提交于
* cfg.mk (sc_prohibit_newline_at_end_of_diagnostic): New rule. Idea proposed by Jiri Denemark.
-
由 Jim Meyering 提交于
* src/xen/xend_internal.c (xenDaemonDomainDefineXML): Remove \n. * src/network/bridge_driver.c (networkAddMasqueradingIptablesRules): Likewise.
-
由 Jim Meyering 提交于
* src/qemu/qemu_driver.c (qemudDomainMigrateFinish2): Don't ignore virDomainSaveStatus failure. * src/conf/domain_conf.h (virDomainSaveStatus): Use ATTRIBUTE_RETURN_CHECK, so this doesn't happen again.
-
由 Eric Blake 提交于
These files may be useful for anyone making modifications to source files in a tarball distribution. * src/Makefile.am (EXTRA_DIST): Add THREADS.txt. * daemon/Makefile.am (EXTRA_DIST): Add THREADING.txt.
-
由 Eric Blake 提交于
Commit f30ccb24 was incomplete. * .gitignore: Ignore intermediate directory during failed 'make distcheck'. * tests/Makefile.am (qemuhelpdata): Distribute new file.
-
由 Matthias Bolte 提交于
This will be used in the ESX storage driver in order to handle the DatastoreInfo type and inheriting types properly.
-
由 Matthias Bolte 提交于
This semantic will be used in the ESX storage driver.
-
由 Jim Meyering 提交于
This test was failing on systems using pdwtags from dwarves-1.3. Reported by Matthias Bolte. Two-pronged fix: - use --verbose to work also with dwarves-1.3; adapt regular expressions to handle now-varying separators - require a minimum number of post-split clauses, in order to skip upon any future format change. Currently there are 318; if there are 300 or fewer, give a warning similar to when pdwtags is missing. * src/Makefile.am (remote_protocol-structs): Use pdwtags' --verbose option to make 1.3 emit member sizes and offsets. Consistently output WARNING messages to stderr.
-
- 19 5月, 2010 13 次提交
-
-
由 Jim Meyering 提交于
Do not require each caller of virStorageFileGetMetadata and virStorageFileGetMetadataFromFD to first clear the storage of the "meta" buffer. Instead, initialize that storage in virStorageFileGetMetadataFromFD. * src/util/storage_file.c (virStorageFileGetMetadataFromFD): Clear "meta" here, not before each of the following callers. * src/qemu/qemu_driver.c (qemuSetupDiskCgroup): Don't clear "meta" here. (qemuTeardownDiskCgroup): Likewise. * src/qemu/qemu_security_dac.c (qemuSecurityDACSetSecurityImageLabel): Likewise. * src/security/security_selinux.c (SELinuxSetSecurityImageLabel): Likewise. * src/security/virt-aa-helper.c (get_files): Likewise.
-
由 Jim Meyering 提交于
* src/qemu/qemu_driver.c (qemuTeardownDiskCgroup): Remove bogus empty-body while-loop. (qemuSetupDiskCgroup): Likewise.
-
由 Jim Meyering 提交于
* po/POTFILES.in: Remove src/util/logging.c and src/util/uuid.c. * src/phyp/phyp_driver.c (phypUUIDTable_ReadFile): Correct more VIR_WARN uses, now manually. (phypUUIDTable_Init, phypUUIDTable_Pull): Likewise.
-
由 Jim Meyering 提交于
Run this command: git grep -l 'VIR_WARN("%s", "'|xargs perl -pi -e \ 's/VIR_WARN\("%s", "/VIR_WARN0("/' * src/phyp/phyp_driver.c (phypDomainGetInfo): Perform the above. (phypDomainCreateAndStart, phypUUIDTable_ReadFile): Likewise.
-
由 Jim Meyering 提交于
* cfg.mk (sc_prohibit_gettext_markup): New rule, to enforce this policy. Contrary to most diagnostic-emitting functions, where we require _(...) markup, here, we require that _() *not* be used for certain functions (or function-like macros).
-
由 Jim Meyering 提交于
* src/util/uuid.c (virUUIDGenerate): Remove _(...) manually.
-
由 Jim Meyering 提交于
Approximately 60 messages were marked. Since these diagnostics are intended solely for developers and maintainers, encouraging translation is deemed to be counterproductive: http://thread.gmane.org/gmane.comp.emulators.libvirt/25050/focus=25052 Run this command: git grep -l VIR_WARN|xargs perl -pi -e \ 's/(VIR_WARN0?)\s*\(_\((".*?")\)/$1($2/'
-
由 Jim Meyering 提交于
so that searches for properly spelled "TUNNELED" turn up the surprising spelling of this public symbol. * include/libvirt/libvirt.h.in: Add a comment.
-
由 Jiri Denemark 提交于
-
由 Jiri Denemark 提交于
-
由 Jim Meyering 提交于
There were three very similar uses of qemuMonitorAddDrive. This change makes the three 17-line sequences identical. * src/qemu/qemu_driver.c (qemudDomainAttachPciDiskDevice): Detect failure. Add VIR_WARN and braces. (qemudDomainAttachSCSIDisk): Add VIR_WARN and braces. (qemudDomainAttachUsbMassstorageDevice): Likewise.
-
由 Jim Meyering 提交于
* src/util/ebtables.c (ebtablesAddRemoveRule): Don't skip va_end(args) on an error path. * src/util/iptables.c (iptablesAddRemoveRule): Identical change.
-
由 Jim Meyering 提交于
* src/qemu/qemu_driver.c (qemudDomainRestore): Don't ignore virDomainSaveStatus failure.
-