1. 05 12月, 2017 3 次提交
  2. 04 12月, 2017 2 次提交
  3. 01 12月, 2017 10 次提交
    • J
      conf: Fix memory leak for distances in virDomainNumaFree · 9f0ccc71
      John Ferlan 提交于
      Commit id '74119a03' neglected to clean up @distances when
      the numa definition is cleaned up.
      9f0ccc71
    • J
      conf: Clean up virDomainNumaDefCPUFormatXML · ac6cc1d8
      John Ferlan 提交于
      Don't use a unary comparison for an int value - compare against zero
      directly instead.
      ac6cc1d8
    • J
      conf: Clean up virDomainNumaDefNodeDistanceParseXML · 742494ee
      John Ferlan 提交于
      Clean up the style a bit w/r/t to not using a unary operator on an
      integer value that could be zero - compare vs. zero instead.
      
      Set the def->mem_nodes[*].distances to rdist or ldist inside the
      if condition - no need to set outside since the value being set
      to is what was fetched.
      
      During cleanup, be sure to initialize the ndistances on error and
      use the < 0 comparison not the unary one.
      742494ee
    • M
      qemuStateInitialize: Don't leak @memoryBackingPath · 3eb84090
      Michal Privoznik 提交于
      ==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003
      ==899==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
      ==899==    by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)
      ==899==    by 0x55498D2: virVasprintfInternal (virstring.c:708)
      ==899==    by 0x55499E7: virAsprintfInternal (virstring.c:729)
      ==899==    by 0x2BECFFF0: qemuGetMemoryBackingBasePath (qemu_conf.c:1757)
      ==899==    by 0x2BF23225: qemuStateInitialize (qemu_driver.c:893)
      ==899==    by 0x563073D: virStateInitialize (libvirt.c:770)
      ==899==    by 0x124CC4: daemonRunStateInit (libvirtd.c:834)
      ==899==    by 0x55521CD: virThreadHelper (virthread.c:206)
      ==899==    by 0x88D9686: start_thread (in /lib64/libpthread-2.25.so)
      ==899==    by 0x8BEAEFE: clone (in /lib64/libc-2.25.so)
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      3eb84090
    • M
      virDomainDiskBackingStoreParse: Don't leak @idx · 0fd85b98
      Michal Privoznik 提交于
      ==1277== 8 bytes in 4 blocks are definitely lost in loss record 39 of 131
      ==1277==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
      ==1277==    by 0x68BBBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
      ==1277==    by 0x53B1DC2: virXMLPropString (virxml.c:510)
      ==1277==    by 0x53D696A: virDomainDiskBackingStoreParse (domain_conf.c:8639)
      ==1277==    by 0x53DA684: virDomainDiskDefParseXML (domain_conf.c:9590)
      ==1277==    by 0x53F619F: virDomainDefParseXML (domain_conf.c:19233)
      ==1277==    by 0x53F96EE: virDomainDefParseNode (domain_conf.c:20083)
      ==1277==    by 0x53F9540: virDomainDefParse (domain_conf.c:20027)
      ==1277==    by 0x53F95E6: virDomainDefParseFile (domain_conf.c:20053)
      ==1277==    by 0x44D1D4: testCompareDomXML2XMLFiles (testutils.c:1265)
      ==1277==    by 0x42FC7C: testXML2XMLActive (qemuxml2xmltest.c:71)
      ==1277==    by 0x44AD20: virTestRun (testutils.c:180)
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      0fd85b98
    • M
      virDomainDiskSourceNetworkParse: Don't leak @tlsCfg or @haveTLS · 7d7c01b4
      Michal Privoznik 提交于
      ==861== 3 bytes in 1 blocks are definitely lost in loss record 3 of 168
      ==861==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
      ==861==    by 0x8C7FBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
      ==861==    by 0x5DCCDC2: virXMLPropString (virxml.c:510)
      ==861==    by 0x5DF1232: virDomainDiskSourceNetworkParse (domain_conf.c:8445)
      ==861==    by 0x5DF1728: virDomainDiskSourceParse (domain_conf.c:8576)
      ==861==    by 0x5DF41A5: virDomainDiskDefParseXML (domain_conf.c:9238)
      ==861==    by 0x5E1119F: virDomainDefParseXML (domain_conf.c:19233)
      ==861==    by 0x5E146EE: virDomainDefParseNode (domain_conf.c:20083)
      ==861==    by 0x5E14540: virDomainDefParse (domain_conf.c:20027)
      ==861==    by 0x5E145E6: virDomainDefParseFile (domain_conf.c:20053)
      ==861==    by 0x4053CC: testCompareXMLToArgv (qemuxml2argvtest.c:455)
      ==861==    by 0x41F135: virTestRun (testutils.c:180)
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      7d7c01b4
    • P
      qemu: domain: Fix backing store terminator for non-backing local files · adcc31bb
      Peter Krempa 提交于
      Raw local files do not pass through the backing store detector and thus
      the code did not allocate the required backing store terminator for
      them. Previously the terminating element would be formatted into the XML
      since the default values used for the metadata allowed that. This is a
      regression since a693fdba which was not detected in the review.
      
      This patch also reverts all the changes in the test files.
      adcc31bb
    • P
      qemu: process: Move handling of non-backing files into qemuDomainDetermineDiskChain · 24e47ee2
      Peter Krempa 提交于
      Until now we would skip loading of the backing chain for files which
      don't support backing chains only when starting up the VM. Move the
      check from qemuProcessPrepareHostStorage with some adaptations so that's
      always applied.
      24e47ee2
    • P
      qemu: domain: Refactor control flow in qemuDomainDetermineDiskChain · b19710b9
      Peter Krempa 提交于
      Split out clearing of the backing chain prior to other code since it
      will be required later and optimize few layers of nested conditions and
      loops.
      b19710b9
    • P
      conf: fix migratable XML for graphics if socket is generated based on config · cb06ea57
      Pavel Hrdina 提交于
      The graphics code is complex and there are a lot of exceptions and
      backward compatible combinations.  One of them is the possibility
      to configure "spice_auto_unix_socket" in qemu.conf which will convert
      all spice graphics with listen type "address" without any address
      specified to listen type "socket" when the guest is started.
      
      We don't format this generated socket into migratable XML to make
      migration work with older libvirt.  However, spice has another
      exception that if autoport='no' and there is no port configured
      it is converted to listen type "none".  Because of this we need
      to format autoport='yes' to make sure that the listen type will
      be the same as the offline XML.
      
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511407Reviewed-by: NJiri Denemark <jdenemar@redhat.com>
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      cb06ea57
  4. 30 11月, 2017 9 次提交
  5. 28 11月, 2017 16 次提交