1. 28 2月, 2008 4 次提交
  2. 27 2月, 2008 6 次提交
  3. 26 2月, 2008 2 次提交
  4. 25 2月, 2008 2 次提交
    • D
      fix compilation against static libraries · 9b1cd481
      Daniel Veillard 提交于
      * src/Makefile.am src/util-lib.h: fix done with Jim to allow
        compilation of virsh with the static libraries.
      Daniel
      9b1cd481
    • J
      Avoid new "make syntax-check" failures. · e497deb8
      Jim Meyering 提交于
      * .x-sc_avoid_write: Exempt src/util-lib.c, too.
      * Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
      * src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
      Use safewrite, not write.
      * src/storage_backend_logical.c (virStorageBackendLogicalBuildPool): Likewise.
      e497deb8
  5. 23 2月, 2008 1 次提交
    • J
      avoid format string warnings · b1b23f76
      Jim Meyering 提交于
      Avoid warnings like this:
      file:nnn:format not a string literal and no format arguments
      
      * qemud/qemud.c: Insert a "%s" format argument.
      * qemud/remote.c: Likewise.
      * src/iptables.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/storage_backend.c: Likewise.
      * src/storage_backend_fs.c: Likewise.
      * src/storage_backend_iscsi.c Likewise.
      * src/storage_backend_logical.c: Likewise.
      * src/storage_conf.c: Likewise.
      * src/storage_driver.c: Likewise.
      b1b23f76
  6. 22 2月, 2008 6 次提交
    • J
      Use safewrite in place of write, in many cases. · b59d9c85
      Jim Meyering 提交于
      Also add "make syntax-check" rules to ensure no new uses sneak in.
      
      There are many uses of write like this:
      
          if (write (fd, xml, towrite) != towrite)
              return -1;
      
      The problem is that the syscall can succeed, yet write less than
      the requested number of bytes, so the caller should retry
      rather than simply failing.
      
      This patch changes most of them to use util.c's safewrite wrapper,
      which encapsulates the process.  Also, there were a few cases in
      which the retry loop was open-coded, and I replaced those, too.
      
      * Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
      * .x-sc_avoid_write: New file.  Record two legitimate exemptions.
      * qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
      * src/conf.c (__virConfWriteFile): Likewise.
      * src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
      * src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
      (qemudVMData, PROC_IP_FORWARD): Likewise.
      * proxy/libvirt_proxy.c: Include "util.h".
      (proxyWriteClientSocket): Use safewrite.
      * src/test.c (testDomainSave, testDomainCoreDump): Likewise.
      * src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
      * src/virsh.c: Include "util-lib.h".
      (vshOutputLogFile): Use safewrite.
      * src/console.c: Include "util-lib.h".
      (vshRunConsole): Use safewrite.
      b59d9c85
    • J
      Move safewrite and saferead to a separate file. · a178a4e7
      Jim Meyering 提交于
      We currently use safewrite from inside libvirt and don't want to publish
      any such function name.  However, we do want to use it in applications
      like virsh, libvirtd and libvirt_proxy that link with libvirt.  To that
      end, this change moves that function definition (along with the nearly
      identical saferead) into a new file, util-lib.c.  To avoid maintaining
      separate copies of even such small functions, we simply include that new
      file from util.c.  Then, the separate applications that need to use
      safewrite simply compile and link with util-lib.c.
      
      Of course, this does mean that each of those applications will
      containing two copies of these functions.  However, the functions
      are so small that it's not worth worrying about that.
      
      * src/util.c (saferead, safewrite): Move function definitions to
      util-lib.c and include that .c file.
      * src/util-lib.c (saferead, safewrite): New file.  Functions from src/util.c
      with slight change (s/int r =/ssize_t r =/) to reflect read/write return type.
      * src/util-lib.h: Declare the two moved functions.
      * src/util.h: Remove declarations.  Include src/util-lib.h.
      * proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c.
      * qemud/Makefile.am (libvirtd_SOURCES): Likewise.
      * src/Makefile.am (virsh_SOURCES): Add util-lib.c.  Remove some SP-before-TAB.
      a178a4e7
    • J
      With --enable-iptables-lokkit=no, avoid warning about unused parameter. · 6187c6de
      Jim Meyering 提交于
      * src/iptables.c (iptRulesSave) [!ENABLE_IPTABLES_LOKKIT]:
      Mark parameter as used.
      6187c6de
    • J
      With --without-xen, avoid warning about unused function. · bdbce64b
      Jim Meyering 提交于
      * tests/statstest.c (testQuietError) [!WITH_XEN]: Don't define.
      bdbce64b
    • J
      Rewrite openvzSetUUID. · 9bcade46
      Jim Meyering 提交于
      * src/openvz_conf.c (openvzSetUUID): Rewrite to avoid unchecked
      lseek, write, and close as well as a potential file descriptor leak.
      9bcade46
    • J
      Handle failed openvzLocateConfDir. · 5fc07cd8
      Jim Meyering 提交于
      * src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID):
      (openvzSetUUID): Don't dereference NULL upon failure.
      5fc07cd8
  7. 21 2月, 2008 5 次提交
  8. 20 2月, 2008 14 次提交