1. 09 12月, 2015 31 次提交
  2. 08 12月, 2015 7 次提交
    • J
      Revert "libxl: implement virDomainInterfaceStats" · e4ac5919
      Jim Fehlig 提交于
      This reverts commit d2e5538b.
      
      A migration regression was introduced by this commit. When migrating
      a domain, its active XML is sent to the destination libvirtd, where
      it is parsed as inactive XML. d2e5538b copied the libxl generated
      interface name into the active config, which was being passed to the
      migration destination and being parsed into inactive config. Attempting
      to start the config could result in failure if an interface with the
      same generated name already exists.
      
      The qemu driver behaves similarly, but the parser contains a hack to
      skip interface names starting with 'vnet' when parsing inactive XML.
      We could extend the hack to skip names starting with 'vif' too, but a
      better fix would be to expose these hypervisor-specific interface name
      prefixes in capabilities. See the following discussion thread for more
      details
      
      https://www.redhat.com/archives/libvir-list/2015-December/msg00262.html
      
      For the pending 1.3.0 release, it is best to revert d2e5538b. It can
      be added again post release, after moving the prefix to capabilities.
      e4ac5919
    • D
      rpm: explicitly enable & start virtlogd on install · da054f35
      Daniel P. Berrange 提交于
      When installing the libvirt-daemon RPM, we have a %post rule to
      enable the libvirtd.service, virtlockd.socket and virtlogd.socket
      files. This is only done, however, when the RPM is first installed,
      not when upgrading RPMs. So virtlogd will not get activated on
      upgrading, which is a problem as libvirt qemu driver will expect
      it to be available by default.
      
      This adds a trigger that is run when uninstalling libvirt-daemon
      older than 1.3.0 that will enable & start virtlogd.socket if
      libvirtd is enabled and/or started. Using the trigger rather
      than %post ensures that it only runs once, allowing admins to
      disable it explicitly thereafter without future upgrades
      re-enabling it.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      da054f35
    • D
      libvirtd: enable virtlockd/virtlogd socket activation on install · 5cce775e
      Daniel P. Berrange 提交于
      When someone does 'systemctl enable libvirtd.service' we should
      also enable virtlockd.socket/virtlogd.socket, so that they can
      be auto-activated if libvirtd tries to access the sockets.
      
      Without this, people have to manually enable the units themselves
      via 'systemctl enable virtdlogd.socket'.
      
      This also ensures that if distros uses  'systemctl preset' for
      enabling 'libvirtd.service', then the virtdlogd.socket gets
      enabled without having to wait for the distro to update their
      presets file.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      5cce775e
    • D
      logging: validate flags passed from client in virtlogd · b6cbabc5
      Daniel P. Berrange 提交于
      The virtlogd RPC messages all have a flags parameter. For
      sake of future error reporting we should be verifying
      these are all 0 for now.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      b6cbabc5
    • D
      logging: change log protocol to be more reusable · 50896b28
      Daniel P. Berrange 提交于
      The current virtlogd RPC protocol provides the ability to
      handle log files associated with QEMU stdout/err. The log
      protocol messages take the virt driver, domain name and
      use that to form a log file path. This is quite restrictive
      as it prevents us re-using the same RPC protocol messages
      for logging to char device backends where the filename
      can be arbitrarily user specified. It is also bad because
      it means we have 2 separate locations which have to decide
      on logfile name.
      
      This change alters the RPC protocol so that we pass the
      desired log file path along when opening the log file
      initially. Now the virt driver is exclusively in charge
      of deciding the log filename
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      50896b28
    • D
      logging: preserve driver, dom name & uuid against log file · d4abb09d
      Daniel P. Berrange 提交于
      The virt driver, dom name and uuid associated with a log
      file are important pieces of metadata to keep around for
      sake of future enhancements to virtlogd. Currently we
      discard them after opening the log file, but we should
      preserve them, even across restarts.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      d4abb09d
    • D
      qemu: fix memory leak in opening log file · 0eafe995
      Daniel P. Berrange 提交于
      The qemuDomainLogContextNew method leaks the "logfile" path
      on the non-virtlogd code path.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      0eafe995
  3. 05 12月, 2015 2 次提交