1. 27 7月, 2015 1 次提交
  2. 22 7月, 2015 1 次提交
    • A
      tests: Restore links in deconfigured-cpus nodeinfo test · cc3d52eb
      Andrea Bolognani 提交于
      When cleaning up the data (taken from a running system) for inclusion
      I went a little too far and deleted a bunch of links that should have
      been left alone. The test worked despite this because it was going
      through a fallback code path.
      
      A few other files are affected as well: again, the data is taken from
      a running system, so even thought we would probably be okay if we
      just added the links, aligning everything is definitely safer.
      cc3d52eb
  3. 14 7月, 2015 1 次提交
    • A
      tests: Add nodeinfo test for non-present CPUs · f8b784a8
      Andrea Bolognani 提交于
      Some of the possible CPUs in a system might not be present, eg. they
      might be defective or might have been deconfigured from the ASM console
      in a Power system. Due to this fact, Linux keeps track of what CPUs are
      possible and what are present separately.
      
      This test uses the data from a system where not all the possible CPUs
      are present to make sure libvirt handles this situation correctly.
      f8b784a8
  4. 02 4月, 2015 1 次提交
    • M
      nodeinfodata: Remove broken symlinks and uneeded files · 184a927a
      Michal Privoznik 提交于
      The 7c3c7f21 and f5c2d6 commits introduced a nodeinfo test.
      In order to do that, some parts of sysfs had to be copied.
      However, sysfs is full of symlinks, so during copying some
      symlinks broke. Remove them, as on different systems they can
      point to different files or be broken. At the same time, we don't
      need all files added in those commits. For instance we don't care
      about 'uevent' files, 'power' folders, and others.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      184a927a
  5. 01 4月, 2015 2 次提交
  6. 20 6月, 2014 2 次提交
  7. 06 6月, 2014 1 次提交
  8. 27 1月, 2014 1 次提交
  9. 13 11月, 2012 2 次提交
    • P
      nodeinfotest: Add test data from a AMD bulldozer machine. · 7a791677
      Peter Krempa 提交于
      The AMD Bulldozer architecture uses so called "Clustered integer core
      modules" that count both as threads and cores. This patch expects the
      cpu to be detected using the new fallback condition otherwise twice the
      number of processors would be detected.
      7a791677
    • P
      nodeinfotest: Add test data for 2 processor host with broken NUMA · 86748976
      Peter Krempa 提交于
      This test data was gathered on an AMD MagnyCours machine that reports it
      has only one NUMA node although the hardware is consisting of 4. As
      duplicate core id's are ignored the reported topology was bogous. This
      should be fixed by the previous patch.
      
      Reported and data provided by George-Cristian Bîrzan.
      86748976
  10. 30 10月, 2012 1 次提交
  11. 21 7月, 2012 1 次提交
    • E
      tests: reduce length of nodeinfodata test names · df80282d
      Eric Blake 提交于
      Commit ddd6bef4 switched to the ustar format to fix an issue where
      'make dist' fails to create a tarball because we have files with
      relative names longer than 100 bytes by the time you include a
      'libvirt-0.9.13' prefix.  Unfortunately, even with ustar format,
      the use of 'tar -ch' tries to convert symlinks to hard links,
      also with a name too long (omitting the -h works, but automake
      automatically passes -h); such symlinks were added in commit
      6dcf98c8, which resulted in 'make dist' breaking again.  The
      solution is to rename the offending symlinks to something shorter,
      by shortening the entire nodeinfodata naming scheme.
      
      * tests/nodeinfotest.c (mymain): Shorten test names.
      (linuxTestNodeInfo): Accommodate new names.
      * tests/nodeinfodata/*: Rename files accordingly.
      df80282d
  12. 19 7月, 2012 1 次提交
    • E
      nodeinfo: deal with offline cpus in a node · 03e0ec10
      Eric Blake 提交于
      Commit 80533ca2 forgot to think about offline cpus.  When a node
      cpu is offline, then its topology/ subdirectory is not present,
      leading to spurious error messages leaked to the user such as:
      
      libvir:  error : cannot open /home/dummy/libvirt/tests/nodeinfodata/linux-nodeinfo-sysfs-test-6/node/node0/cpu7/topology/physical_package_id: No such file or directory
      
      Fix that, as well as test it; the test data is gathered from a
      machine with one NUMA node, hyperthreading, and with 2 of the
      8 cpus offline.
      
      * src/nodeinfo.c (virNodeParseNode): Don't parse topology of
      offline cpus.
      * tests/nodeinfotest.c (mymain): Run new test.
      * tests/nodeinfodata/linux-nodeinfo-sysfs-test-6*: New data.
      03e0ec10
  13. 11 7月, 2012 4 次提交
    • P
      test: Add test case for nodeinfotest if host machine doesn't have NUMA · 7ea1dd93
      Peter Krempa 提交于
      Test filling of nodeinfo structure if /sys/devices/system/node does not
      exist. (Based on dump from a real machine)
      7ea1dd93
    • P
      test: Add new test case for nodeinfotest · 1aa1a45b
      Peter Krempa 提交于
      This patch adds test data that describe a machine that has two physical
      processors that don't share same core id's on their cores. On this data
      the "virsh nodeinfo" reported that the machine had 10 cores per socket
      while the processor had only 8. (Before fixing nodeinfo gathering code).
      1aa1a45b
    • P
      nodeinfo: Fix gathering of nodeinfo data structure · 80533ca2
      Peter Krempa 提交于
      This patch changes the way data to fill the nodeinfo structure are
      gathered. We've gathere the test data by iterating processors an sockets
      separately from nodes. The reported data was based solely on information
      about core id. Problems arise when eg cores in mulit-processor machines
      don't have same id's on both processors or maybe one physical processor
      contains more NUMA nodes.
      
      This patch changes the approach how we detect processors and nodes. Now
      we start at enumerating nodes and for each node processors, sockets and
      threads are enumerated separately. This approach provides acurate data
      that comply to docs about the nodeinfo structure. This also enables to
      get rid of hacks: see commits 10d9038b,
      ac9dd4a6. (Those changes in nodeinfo.c
      are efectively reverted by this patch).
      
      This patch also changes output of one of the tests, as the processor
      topology is now acquired more precisely.
      80533ca2
    • P
      nodeinfo_test: Enhance test data before changing nodeinfo gathering · 6dcf98c8
      Peter Krempa 提交于
      This patch adds test data needed by the new way node information will be
      gathered. This patch adds symlinks to cpu cores to their corresponding
      node directory.
      6dcf98c8
  14. 17 5月, 2012 1 次提交
    • E
      nodeinfo: test more details · 5a8262a0
      Eric Blake 提交于
      Make it obvious why we need Osier's patch in commit 10d9038b
      to fix NUMA parsing of an AMD machine with two cores sharing
      a socket id.
      
      * tests/nodeinfotest.c (linuxTestCompareFiles): Enhance the test.
      * tests/nodeinfodata/linux-nodeinfo-sysfs-test-*-output.txt: Update.
      5a8262a0
  15. 15 5月, 2012 2 次提交
    • O
      nodeinfo: Get the correct CPU number on AMD Magny Cours platform · 10d9038b
      Osier Yang 提交于
      "Instead of developing one CPU with 12 cores, the Magny Cours is
      actually two 6 core “Bulldozer” CPUs combined in to one package"
      
      I.e, each package has two NUMA nodes, and the two numa nodes share
      the same core ID set (0-6), which means parsing the cores number
      from sysfs doesn't work in this case.
      
      And the wrong CPU number could cause three problems for libvirt:
      
      1) performance lost
      
        A domain without "cpuset" or "placement='auto'" (to drive numad)
      specified will be only pinned to part of the CPUs.
      
      2) domain can be started
      
        If a domain uses numad, and the advisory nodeset returned from
      numad contains node which exceeds the range of wrong total CPU
      number. The domain will fail to start, as the bitmask passed to
      sched_setaffinity could be fully filled with zero.
      
      3) wrong CPU number affects lots of stuffs.
      
        E.g. for command "virsh vcpuinfo", "virsh vcpupin", it will always
      output with the truncated CPU list.
      
      For more details:
      
      https://www.redhat.com/archives/libvir-list/2012-May/msg00607.html
      
      This patch is to fix the problem by parsing /proc/cpuinfo to get
      the value of field "cpu cores", and use it as nodeinfo->cores if
      it's greater than the cores number from sysfs.
      10d9038b
    • E
      nodeinfo: add some more tests · 891a7f9e
      Eric Blake 提交于
      Test 2 data grabbed from a 2-core 1-node laptop.
      Test 3 data grabbed from a 48-cpu AMD Magny Cours box.
      
      * tests/nodeinfodata/linux-nodeinfo-sysfs-test-2*: New test data.
      * tests/nodeinfodata/linux-nodeinfo-sysfs-test-3*: Likewise.
      * tests/nodeinfotest.c (mymain): Run them.
      * cfg.mk
      (exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF): Exempt
      new test files.
      891a7f9e
  16. 08 12月, 2011 1 次提交
  17. 08 3月, 2010 1 次提交
    • C
      Get thread and socket information in virsh nodeinfo. · aa2f6f96
      Chris Lalancette 提交于
      The current code for "nodeinfo" is pretty naive
      about socket and thread information.  To determine the
      sockets, it just takes the number of cpus and divides
      by the number of cores.  For the thread count, it always
      sets it to 1.  With more recent Intel machines, however,
      hyperthreading is again an option, meaning that these
      heuristics no longer work and give bogus numbers.  This
      patch goes through /sys to get the additional
      information so we properly report it.
      
      Note that I had to edit the tests not to report on
      socket and thread counts, since these are determined
      dynamically now.
      
      v2: As pointed out by Eric Blake, gnulib provides
          count-one-bits (which is LGPLv2+).  Use it instead
          of a hand-coded popcnt.
      Signed-off-by: NChris Lalancette <clalance@redhat.com>
      aa2f6f96
  18. 16 7月, 2009 1 次提交
    • J
      remove all trailing blank lines · 07613d20
      Jim Meyering 提交于
      by running this command:
      git ls-files -z | xargs -0 perl -pi -0777 -e 's/\n\n+$/\n/'
      This is in preparation for a more strict make syntax-check
      rule that will detect trailing blank lines.
      07613d20
  19. 06 12月, 2007 1 次提交
    • J
      Use gnulib, starting with its physmem and getaddrinfo modules. · 261e7581
      Jim Meyering 提交于
      New files go into these directories:
        gnulib/lib
        gnulib/m4
        gnulib/tests
      
      * bootstrap: A wrapper around gnulib-tool.
      * configure.in: Invoke gl_EARLY and gl_INIT, being careful to put gl_EARLY
      before any macro that uses AC_COMPILE_IFELSE.
      (AC_OUTPUT): Add lib/Makefile and gl-tests/Makefile.  Remove m4/Makefile.
      * Makefile.am (SUBDIRS): Add gnulib/lib and remove m4.  Add gnulib/tests
      early enough that those tests run before any libvirt unit tests.
      * m4/Makefile.am: Remove file.  Not needed.
      * src/Makefile.am (INCLUDES): Add -I$(top_srcdir)/gnulib/lib -I../gnulib/lib.
      (LDADDS, libvirt_la_LIBADD): Add ../gnulib/lib/libgnu.la.
      * src/nodeinfo.c: Include "physmem.h".
      * qemud/qemud.c, src/remote_internal.c: Include "getaddrinfo.h".
      (MEMINFO_PATH, linuxNodeInfoMemPopulate): Remove definitions.
      (virNodeInfoPopulate): Use physmem_total, not linuxNodeInfoMemPopulate.
      * tests/Makefile.am (INCLUDES): Add -I$(top_srcdir)/gnulib/lib -I../gnulib/lib.
      (LDADDS): Add ../gnulib/lib/libgnu.la.
      * qemud/Makefile.am (libvirtd_LDADD): Add ../gnulib/lib/libgnu.la.
      * tests/nodeinfotest.c (linuxTestCompareFiles): No longer read total
      memory from a file.
      Update expected output not to include "Memory: NNNN"
      * tests/nodeinfodata/linux-nodeinfo-1.txt:
      * tests/nodeinfodata/linux-nodeinfo-2.txt:
      * tests/nodeinfodata/linux-nodeinfo-3.txt:
      * tests/nodeinfodata/linux-nodeinfo-4.txt:
      * tests/nodeinfodata/linux-nodeinfo-5.txt:
      * tests/nodeinfodata/linux-nodeinfo-6.txt:
      * src/test.c [WITH_TEST]: Remove definition of _GNU_SOURCE that
      would conflict with the one now in "config.h".
      * autogen.sh: Add -I gnulib/m4.
      * src/conf.c, src/sexpr.c: Don't define _GNU_SOURCE.
      Instead, include "config.h".
      * qemud/qemud.c: Remove definition of _GNU_SOURCE.
      * src/openvz_driver.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/remote_internal.c: Likewise.
      
      * configure.in: Use AC_CONFIG_AUX_DIR(build-aux), so that a bunch
      of gettextize-generated files go into build-aux/, rather than in
      the top-level directory.
      * .cvsignore: Adjust.
      * build-aux/.cvsignore: New file.
      
      
      Author: Jim Meyering <meyering@redhat.com>
      261e7581
  20. 26 7月, 2007 1 次提交