1. 04 11月, 2017 1 次提交
  2. 20 10月, 2017 2 次提交
    • J
      conf: Add/Allow parsing the encryption in the disk source · 37537a7c
      John Ferlan 提交于
      Since the virStorageEncryptionPtr encryption; is a member of
       _virStorageSource it really should be allowed to be a subelement
      of the disk <source> for various disk formats:
      
         Source{File|Dir|Block|Volume}
         SourceProtocol{RBD|ISCSI|NBD|Gluster|Simple|HTTP}
      
      NB: Simple includes sheepdog, ftp, ftps, tftp
      
      That way we can set up to allow the <encryption> element to be
      formatted within the disk source, but we still need to be wary
      from whence the element was read - see keep track and when it
      comes to format the data, ensure it's written in the correct place.
      
      Modify the qemuxml2argvtest to add a parse failure when there is an
      <encryption> as a child of <disk> *and* an <encryption> as a child
      of <source>.
      
      The virschematest will read the new test files and validate from a
      RNG viewpoint things are fine.
      37537a7c
    • J
      conf: Add/Allow parsing the auth in the disk source · 8002d3cb
      John Ferlan 提交于
      Since the virStorageAuthDefPtr auth; is a member of _virStorageSource
      it really should be allowed to be a subelement of the disk <source>
      for the RBD and iSCSI prototcols. That way we can set up to allow
      the <auth> element to be formatted within the disk source.
      
      Since we've allowed the <auth> to be a child of <disk>, we'll need
      to keep track of how it was read so that when writing out we'll know
      whether to format as child of <disk> or <source>. For the argv2xml
      parsing, let's format under <source> as a preference. Do not allow
      <auth> to be both a child of <disk> and <source>.
      
      Modify the qemuxml2argvtest to add a parse failure when there is an
      <auth> as a child of <disk> *and* an <auth> as a child of <source>.
      
      Add tests to validate that if the <auth> was found in <source>, then
      the resulting xml2xml and xml2arg works just fine.  The two new .args
      file are exact copies of the non "-source" version of the file.
      
      The virschematest will read the new test files and validate from a
      RNG viewpoint things are fine
      
      Update the virstoragefile, virstoragetest, and args2xml file to show
      the "preference" to place <auth> as a child of <source>.
      8002d3cb
  3. 17 10月, 2017 1 次提交
  4. 05 10月, 2017 1 次提交
    • J
      docs,rng: Adjust storage pool name grammar checks · 5d765902
      John Ferlan 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1475250
      
      It's possible to define and start a pool with a '.' in the
      name; however, when trying to add a volume to a domain using
      the storage pool source with a '.' in the storage pool name,
      the domain RNG validation fails because RNG uses 'genericName'
      which does not allow a '.' in the name.
      
      Domain XML def parsing has a virXMLValidateAgainstSchema which
      generates the error. The Storage Pool XML def parsing has no
      call to virXMLValidateAgainstSchema. The only Storage Pool name
      validation occurs in virStoragePoolDefParseXML to ensure the
      name doesn't have a '/' in it and in storagePoolDefineXML to
      call virXMLCheckIllegalChars using the same parameter "\n" as
      qemuDomainDefineXMLFlags would check after the RNG check
      could be succesful.
      
      In order to resolve this, create a poolName definition in
      storagecommon.rng that will mimic the domain name regex that
      disallows a newline character, but add the "/" in the exclude
      list. Then modify the pool and volume source name definitions
      to key off that poolName.
      5d765902
  5. 04 10月, 2017 1 次提交
    • L
      qemu: Support multiqueue virtio-blk · abca72fa
      Lin Ma 提交于
      qemu 2.7.0 introduces multiqueue virtio-blk(commit 2f27059).
      This patch introduces a new attribute "queues". An example of
      the XML:
      
      <disk type='file' device='disk'>
        <driver name='qemu' type='qcow2' queues='4'/>
      
      The corresponding QEMU command line:
      
      -device virtio-blk-pci,scsi=off,num-queues=4,id=virtio-disk0
      Signed-off-by: NLin Ma <lma@suse.com>
      Signed-off-by: NJán Tomko <jtomko@redhat.com>
      abca72fa
  6. 28 9月, 2017 1 次提交
    • A
      util: Add TLS attributes to virStorageSource · f1705485
      Ashish Mittal 提交于
      Add an optional virTristateBool haveTLS to virStorageSource to
      manage whether a storage source will be using TLS.
      
      Sample XML for a VxHS disk:
      
      <disk type='network' device='disk'>
        <driver name='qemu' type='raw' cache='none'/>
        <source protocol='vxhs' name='eb90327c-8302-4725-9e1b-4e85ed4dc251' tls='yes'>
          <host name='192.168.0.1' port='9999'/>
        </source>
        <target dev='vda' bus='virtio'/>
      </disk>
      
      Additionally add a tlsFromConfig boolean to control whether the TLS
      setting was due to domain configuration or qemu.conf global setting
      in order to decide whether to Format the haveTLS setting for either
      a live or saved domain configuration file.
      
      Update the qemuxml2xmltest in order to add a test to show the proper
      parsing.
      
      Also update the docs to describe the tls attribute.
      Signed-off-by: NAshish Mittal <Ashish.Mittal@veritas.com>
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      f1705485
  7. 27 9月, 2017 1 次提交
  8. 20 9月, 2017 2 次提交
  9. 12 9月, 2017 2 次提交
  10. 29 8月, 2017 1 次提交
  11. 02 8月, 2017 1 次提交
  12. 19 7月, 2017 1 次提交
    • J
      docs: schema: make disk driver name attribute optional · b494e09d
      Jim Fehlig 提交于
      /domain/devices/disk/driver/@name is not a required or mandatory
      attribute according to formatdomain, and indeed it was agreed on
      IRC that the attribute is "optional for input, recommended (but
      not required) for output". Currently the schema requires the
      attribute, causing virt-xml-validate to fail on disk config where
      the driver name is not explicitly specified. E.g.
      
      # cat test.xml | grep -A 5 cdrom
          <disk type='file' device='cdrom'>
            <driver type='raw'/>
            <target dev='hdb' bus='ide'/>
            <readonly/>
            <address type='drive' controller='0' bus='0' target='0' unit='1'/>
          </disk>
      
      # virt-xml-validate test.xml
      Relax-NG validity error : Extra element devices in interleave
      test.xml:21: element devices: Relax-NG validity error : Element domain failed to validate content
      test.xml fails to validate
      
      Relaxing the name attribute to be optional fixes the validation
      
      # virt-xml-validate test.xml
      test.xml validates
      b494e09d
  13. 15 7月, 2017 2 次提交
  14. 11 7月, 2017 3 次提交
  15. 27 6月, 2017 1 次提交
  16. 20 6月, 2017 1 次提交
  17. 16 6月, 2017 1 次提交
    • M
      Report more correct information for cache control · cc9f0521
      Martin Kletzander 提交于
      On some platforms the number of bits in the cbm_mask might not be
      divisible by 4 (and not even by 2), so we need to properly count the
      bits.  Similar file, min_cbm_bits, is properly parsed and used, but if
      the number is greater than one, we lose the information about
      granularity when reporting the data in capabilities.  For that matter
      always report granularity, but if it is not the same as the minimum,
      add that information in there as well.
      Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
      cc9f0521
  18. 08 6月, 2017 9 次提交
  19. 07 6月, 2017 1 次提交
  20. 05 6月, 2017 1 次提交
    • E
      Expose resource control capabilities for caches · 0ab409cc
      Eli Qiao 提交于
      Add cache resource control into capabilities for CAT without CDP:
      
        <cache>
          <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'>
            <control min='768' unit='KiB' scope='both' max_allocation='4'/>
          </bank>
        </cache>
      
      and with CDP:
      
        <cache>
          <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'>
            <control min='768' unit='KiB' scope='code' max_allocation='4'/>
            <control min='768' unit='KiB' scope='data' max_allocation='4'/>
          </bank>
        </cache>
      
      Also add new test cases for vircaps2xmltest.
      Signed-off-by: NEli Qiao <liyong.qiao@intel.com>
      0ab409cc
  21. 26 5月, 2017 3 次提交
  22. 18 5月, 2017 2 次提交
    • E
      nodedev: Introduce mdev capability for mediated devices · 88ef73e1
      Erik Skultety 提交于
      Start discovering the mediated devices on the host system and format the
      attributes for the mediated device into the XML. Compared to the parent
      device which reports generic information about the abstract mediated
      devices types, a child device only reports the type name it has been
      instantiated from and the IOMMU group number, since that's device
      specific compared to the rest of the info that can be gathered about
      mediated devices at the moment.
      This patch introduces both the formatting and parsing routines, updates
      nodedev.rng schema, adding a testcase as well.
      
      The resulting mdev child device XML:
      <device>
        <name>mdev_4b20d080_1b54_4048_85b3_a6a62d165c01</name>
        <path>/sys/devices/.../4b20d080-1b54-4048-85b3-a6a62d165c01</path>
        <parent>pci_0000_06_00_0</parent>
        <driver>
          <name>vfio_mdev</name>
        </driver>
        <capability type='mdev'>
          <type id='vendor_supplied_type_id'/>
          <iommuGroup number='NUM'/>
        <capability/>
      <device/>
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1452072Signed-off-by: NErik Skultety <eskultet@redhat.com>
      88ef73e1
    • E
      nodedev: Introduce the mdev capability to a PCI parent device · 500cbc06
      Erik Skultety 提交于
      The parent device needs to report the generic stuff about the supported
      mediated devices types, like device API, available instances, type name,
      etc. Therefore this patch introduces a new nested capability element of
      type 'mdev_types' with the resulting XML of the following format:
      
      <device>
        ...
        <capability type='pci'>
          ...
          <capability type='mdev_types'>
            <type id='vendor_supplied_id'>
              <name>optional_vendor_supplied_codename</name>
              <deviceAPI>vfio-pci</deviceAPI>
              <availableInstances>NUM</availableInstances>
            </type>
              ...
            <type>
              ...
            </type>
          </capability>
        </capability>
        ...
      </device>
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1452072Signed-off-by: NErik Skultety <eskultet@redhat.com>
      500cbc06
  23. 15 5月, 2017 1 次提交