1. 05 2月, 2013 16 次提交
    • J
      Add John Ferlan to the committers list · 1eb7a909
      John Ferlan 提交于
      1eb7a909
    • D
      Turn virDomainObjList into an opaque virObject · 37abd471
      Daniel P. Berrange 提交于
      As a step towards making virDomainObjList thread-safe turn it
      into an opaque virObject, preventing any direct access to its
      internals.
      
      As part of this a new method virDomainObjListForEach is
      introduced to replace all existing usage of virHashForEach
      37abd471
    • D
      Rename all domain list APIs to have virDomainObjList prefix · 4f6ed6c3
      Daniel P. Berrange 提交于
      The APIs names for accessing the domain list object are
      very inconsistent. Rename them all to have a standard
      virDomainObjList prefix.
      4f6ed6c3
    • D
      Introduce a virQEMUDriverConfigPtr object · b090aa7d
      Daniel P. Berrange 提交于
      Currently the virQEMUDriverPtr struct contains an wide variety
      of data with varying access needs. Move all the static config
      data into a dedicated virQEMUDriverConfigPtr object. The only
      locking requirement is to hold the driver lock, while obtaining
      an instance of virQEMUDriverConfigPtr. Once a reference is held
      on the config object, it can be used completely lockless since
      it is immutable.
      
      NB, not all APIs correctly hold the driver lock while getting
      a reference to the config object in this patch. This is safe
      for now since the config is never updated on the fly. Later
      patches will address this fully.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      b090aa7d
    • D
      Fix missing error constants in libvirt python module · 25ea8e47
      Daniel P. Berrange 提交于
      The previous change to the generator, changed too much - only
      the functions are in 'virerror.c', the constants remained in
      'virerror.h' which could not be renamed for API compat reasons.
      
      Add a test case to sanity check the generated python bindings
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      25ea8e47
    • M
      qemu: Catch stderr of image compression binary · 137229bf
      Michal Privoznik 提交于
      If a compression binary prints something to stderr, currently
      it is discarded. However, it can contain useful data from
      debugging POV, so we should catch it.
      137229bf
    • M
      qemu: Catch stderr of image decompression binary · cc6c425f
      Michal Privoznik 提交于
      If a decompression binary prints something to stderr, currently
      it is discarded. However, it can contain useful data from
      debugging POV, so we should catch it.
      cc6c425f
    • M
      virFileWrapperFd: Switch to new virCommandDoAsyncIO · 1f25194a
      Michal Privoznik 提交于
      Commit 34e8f63a introduced support for catching errors from
      libvirt iohelper. However, at those times there wasn't such fancy
      API as virCommandDoAsyncIO(), so everything has to be implemented
      on our own. But since we do have the API now, we can use it and
      drop our implementation then.
      1f25194a
    • M
      tests: Create test for virCommandDoAsyncIO · f0154959
      Michal Privoznik 提交于
      This is just a basic test, so we don't break virCommand in the
      future. A "Hello world\n" string is written to commanhelper,
      which copies input to stdout and stderr where we read it from.
      Then the read strings are compared with expected values.
      f0154959
    • M
      Introduce event loop to commandtest · 39c77fe5
      Michal Privoznik 提交于
      This is just preparing environment for the next patch, which is
      going to need an event loop.
      39c77fe5
    • M
      virCommand: Introduce virCommandDoAsyncIO · 68fb7550
      Michal Privoznik 提交于
      Currently, if we want to feed stdin, or catch stdout or stderr of a
      virCommand we have to use virCommandRun(). When using virCommandRunAsync()
      we have to register FD handles by hand. This may lead to code duplication.
      Hence, introduce an internal API, which does this automatically within
      virCommandRunAsync(). The intended usage looks like this:
      
          virCommandPtr cmd = virCommandNew*(...);
          char *buf = NULL;
      
          ...
      
          virCommandSetOutputBuffer(cmd, &buf);
          virCommandDoAsyncIO(cmd);
      
          if (virCommandRunAsync(cmd, NULL) < 0)
              goto cleanup;
      
          ...
      
          if (virCommandWait(cmd, NULL) < 0)
              goto cleanup;
      
          /* @buf now contains @cmd's stdout */
          VIR_DEBUG("STDOUT: %s", NULLSTR(buf));
      
          ...
      
      cleanup:
          VIR_FREE(buf);
          virCommandFree(cmd);
      
      Note, that both stdout and stderr buffers may change until virCommandWait()
      returns.
      68fb7550
    • P
      conf: Use correct type for device type enum in virDomainDeviceDefFree · 8a3cf528
      Peter Krempa 提交于
      With this change it's easy to spot a forgotten free if a new device
      class is added.
      8a3cf528
    • J
      build: Add libcurl dependency to libvirt_driver.la · 514b9306
      Jiri Denemark 提交于
      libvirt.c calls curl_global_init() if WITH_CURL is defined and thus it
      should be linked with libcurl. This fixes link failure in case neither
      xenapi nor esx driver is enabled (they are the only users of libcurl).
      514b9306
    • J
      spec: Fix minor changelog issues · 53657a0a
      Jiri Denemark 提交于
      When a changelog entry references an RPM macro, % needs to be escaped so
      that it does not appear expanded in package changelog.
      
      Fri Mar  4 2009 is incorrect since Mar 4 was Wednesday. Since
      libvirt-0.6.1 was released on Mar 4 2009, we should change Fri to Wed.
      53657a0a
    • M
      Add basic support for VDI images · 027bf2ea
      Martin Kletzander 提交于
      QEMU is fully capable of handling VDI images and we just refuse to
      work with them.  As qemu-img knows and supports this, there should be
      no problem with this addition.
      
      This is of course, just basic functionality, without searching for any
      backing files, etc.
      027bf2ea
    • M
      Support shifted magic in storage files · a0f98229
      Martin Kletzander 提交于
      Some files have the magic shifted to some offset other than 0, so we
      have to support that.  I also cleaned up some lines to be more
      readable and added missing magic for iso file format.
      a0f98229
  2. 04 2月, 2013 17 次提交
  3. 02 2月, 2013 4 次提交
    • M
      e7aa207c
    • M
      esx: Simplify esxPrivate pointer handling in esxOpen · ee47d236
      Matthias Bolte 提交于
      Commit 4445e16b changed the signature
      of esxConnectToHost and esxConnectToVCenter by replacing the esxPrivate
      pointer with virConnectPtr. The esxPrivate pointer was then retrieved
      again from virConnectPtr's privateData. This resulted in a NULL pointer
      dereference, because the privateData pointer was not yet initialized at
      the point where esxConnectToHost and esxConnectToVCenter are called.
      
      This was fixed in commit b126715a that
      moved the initialization of privateData before the problematic calls.
      
      Simplify the logic by making the call to esxFreePrivate unconditional and
      changing esxConnectToHost and esxConnectToVCenter back to take a esxPrivate
      pointer directly. This allows to assign esxPrivate to the virConnectPtr's
      privateData pointer as one of the last steps in esxOpen making it more
      obvious that it is not initialized during the earlier steps of esxOpen.
      ee47d236
    • E
      docs: don't ignore virEvent API · b2aa03b3
      Eric Blake 提交于
      Commit 6094ad7b (0.9.3 release) promoted several functions from
      internal to public, but forgot to fix the documentation generator
      to provide details about those functions.
      
      For an example of what this fixes, look at:
      file:///path/to/libvirt/docs/html/libvirt-libvirt.html#virEventAddHandle
      before and after the patch.
      
      * docs/apibuild.py (ignored_functions): Don't ignore functions
      that were turned into official API.
      * src/util/virevent.c: Fix comments to pass through parser.
      b2aa03b3
    • E
      maint: update to latest gnulib · d09949e2
      Eric Blake 提交于
      CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon
      that runs a regex search on user input while in a multibyte locale.
      I'm not sure how hard it would be to trigger such a setup for
      libvirtd, but rather than risk things, we can avoid the issue:
      gnulib has worked around the problem, and by updating to the latest
      gnulib, we can avoid the bug even on platforms where glibc has yet
      to be patched.
      
      * .gnulib: Update to latest, for various fixes, including regex.
      * bootstrap: Resync from upstream.
      d09949e2
  4. 01 2月, 2013 3 次提交