1. 19 4月, 2013 7 次提交
    • J
      cpu: Introduce cpuModelIsAllowed internal API · 16c6b60c
      Jiri Denemark 提交于
      The API can be used to check if the model is on the supported models
      list, which needs to be done in several places.
      16c6b60c
    • P
      virsh-domain: Refactor cmdVcpucount and fix output on inactive domains · 642261a8
      Peter Krempa 提交于
      This patch factors out the vCPU count retrieval including fallback means
      into vshCPUCountCollect() and removes the duplicated code to retrieve
      individual counts.
      
      The --current flag (this flag is assumed by default) now works also with
      --maximum or --active without the need to explicitly specify the state
      of the domain that is requested.
      
      This patch also fixes the output of "virsh vcpucount domain" on inactive
      domains:
      
      Before:
      $ virsh vcpucount domain
      maximum      config         4
      error: Requested operation is not valid: domain is not running
      current      config         4
      error: Requested operation is not valid: domain is not running
      
      After:
      $virsh vcpucount domain
      maximum      config         4
      current      config         4
      
      .. and for transient domains too:
      
      Before:
      $ virsh vcpucount transient-domain
      error: Requested operation is not valid: cannot change persistent config of a transient domain
      maximum      live           3
      error: Requested operation is not valid: cannot change persistent config of a transient domain
      current      live           1
      
      After:
      $ virsh vcpucount transient-domain
      maximum      live           3
      current      live           1
      642261a8
    • L
      Set legacy USB option with default for ppc64. · 88c6159c
      Li Zhang 提交于
      Currently, -device xxx still doesn't work well for ppc64 platform.
      It's better use legacy USB option with default for ppc64.
      Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
      88c6159c
    • J
      qemu: fix default spice password setting · 4327df7e
      Ján Tomko 提交于
      Set spice password even if default VNC password hasn't been set.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=953720
      4327df7e
    • P
      78d7c3c5
    • P
      util: allow using virCommandAllowCap with setuid helpers · 5c1cfea4
      Paolo Bonzini 提交于
      When running unprivileged, virSetUIDGIDWithCaps will fail because it
      tries to add the requested capabilities to the permitted and effective
      sets.
      
      Detect this case, and invoke the child with cleared permitted and
      effective sets.  If it is a setuid program, it will get them.
      
      Some care is needed also because you cannot drop capabilities from the
      bounding set without CAP_SETPCAP.  Because of that, ignore errors from
      setting the bounding set.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      5c1cfea4
    • P
      util: simplify virSetUIDGIDWithCaps · 65871845
      Paolo Bonzini 提交于
      The need_prctl variable is not really needed.  If it is false,
      capng_apply will be called twice with the same set, causing
      a little extra work but no problem.  This keeps the code a bit
      simpler.
      
      It is also clearer to invoke capng_apply(CAPNG_SELECT_BOUNDS)
      separately, to make sure it is done while we have CAP_SETPCAP.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      65871845
  2. 18 4月, 2013 10 次提交
  3. 17 4月, 2013 6 次提交
    • O
      remote: Revert removing "libvirt/libvirt.h" in remote_protocol.x · f0431994
      Osier Yang 提交于
      Commit 2d25fd4f removed the including of "libvirt/libvirt.h",
      which breaks the build. Pushed under build-breaker rule.
      f0431994
    • O
      qemu: Allow the disk wwn to have "0x" prefix · 09d2547f
      Osier Yang 提交于
      The recent qemu requires "0x" prefix for the disk wwn, this patch
      changes virValidateWWN to allow the prefix, and prepend "0x" if
      it's not specified. E.g.
      
      qemu-kvm: -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\
      drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,wwn=6000c60016ea71ad:
      Property 'scsi-hd.wwn' doesn't take value '6000c60016ea71ad'
      
      Though it's a qemu regression, but it's nice to allow the prefix,
      and doesn't hurt for us to always output "0x".
      09d2547f
    • O
      cleanup: Don't include libvirt/virterror.h · 5829054c
      Osier Yang 提交于
      Which is already included in "internal.h", later patch will add
      syntax-check to avoid it.
      5829054c
    • O
      cleanup: Don't include libvirt/libvirt.h · 2d25fd4f
      Osier Yang 提交于
      Which is already included by "internal.h", later patch will add
      syntax-check to avoid it.
      2d25fd4f
    • O
      cleanup: Remove the duplicate header · bc95be5d
      Osier Yang 提交于
      Detected by a simple Shell script:
      
      for i in $(git ls-files -- '*.[ch]'); do
          awk 'BEGIN {
              fail=0
          }
          /# *include.*\.h/{
              match($0, /["<][^">]*[">]/)
              arr[substr($0, RSTART+1, RLENGTH-2)]++
          }
          END {
              for (key in arr) {
                  if (arr[key] > 1) {
                      fail=1
                      printf("%d %s\n", arr[key], key)
                  }
              }
              if (fail == 1)
                  exit 1
          }' $i
      
          if test $? != 0; then
              echo "Duplicate header(s) in $i"
          fi
      done;
      
      A later patch will add the syntax-check to avoid duplicate
      headers.
      bc95be5d
    • O
      cleanup: Only include testutils.h once · 2beae9c2
      Osier Yang 提交于
      No reason to include it in both "if" and "else" branches.
      2beae9c2
  4. 16 4月, 2013 17 次提交