1. 30 4月, 2008 2 次提交
    • D
      159cb2b9
    • J
      remove useless tests before xmlFree · 0c37f598
      Jim Meyering 提交于
      * src/qemu_conf.c (qemudParseDiskXML, qemudParseInterfaceXML):
      (qemudParseInputXML, qemudParseDhcpRangesXML):
      * src/remote_internal.c (doRemoteOpen):
      * src/storage_conf.c (virStoragePoolDefParseDoc):
      * src/xm_internal.c (xenXMParseXMLDisk, xenXMParseXMLVif):
      (xenXMParseXMLToConfig, xenXMAttachInterface):
      * src/xml.c (virDomainParseXMLDiskDesc, virDomainParseXMLIfDesc):
      (virDomainXMLDevID):
      0c37f598
  2. 28 4月, 2008 1 次提交
  3. 26 4月, 2008 1 次提交
  4. 11 4月, 2008 2 次提交
  5. 27 3月, 2008 2 次提交
    • J
      xenXMError: mark for translation string args to this function · 56a3cb80
      Jim Meyering 提交于
      * Makefile.maint (msg_gen_function): Add xenXMError.
      * src/xm_internal.c (xenXMParseXMLToConfig, xenXMDomainDefineXML):
      (xenXMDomainAttachDevice, xenXMDomainDetachDevice): Mark strings.
      56a3cb80
    • J
      Mark many more strings for translation. · 513bd04c
      Jim Meyering 提交于
      * Makefile.maint (err_func_re): Add to the list and make it readable.
      * po/POTFILES.in: Add src/util.c and src/xm_internal.c, and sort.
      * src/storage_backend.c: Fix comment.
      * src/util.c (virFileLinkPointsTo): Mark a string.
      * qemud/remote.c (remoteDispatchClientRequest): Mark strings.
      (remoteDispatchOpen, CHECK_CONN, remoteDispatchGetType): Likewise.
      (remoteDispatchDomainGetSchedulerType): Likewise.
      (remoteDispatchDomainGetSchedulerParameters): Likewise.
      (remoteDispatchDomainSetSchedulerParameters): Likewise.
      (remoteDispatchDomainBlockStats): Likewise.
      (remoteDispatchDomainInterfaceStats): Likewise.
      (remoteDispatchDomainAttachDevice, remoteDispatchDomainCreate):
      (remoteDispatchDomainDestroy, remoteDispatchDomainDetachDevice):
      (remoteDispatchDomainDumpXml, remoteDispatchDomainGetAutostart):
      (remoteDispatchDomainGetInfo, remoteDispatchDomainGetMaxMemory):
      (remoteDispatchDomainGetMaxVcpus, remoteDispatchDomainGetOsType):
      (remoteDispatchDomainGetVcpus): Likewise.
      (remoteDispatchDomainMigratePerform): Likewise.
      (remoteDispatchListDefinedDomains, remoteDispatchDomainPinVcpu):
      (remoteDispatchDomainReboot, remoteDispatchDomainResume):
      (remoteDispatchDomainSave, remoteDispatchDomainCoreDump):
      (remoteDispatchDomainSetAutostart): Likewise.
      (remoteDispatchDomainSetMaxMemory, remoteDispatchDomainSetMemory):
      (remoteDispatchDomainSetVcpus, remoteDispatchDomainShutdown):
      (remoteDispatchDomainSuspend, remoteDispatchDomainUndefine):
      (remoteDispatchListDefinedNetworks, remoteDispatchListDomains):
      (remoteDispatchListNetworks, remoteDispatchNetworkCreate):
      (remoteDispatchNetworkDestroy, remoteDispatchNetworkDumpXml):
      (remoteDispatchNetworkGetAutostart, remoteDispatchNetworkGetBridgeName):
      (remoteDispatchNetworkSetAutostart, remoteDispatchNetworkUndefine):
      (addrToString, remoteDispatchAuthSaslInit, remoteDispatchAuthSaslStart):
      (remoteDispatchAuthSaslStep, remoteDispatchListDefinedStoragePools):
      (remoteDispatchListStoragePools, remoteDispatchStoragePoolCreate):
      (remoteDispatchStoragePoolBuild, remoteDispatchStoragePoolDestroy):
      (remoteDispatchStoragePoolDelete, remoteDispatchStoragePoolRefresh):
      (remoteDispatchStoragePoolGetInfo, remoteDispatchStoragePoolDumpXml):
      (remoteDispatchStoragePoolGetAutostart): Likewise.
      (remoteDispatchStoragePoolSetAutostart):
      (remoteDispatchStoragePoolListVolumes):
      (remoteDispatchStoragePoolNumOfVolumes):
      (remoteDispatchStoragePoolUndefine, remoteDispatchStorageVolCreateXml):
      (remoteDispatchStorageVolDelete, remoteDispatchStorageVolGetInfo):
      (remoteDispatchStorageVolDumpXml, remoteDispatchStorageVolGetPath):
      (remoteDispatchStorageVolLookupByName): Likewise.
      * src/qemu_driver.c (qemudOpenMonitor, qemudStartVMDaemon):
      (dhcpStartDhcpDaemon, qemudStartNetworkDaemon):
      (qemudDomainSuspend, qemudDomainResume, qemudDomainShutdown):
      (qemudDomainGetOSType, qemudDomainSetMaxMemory):
      (qemudDomainSetMemory, qemudDomainGetInfo, qemudDomainSave):
      (qemudDomainRestore, qemudDomainDumpXML, qemudDomainStart):
      (qemudDomainUndefine, qemudDomainChangeCDROM):
      (qemudDomainAttachDevice, qemudDomainGetAutostart):
      (qemudDomainSetAutostart, qemudDomainInterfaceStats):
      (qemudNetworkLookupByUUID, qemudNetworkLookupByName):
      (qemudNetworkUndefine, qemudNetworkStart, qemudNetworkDestroy):
      (qemudNetworkDumpXML, qemudNetworkGetAutostart):
      (qemudNetworkSetAutostart): Likewise.
      * src/virsh.c (cmdVcpupin, cmdAttachDevice, cmdDetachDevice): Likewise.
      * src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu): Likewise.
      513bd04c
  6. 28 2月, 2008 1 次提交
    • R
      virMacAddrCompare for comparing MAC addresses · 92a1e14b
      Richard W.M. Jones 提交于
      	* src/util.c, src/util.h, src/libvirt_sym.version: Added
      	  virMacAddrCompare utility function for comparing MAC
      	  addresses.
      	* src/virsh.c, src/xm_internal.c: Use virMacAddrCompare
      	  to compare addresses.  (Shigeki Sakamoto and Richard Jones).
      92a1e14b
  7. 27 2月, 2008 1 次提交
  8. 20 2月, 2008 1 次提交
  9. 08 2月, 2008 1 次提交
    • J
      Remove more useless if tests before "free"-like functions. · e8ff93b4
      Jim Meyering 提交于
      * build-aux/useless-if-before-free: Rename from ...
      * build-aux/find-unnecessary-if-before-free: ... this.  Remove file.
      Also changed it so that new names are no longer hard-coded in the
      script.  Instead, they're supplied via options:
      * Makefile.cfg (useless_free_options): Define.
      Add xmlXPathFreeObject to the list of free-like functions it detects.
      * Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
      * .x-sc_avoid_if_before_free: Likewise.
      * src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
      * src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
      * src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
      (cmdDetachDisk): Likewise.
      * src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
      (xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
      (xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
      (xenXMDomainDetachDevice): Likewise.
      * src/xml.c (virXPathString): Likewise.
      * tests/xmlrpctest.c (checkRequestValue): Likewise.
      e8ff93b4
  10. 07 2月, 2008 3 次提交
  11. 06 2月, 2008 1 次提交
  12. 05 2月, 2008 1 次提交
    • J
      Eliminate all uses of virBufferAdd with string literals. · fb66d5ab
      Jim Meyering 提交于
      * Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
      New rule.
      * src/buf.h (virBufferAddLit): Define.
      * src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
      of virBufferAdd everywhere possible.
      (virConfSaveEntry): Likewise.
      * src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
      * src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
      * src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
      * src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
      * src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
      (xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
      * src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
      * src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
      (virDomainParseXMLGraphicsDescImage): Likewise.
      (virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
      (virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
      (virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
      fb66d5ab
  13. 30 1月, 2008 3 次提交
    • J
      Also detect and remove unnecessary if-before-xmlXPathFreeContext. · 2367caa3
      Jim Meyering 提交于
      * build-aux/find-unnecessary-if-before-free: Update regexp.
      * src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
      * src/qemu_conf.c: Likewise.
      * src/virsh.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * tests/xmlrpctest.c: Likewise.
      2367caa3
    • J
      Enable the <config.h>-requiring test; fix violations · a3781881
      Jim Meyering 提交于
      Use <config.h>, not "config.h", per autoconf documentation.
      * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
      * .x-sc_require_config_h: New file, to list exempted files.
      * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
      a3781881
    • J
      Given code like if (foo) free (foo); remove the useless "if (foo) " part. · acff2d11
      Jim Meyering 提交于
      Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
      
      * proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
      * python/generator.py: Likewise.
      * qemud/qemud.c: Likewise.
      * src/buf.c: Likewise.
      * src/conf.c: Likewise.
      * src/hash.c: Likewise.
      * src/iptables.c: Likewise.
      * src/libvirt.c: Likewise.
      * src/openvz_conf.c: Likewise.
      * src/qemu_conf.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/remote_internal.c: Likewise.
      * src/test.c: Likewise.
      * src/virsh.c: Likewise.
      * src/virterror.c: Likewise.
      * src/xen_internal.c: Likewise.
      * src/xen_unified.c: Likewise.
      * src/xend_internal.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * src/xmlrpc.c: Likewise.
      * src/xs_internal.c: Likewise.
      * tests/testutils.c: Likewise.
      * tests/xencapstest.c: Likewise.
      * tests/xmconfigtest.c: Likewise.
      acff2d11
  14. 21 1月, 2008 1 次提交
    • D
      Preserve vif order · 5912e7c2
      Daniel Veillard 提交于
      * src/xml-internal.c: apply patch from Hiroyuki Kaguchi to
        preserve the vif list order.
      Daniel
      5912e7c2
  15. 14 12月, 2007 1 次提交
  16. 12 12月, 2007 1 次提交
    • J
      Use a variable name as sizeof argument, not a type name. · 49230350
      Jim Meyering 提交于
      Given code like: T *var = calloc (n, sizeof (T));
      Convert to this: T *var = calloc (n, sizeof (*var));
      This first-cut change adjusts all malloc, calloc, and
      realloc statements.
      
      The only binary differences are in remote_internal.c
      (due to the bug fix) and in xmlrpc.c (due to factorization).
      
      * python/libvir.c: As above.
      * qemud/event.c: Likewise.
      * qemud/mdns.c: Likewise.
      * qemud/qemud.c: Likewise.
      * qemud/remote.c: Likewise.
      * src/bridge.c: Likewise.
      * src/buf.c: Likewise.
      * src/conf.c: Likewise.
      * src/hash.c: Likewise.
      * src/iptables.c: Likewise.
      * src/openvz_conf.c: Likewise.
      * src/qemu_conf.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/test.c: Likewise.
      * src/xen_internal.c: Likewise.
      * src/xen_unified.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * tests/qemuxml2argvtest.c: Likewise.
      * src/xmlrpc.c (xmlRpcValuePtr): Likewise, and minor factorization.
      * src/remote_internal.c (remoteAuthMakeCredentials): Use the right
      type when allocating space for an array of cred _pointers_.
      49230350
  17. 07 12月, 2007 1 次提交
    • J
      Include "config.h" in remaining non-generated files. · 4a2f8fc6
      Jim Meyering 提交于
      * proxy/libvirt_proxy.c: Likewise.
      * python/libvir.c: Likewise.
      * python/types.c: Likewise.
      * src/event.c: Likewise.
      * src/xm_internal.c: Likewise.
      * tests/reconnect.c: Likewise.
      * tests/testutils.c: Likewise.
      4a2f8fc6
  18. 06 12月, 2007 1 次提交
  19. 03 12月, 2007 1 次提交
  20. 28 11月, 2007 1 次提交
  21. 22 11月, 2007 1 次提交
  22. 21 11月, 2007 1 次提交
  23. 20 11月, 2007 1 次提交
  24. 14 11月, 2007 1 次提交
  25. 01 11月, 2007 1 次提交
  26. 31 10月, 2007 1 次提交
  27. 11 10月, 2007 2 次提交
  28. 10 8月, 2007 1 次提交
  29. 19 7月, 2007 1 次提交
  30. 17 7月, 2007 1 次提交
  31. 09 7月, 2007 1 次提交
  32. 06 7月, 2007 1 次提交
    • R
      Fri Jul 6 16:08:00 BST 2007 Richard W.M. Jones <rjones@redhat.com> · 4ea0ef79
      Richard W.M. Jones 提交于
      	* src/proxy_internal.c, src/proxy_internal.h,
      	  src.xen_internal.c, src/xen_internal.h,
      	  src/xen_unified.c, src/xen_unified.h,
      	  src/xend_internal.c, src/xend_internal.h,
      	  src/xm_internal.c, src/xm_internal.h,
      	  src/xs_internal.c, src/xs_internal.h: The interface
      	  between xen_unified.c and its underlying driver now uses
      	  a custom structure (struct xenUnifiedDriver) instead
      	  of reusing virDriver.
      	* src/xen_unified.c: virDomainLookup* functions in Xen
      	  now throw VIR_ERR_NO_DOMAIN if the domain does not exist.
      	* src/xs_internal.c: Fix indentation.
      4ea0ef79