1. 23 10月, 2008 1 次提交
    • D
      Massive patch adding event APIs by Ben Guthro · 1509b802
      Daniel Veillard 提交于
      * include/libvirt/libvirt.h include/libvirt/libvirt.h.in
        src/libvirt.c src/libvirt_sym.version: new libvirt event entry
        points, big patch provided by Ben Guthro
      * Makefile.am configure.in src/driver.h src/event.c src/event.h
        src/internal.h src/libvirt.c src/libvirt_sym.version src/lxc_driver.c
        src/openvz_driver.c src/qemu_conf.h src/qemu_driver.c
        src/remote_internal.c src/storage_backend_fs.c src/test.c
        qemud/event.c qemud/event.h qemud/mdns.c qemud/qemud.c
        qemud/qemud.h qemud/remote.c qemud/remote_dispatch_localvars.h
        qemud/remote_dispatch_proc_switch.h qemud/remote_dispatch_prototypes.h
        qemud/remote_protocol.c qemud/remote_protocol.h
        qemud/remote_protocol.x proxy/Makefile.am python/generator.py:
        Not much is left untouched by the patch adding the events support
      * docs/libvirt-api.xml docs/libvirt-refs.xml
        docs/html/libvirt-libvirt.html: regenerated the docs
      * examples/domain-events/events-c/Makefile.am
        examples/domain-events/events-c/event-test.c: a test example
      * AUTHORS: added Ben Guthro
      daniel
      1509b802
  2. 14 10月, 2008 1 次提交
    • J
      avoid many format string warnings · fd52c6ff
      Jim Meyering 提交于
      Building with --disable-nls exposed many new warnings like these:
      virsh.c:4952: warning: format not a string literal and no format ...
      util.c:163: warning: format not a string literal and no format arguments
      All but one of the following changes add a "%s" argument before
      the offending _(...) argument.
      
      This was the only manual change:
      * src/lxc_driver.c (lxcVersion): Use %s and strerror(errno)
      rather than %m, to avoid a warning from gcc -Wformat-security.
      
      Add "%s" before each warned about format-string-with-no-%-directive:
      * src/domain_conf.c (virDomainHostdevSubsysUsbDefParseXML)
      (virDomainDefParseString, virDomainDefParseFile):
      * src/hash.c (virGetConnect, __virGetDomain, virReleaseDomain)
      (__virGetNetwork, virReleaseNetwork, __virGetStoragePool)
      (virReleaseStoragePool, __virGetStorageVol, virReleaseStorageVol):
      * src/lxc_container.c (lxcContainerChild):
      * src/lxc_driver.c (lxcDomainDefine, lxcDomainUndefine)
      (lxcDomainGetInfo, lxcGetOSType, lxcDomainDumpXML)
      (lxcSetupInterfaces, lxcDomainStart, lxcDomainCreateAndStart)
      (lxcVersion, lxcGetSchedulerParameters):
      * src/network_conf.c (virNetworkDefParseString)
      (virNetworkDefParseFile):
      * src/openvz_conf.c (openvzReadNetworkConf, openvzLoadDomains):
      * src/openvz_driver.c (openvzDomainDefineCmd)
      (openvzDomainGetInfo, openvzDomainDumpXML, openvzDomainShutdown)
      (openvzDomainReboot, ADD_ARG_LIT, openvzDomainDefineXML)
      (openvzDomainCreateXML, openvzDomainCreate, openvzDomainUndefine)
      (openvzDomainSetAutostart, openvzDomainGetAutostart)
      (openvzDomainSetVcpus):
      * src/qemu_driver.c (qemudDomainBlockPeek, qemudDomainMemoryPeek):
      * src/remote_internal.c (remoteDomainBlockPeek)
      (remoteDomainMemoryPeek, remoteAuthPolkit):
      * src/sexpr.c (sexpr_new, _string2sexpr):
      * src/storage_backend_disk.c (virStorageBackendDiskMakeDataVol)
      (virStorageBackendDiskCreateVol):
      * src/storage_backend_fs.c
      (virStorageBackendFileSystemNetFindPoolSources):
      * src/storage_backend_logical.c (virStorageBackendLogicalFindLVs)
      (virStorageBackendLogicalFindPoolSources):
      * src/test.c (testOpenDefault, testOpenFromFile, testOpen)
      (testGetDomainInfo, testDomainRestore)
      (testNodeGetCellsFreeMemory):
      * src/util.c (virExec):
      * src/virsh.c (cmdAttachDevice, cmdDetachDevice)
      (cmdAttachInterface, cmdDetachInterface, cmdAttachDisk)
      (cmdDetachDisk, cmdEdit):
      * src/xend_internal.c (do_connect, wr_sync, xend_op_ext)
      (urlencode, xenDaemonDomainCreateXML)
      (xenDaemonDomainLookupByName_ids, xenDaemonDomainLookupByID)
      (xenDaemonParseSxprOS, xend_parse_sexp_desc_char)
      (xenDaemonParseSxprChar, xenDaemonParseSxprDisks)
      (xenDaemonParseSxpr, sexpr_to_xend_topology, sexpr_to_domain)
      (xenDaemonDomainFetch, xenDaemonDomainGetAutostart)
      (xenDaemonDomainSetAutostart, xenDaemonDomainMigratePerform)
      (xenDaemonDomainDefineXML, xenDaemonGetSchedulerType)
      (xenDaemonGetSchedulerParameters)
      (xenDaemonSetSchedulerParameters, xenDaemonDomainBlockPeek)
      (xenDaemonFormatSxprChr, virDomainXMLDevID):
      * src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu)
      (xenXMDomainCreate, xenXMDomainDefineXML)
      (xenXMDomainAttachDevice, xenXMDomainDetachDevice):
      * src/xml.c (virXPathString, virXPathNumber, virXPathLong)
      (virXPathULong, virXPathBoolean, virXPathNode, virXPathNodeSet):
      * src/xs_internal.c (xenStoreOpen):
      fd52c6ff
  3. 11 10月, 2008 1 次提交
    • J
      testError format strings: explicitly include domain and network names · 6ac27467
      Jim Meyering 提交于
      This repairs the "make check" failure of tests/undefine.
      * src/test.c (testResumeDomain, testPauseDomain): Likewise.
      (testShutdownDomain, testGetDomainInfo, ): Likewise.
      (testSetMemory, testSetVcpus, testDomainCreate, testDomainUndefine)
      (testDomainGetSchedulerType, testDomainGetSchedulerParams): Likewise.
      (testDomainSetSchedulerParams, testNetworkUndefine): Likewise.
      (testNetworkStart, testNetworkGetBridgeName): Likewise.
      (testDomainCoreDump, testDomainSave): Likewise, and...
      Name the file upon failed open or write.
      Use strerror(errno) in diagnostics.
      * tests/undefine: Adjust expected output.
      
      test.c (testError): Remove now-ignored dom and net parameters.
      This is a sytnax-only change: removing the two unused parameters
      and updating all callers:
      * src/test.c (GET_DOMAIN, GET_NETWORK, testError)
      (testBuildCapabilities, testOpenDefault, testOpenFromFile)
      (testOpen, testGetHostname, testGetURI, testGetCapabilities)
      (testLookupDomainByID, testLookupDomainByUUID)
      (testLookupDomainByName, testResumeDomain, testPauseDomain)
      (testShutdownDomain, testGetDomainInfo, testDomainSave)
      (testDomainRestore, testDomainCoreDump, testGetOSType)
      (testSetMemory, testSetVcpus, testListDefinedDomains)
      (testNodeGetCellsFreeMemory, testDomainCreate)
      (testDomainUndefine, testDomainGetSchedulerType)
      (testDomainGetSchedulerParams, testDomainSetSchedulerParams)
      (testLookupNetworkByUUID, testLookupNetworkByName)
      (testListNetworks, testListDefinedNetworks, testNetworkUndefine)
      (testNetworkStart, testNetworkGetBridgeName): Update callers.
      6ac27467
  4. 10 10月, 2008 3 次提交
  5. 09 10月, 2008 1 次提交
  6. 21 8月, 2008 1 次提交
  7. 25 7月, 2008 3 次提交
  8. 19 7月, 2008 1 次提交
    • J
      remove unnecessary "V = NULL;" stmts after VIR_FREE(V) · 3ff5480d
      Jim Meyering 提交于
      * src/domain_conf.c (virDomainChrDefParseXML)
      (virDomainNetDefParseXML): Likewise.
      * src/iptables.c (iptRuleFree): Likewise.
      * src/storage_backend.c (virStorageBackendRunProgRegex): Likewise.
      * src/test.c (testOpenFromFile): Likewise.
      * src/xmlrpc.c (xmlRpcCallRaw): Likewise.
      3ff5480d
  9. 12 7月, 2008 2 次提交
  10. 10 6月, 2008 1 次提交
    • R
      virDomainMemoryPeek API · 6bcf2501
      Richard W.M. Jones 提交于
              * include/libvirt/libvirt.h.in, src/libvirt.c, src/driver.h,
                src/libvirt_sym.version: New virDomainMemoryPeek API.
              * qemud/remote.c, qemud/remote_protocol.x, src/remote_internal.c:
                Support for remote.
              * src/qemu_driver.c: QEMU driver implementation of API.
              * src/test.c: Test driver (null) implementation of API.
              * docs/hvsupport.html.in: Document API.
              * libvirt.spec.in: New path /var/cache/libvirt for temporary
                storage of memory images.
              * qemud/libvirtd.init.in: Remove any old temp files in
                /var/cache/libvirt on restarts.
              * src/Makefile.am: make install creates /var/cache/libvirt.
              * configure.in: Detect mkdir -p.
      6bcf2501
  11. 05 6月, 2008 1 次提交
    • R
      virDomainBlockPeek call · 8354895e
      Richard W.M. Jones 提交于
      	* configure.in: Document AC_SYS_LARGEFILE.
      	* docs/hvsupport.html.in: Document HV support for virDomainBlockPeek.
      	* include/libvirt/libvirt.h.in, src/driver.h, src/libvirt.c,
      	src/libvirt_sym.version: Add virDomainBlockPeek infrastructure.
      	* src/qemu_driver.c, src/test.c: Null versions of this call.
      	* src/xen_unified.c, src/xend_internal.c, src/xend_internal.h,
      	src/xm_internal.c, src/xm_internal.h: Xen implementation.
      	* tests/sexpr2xmldata/sexpr2xml-curmem.xml,
      	tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml: XML output
      	has been reordered slightly in the Xen driver, but should be
      	functionally the same.
      8354895e
  12. 30 5月, 2008 1 次提交
  13. 15 5月, 2008 1 次提交
  14. 28 4月, 2008 1 次提交
  15. 11 4月, 2008 1 次提交
  16. 08 4月, 2008 1 次提交
  17. 04 4月, 2008 1 次提交
  18. 27 3月, 2008 1 次提交
  19. 27 2月, 2008 1 次提交
  20. 26 2月, 2008 1 次提交
  21. 22 2月, 2008 1 次提交
    • J
      Use safewrite in place of write, in many cases. · b59d9c85
      Jim Meyering 提交于
      Also add "make syntax-check" rules to ensure no new uses sneak in.
      
      There are many uses of write like this:
      
          if (write (fd, xml, towrite) != towrite)
              return -1;
      
      The problem is that the syscall can succeed, yet write less than
      the requested number of bytes, so the caller should retry
      rather than simply failing.
      
      This patch changes most of them to use util.c's safewrite wrapper,
      which encapsulates the process.  Also, there were a few cases in
      which the retry loop was open-coded, and I replaced those, too.
      
      * Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
      * .x-sc_avoid_write: New file.  Record two legitimate exemptions.
      * qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
      * src/conf.c (__virConfWriteFile): Likewise.
      * src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
      * src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
      (qemudVMData, PROC_IP_FORWARD): Likewise.
      * proxy/libvirt_proxy.c: Include "util.h".
      (proxyWriteClientSocket): Use safewrite.
      * src/test.c (testDomainSave, testDomainCoreDump): Likewise.
      * src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
      * src/virsh.c: Include "util-lib.h".
      (vshOutputLogFile): Use safewrite.
      * src/console.c: Include "util-lib.h".
      (vshRunConsole): Use safewrite.
      b59d9c85
  22. 20 2月, 2008 1 次提交
  23. 05 2月, 2008 1 次提交
    • J
      Eliminate all uses of virBufferAdd with string literals. · fb66d5ab
      Jim Meyering 提交于
      * Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
      New rule.
      * src/buf.h (virBufferAddLit): Define.
      * src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
      of virBufferAdd everywhere possible.
      (virConfSaveEntry): Likewise.
      * src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
      * src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
      * src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
      * src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
      * src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
      (xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
      * src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
      * src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
      (virDomainParseXMLGraphicsDescImage): Likewise.
      (virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
      (virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
      (virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
      fb66d5ab
  24. 31 1月, 2008 4 次提交
  25. 30 1月, 2008 2 次提交
    • J
      Enable the <config.h>-requiring test; fix violations · a3781881
      Jim Meyering 提交于
      Use <config.h>, not "config.h", per autoconf documentation.
      * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
      * .x-sc_require_config_h: New file, to list exempted files.
      * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
      a3781881
    • J
      Given code like if (foo) free (foo); remove the useless "if (foo) " part. · acff2d11
      Jim Meyering 提交于
      Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
      
      * proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
      * python/generator.py: Likewise.
      * qemud/qemud.c: Likewise.
      * src/buf.c: Likewise.
      * src/conf.c: Likewise.
      * src/hash.c: Likewise.
      * src/iptables.c: Likewise.
      * src/libvirt.c: Likewise.
      * src/openvz_conf.c: Likewise.
      * src/qemu_conf.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/remote_internal.c: Likewise.
      * src/test.c: Likewise.
      * src/virsh.c: Likewise.
      * src/virterror.c: Likewise.
      * src/xen_internal.c: Likewise.
      * src/xen_unified.c: Likewise.
      * src/xend_internal.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * src/xmlrpc.c: Likewise.
      * src/xs_internal.c: Likewise.
      * tests/testutils.c: Likewise.
      * tests/xencapstest.c: Likewise.
      * tests/xmconfigtest.c: Likewise.
      acff2d11
  26. 06 1月, 2008 1 次提交
    • R
      Miscellaneous fixes for building on Windows (MinGW). · 029aef1d
      Richard W.M. Jones 提交于
      	* configure.in: xdr functions may require -lxdr.
      	* configure.in, src/Makefile.am: Extra linking flags for
      	  building libvirt DLL.
      	* src/socketcompat.h: Hide Windows Winsock incompatibilities
      	  in a separate header file.
      	* src/remote_internal.c: Switch to using socketcompat.h /
      	  socket_errno().
      	* src/test.c: Switch to using socketcompat.h.
      	* gnulib/lib/arpa/.cvsignore: Ignore another generated file.
      	* src/qparams.c: Include <config.h>.
      029aef1d
  27. 12 12月, 2007 1 次提交
    • J
      Use a variable name as sizeof argument, not a type name. · 49230350
      Jim Meyering 提交于
      Given code like: T *var = calloc (n, sizeof (T));
      Convert to this: T *var = calloc (n, sizeof (*var));
      This first-cut change adjusts all malloc, calloc, and
      realloc statements.
      
      The only binary differences are in remote_internal.c
      (due to the bug fix) and in xmlrpc.c (due to factorization).
      
      * python/libvir.c: As above.
      * qemud/event.c: Likewise.
      * qemud/mdns.c: Likewise.
      * qemud/qemud.c: Likewise.
      * qemud/remote.c: Likewise.
      * src/bridge.c: Likewise.
      * src/buf.c: Likewise.
      * src/conf.c: Likewise.
      * src/hash.c: Likewise.
      * src/iptables.c: Likewise.
      * src/openvz_conf.c: Likewise.
      * src/qemu_conf.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/test.c: Likewise.
      * src/xen_internal.c: Likewise.
      * src/xen_unified.c: Likewise.
      * src/xm_internal.c: Likewise.
      * src/xml.c: Likewise.
      * tests/qemuxml2argvtest.c: Likewise.
      * src/xmlrpc.c (xmlRpcValuePtr): Likewise, and minor factorization.
      * src/remote_internal.c (remoteAuthMakeCredentials): Use the right
      type when allocating space for an array of cred _pointers_.
      49230350
  28. 07 12月, 2007 1 次提交
    • R
      Fri Dec 7 14:36:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com> · f1f94721
      Richard W.M. Jones 提交于
      	* src/.cvsignore: Ignore *.loT files (generated under Windows).
      	* proxy/libvirt_proxy.c: Bail out earlier --without-xen.
      	* src/proxy_internal.c: Don't build proxy client side if
      	  configured --without-xen.
      	* src/iptables.c, src/iptables.h: Disable this code if
      	  configured --without-qemu.
      	* src/nodeinfo.c: If no 'uname' function, set model name to
      	  empty string (for Windows).
      	* src/xen_unified.h, src/util.c, src/test.c: Include <winsock2.h>
      	  on Windows.
      	* src/util.c: Disable virExec* and virFileLinkPointsTo on
      	  MinGW.
      f1f94721
  29. 06 12月, 2007 2 次提交
    • J
      Use gnulib, starting with its physmem and getaddrinfo modules. · 261e7581
      Jim Meyering 提交于
      New files go into these directories:
        gnulib/lib
        gnulib/m4
        gnulib/tests
      
      * bootstrap: A wrapper around gnulib-tool.
      * configure.in: Invoke gl_EARLY and gl_INIT, being careful to put gl_EARLY
      before any macro that uses AC_COMPILE_IFELSE.
      (AC_OUTPUT): Add lib/Makefile and gl-tests/Makefile.  Remove m4/Makefile.
      * Makefile.am (SUBDIRS): Add gnulib/lib and remove m4.  Add gnulib/tests
      early enough that those tests run before any libvirt unit tests.
      * m4/Makefile.am: Remove file.  Not needed.
      * src/Makefile.am (INCLUDES): Add -I$(top_srcdir)/gnulib/lib -I../gnulib/lib.
      (LDADDS, libvirt_la_LIBADD): Add ../gnulib/lib/libgnu.la.
      * src/nodeinfo.c: Include "physmem.h".
      * qemud/qemud.c, src/remote_internal.c: Include "getaddrinfo.h".
      (MEMINFO_PATH, linuxNodeInfoMemPopulate): Remove definitions.
      (virNodeInfoPopulate): Use physmem_total, not linuxNodeInfoMemPopulate.
      * tests/Makefile.am (INCLUDES): Add -I$(top_srcdir)/gnulib/lib -I../gnulib/lib.
      (LDADDS): Add ../gnulib/lib/libgnu.la.
      * qemud/Makefile.am (libvirtd_LDADD): Add ../gnulib/lib/libgnu.la.
      * tests/nodeinfotest.c (linuxTestCompareFiles): No longer read total
      memory from a file.
      Update expected output not to include "Memory: NNNN"
      * tests/nodeinfodata/linux-nodeinfo-1.txt:
      * tests/nodeinfodata/linux-nodeinfo-2.txt:
      * tests/nodeinfodata/linux-nodeinfo-3.txt:
      * tests/nodeinfodata/linux-nodeinfo-4.txt:
      * tests/nodeinfodata/linux-nodeinfo-5.txt:
      * tests/nodeinfodata/linux-nodeinfo-6.txt:
      * src/test.c [WITH_TEST]: Remove definition of _GNU_SOURCE that
      would conflict with the one now in "config.h".
      * autogen.sh: Add -I gnulib/m4.
      * src/conf.c, src/sexpr.c: Don't define _GNU_SOURCE.
      Instead, include "config.h".
      * qemud/qemud.c: Remove definition of _GNU_SOURCE.
      * src/openvz_driver.c: Likewise.
      * src/qemu_driver.c: Likewise.
      * src/remote_internal.c: Likewise.
      
      * configure.in: Use AC_CONFIG_AUX_DIR(build-aux), so that a bunch
      of gettextize-generated files go into build-aux/, rather than in
      the top-level directory.
      * .cvsignore: Adjust.
      * build-aux/.cvsignore: New file.
      
      
      Author: Jim Meyering <meyering@redhat.com>
      261e7581
    • D
  30. 26 11月, 2007 1 次提交