Add a path for UEFI VMs for AArch32 VMs, based on the path Debian is using.
libvirt is the de facto canonical location for defining where distros
should place these firmware images, so let's define this path here to try
and minimize distro fragmentation.

The call to qemuBuildDeviceAddressStr() happens no matter
what, so we can move it to the outer possible scope inside
the function.

We can also move the call to virBufferAsprintf() after all
the checks have been performed, where it makes more sense.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>

The virDomainDeviceInfo struct is defined in device_conf,
so generic functions that operate on it should also be
defined there rather than in domain_conf.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>

Follow the same style as other similar functions.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>

All other virDomain*Def follow this naming convention for
their allocation function.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>

This patch addresses the same aspects on PPC the bug 1103314 addressed
on x86.

PCI expander bus creates multiple primary PCI busses, where each of these
busses can be assigned a specific NUMA affinity, which, on x86 is
advertised through ACPI on a per-bus basis.

For SPAPR, a PHB's NUMA affinities are assigned on a per-PHB basis, and
there is no mechanism for advertising NUMA affinities to a guest on a
per-bus basis. So, even if qemu-ppc manages to get some sort of multi-bus
topology working using PXB, there is no way to expose the affinities
of these busses to the guest. It can only be exposed on a per-PHB/per-domain
basis.

So patch enables NUMA node tag in pci-root controller on PPC.

The way to set the NUMA node is through the numa_node option of
spapr-pci-host-bridge device. However for the implicit PHB, the only way
to set the numa_node is from the -global option. The -global option applies
to all the PHBs unless explicitly specified with the option on the
respective PHB of CLI. The default PHB has the emulated devices only, so
the patch prevents setting the NUMA node for the default PHB.
Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>

The patch adds a capability for spapr-pci-host-bridge.numa_node.
Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>

Signed-off-by: NShivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>

Instead of going through two completely different code paths,
one of which repeats the same hardcoded bit of information
three times in rapid succession, depending on whether or not
a firmware list has been provided at configure time, just
provide a reasonable default value and remove the extra code.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>

There are only two acceptable places for describing enum values.
It's either:

    typedef enum {
        /* Some long description. Therefore it's placed before
         * the value. */
        VIR_ENUM_A_VAL = 1,
    } virEnumA;

or:

    typedef enum {
        VIR_ENUM_B_VAL = 1, /* Some short description */
    } virEnumB;

However, during review of a patch sent upstream I realized that
is not always the case. I went through all the public header
files and identified all the offenders. Luckily there were just
two of them.

Yes, this makes our HTML generated documentation broken, but
that's bug of the generator. Our header files shouldn't be forced
to use something we don't want to.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

'numad' may return a nodeset which contains NUMA nodes without memory
for certain configurations. Since cgroups code will not be happy using
nodes without memory we need to store only numa nodes with memory in
autoNodeset.

On the other hand autoCpuset should contain cpus also for nodes which
do not have any memory.

Remove the code from qemuProcessPrepareDomain so that it won't get even
more bloated.

Decouple them by storing them in the XML separately rather than
regenerating them. This will simplify upcoming fixes.

Move the code to separate functions to avoid complicating the existing
ones with changes.

Since virBitmapSubtract is unused modify it to perform bitmap
intersection.

Commit id 'dd9b29da' added this new variable, but didn't free it in
one instance where status was returned to the caller.

Found by Coverity

Commit id '0fe4aa14' added @origErr, but since it's assigned outside
the if condition, the free should be outside as well.

Found by Coverity

A new function virNetDevOpenvswitchUpdateVlan has been created to instruct
OVS of the changes. qemuDomainChangeNet has been modified to handle the
update of the VLAN configuration for a running guest and rely on
virNetDevOpenvswitchUpdateVlan to do the actual update if needed.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

This piece of code is going to be reused. So move it out to a
separate function.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>

Security impls of this function already raise errors, don't
overwrite them.

Preparation for switching to virFileCache where there are two callbacks,
one to get a new data and second one to load a cached data.

This also removes virQEMUCapsReset which is no longer required.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>

It's not required and following patches will change the code.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>

Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>

Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>

Cleanups the code a little bit and reduces amount of arguments passed
throughout the functions.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>

While searching for an element using a function it may be
desirable to know the element key for future operation.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>

Actually we use virConnectNodeDeviceEventGenericCallback.
Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>
Signed-off-by: NErik Skultety <eskultet@redhat.com>

At present shared disks can be migrated with either readonly or cache=none. But
cache=directsync should be safe for migration, because both cache=directsync and cache=none
don't use the host page cache, and cache=direct write through qemu block layer cache.
Signed-off-by: NPeng Hao <peng.hao2@zte.com.cn>
Reviewed-by: NWang Yechao <wang.yechao255@zte.com.cn>

Use virStorageSource accessors to check the file and call
virStorageFileAccess before even attempting to stat the target. This
will be helpful once we try to add network destinations for block copy,
since there will be no need to stat them.

Move the code into a separate function so that the flow of creating the
copy is more obvious and split into logical pieces.

Rather than using the local-file only implementation 'qemuOpenFile'
switch to the imagelabel aware storage driver implementation.

When copying to a block device, the block device will already exist. To
allow users using a block device without any preparation, they need to
use the block copy without VIR_DOMAIN_BLOCK_COPY_REUSE_EXT.

This means that if the target is an existing block device we don't need
to prepare it, but we can't reject it as being existing.

To avoid breaking this feature, explicitly assume that existing block
devices will be reused even without that flag explicitly specified,
while skipping attempts to create it.

qemuMonitorDriveMirror still needs to honor the flag as specified by the
user, since qemu overwrites the metadata otherwise.

Extract the presence of the flag into a boolean to simplify conditions
and allow further manipulation of the state of the flag.

   For attaching hosdev, we should set dev->data.hostdev
   rather than dev->data.disk
Signed-off-by: NChen Hanxiao <chenhanxiao@gmail.com>

Where it can be supported in Fedora, the driver is built and made
available as a subpackage.
Signed-off-by: NNeal Gompa <ngompa13@gmail.com>

Test that we are able to create a JSON object and nest it into a string
property of a JSON object and then correctly extract and parse it back.

Make sure that JSON strings can contain characters which need to be
escaped (double quotes, backslashes, tabs, etc.).

@remote_file, allocated by virAsprintf, was not freed and leaked.
Signed-off-by: NZhipeng Lu <lu.zhipeng@zte.com.cn>

@map_device, allocated by virAsprintf in virStorageBackendCreateVols,
was not freed and leaked.
Signed-off-by: NZhipeng Lu <lu.zhipeng@zte.com.cn>

Format the parsed string back and compare it to the original (or
modified) string for back and forth comparison.