1. 12 1月, 2015 4 次提交
  2. 09 1月, 2015 5 次提交
  3. 08 1月, 2015 7 次提交
    • P
      src/Makefile: Fix parallel build after xen_xl_disk parser introduction · 533349ff
      Pavel Hrdina 提交于
      Well, the parallel build doesn't work as there are not dependencies
      set correctly. When running 'make -j' I see this error:
      
      make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
        GEN      util/virkeymaps.h
        GEN      locking/lock_protocol.h
      make[2]: *** No rule to make target 'xenconfig/xen_xl_disk.h', needed by 'all'.  Stop.
      make[2]: *** Waiting for unfinished jobs....
        GEN      lxc/lxc_controller_dispatch.h
      
      The fix is to correctly set dependencies by letting make know that .c
      and .h are to be generated from .l. Moreover, the section is moved
      closer to the other section which uses it.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      533349ff
    • P
    • P
      Revert "src/Makefile.am: fix build breaker for xenconfig" · e662968f
      Pavel Hrdina 提交于
      This reverts commit 703ef966.
      Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
      e662968f
    • G
      vmx: Fix a VMX parsing problem · bb072e8a
      Geoff Hickey 提交于
      VMware ESX does not always set the "serialX.fileType" tag in VMX files. The
      default value for this tag is "device", and when adding a new serial port
      of this type VMware will omit the fileType tag. This caused libvirt to
      fail to parse the VMX file. Fixed by making this tag optional and using
      "device" as a default value. Also updated vmx2xmltest to test for this
      case.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      bb072e8a
    • E
      build: fix xenconfig VPATH builds · 1b21d300
      Eric Blake 提交于
      Ever since commit 2c78051a split out a helper library for the sake of
      changing CFLAGS, a VPATH build with xenconfig enabled has failed:
      
        CC       xenconfig/libvirt_xenxldiskparser_la-xen_xl_disk.lo
        ../../src/xenconfig/xen_xl_disk.l:37:21: fatal error: xen_xl.h: No such file or directory
         # include "xen_xl.h"
                   ^
        compilation terminated.
        Makefile:9462: recipe for target 'xenconfig/libvirt_xenxldiskparser_la-xen_xl_disk.lo' failed
      
      The solution is to tell the build to look for xen_xl.h relative
      to $(srcdir), since we keep that file under version control.
      
      [Not fixed here - the raw use of -Wno-unused-parameter in CFLAGS
      is NOT portable; ideally, we should be doing a configure test
      and only supplying that argument when we know the compiler supports
      -Wunused-parameter; but that's a patch for another day]
      
      [Not fixed here - there are still issues with parallel builds hitting
      a race between generating the files and trying to compile/distribute
      them]
      
      * src/Makefile.am (libvirt_xenxldiskparser_la_CFLAGS): Add another
      include directory.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      1b21d300
    • M
      qemu: Fix system pages handling in <memoryBacking/> · 732586d9
      Michal Privoznik 提交于
      In one of my previous commits (311b4a67) I've tried to allow to
      pass regular system pages to <hugepages>. However, there was a
      little bug that wasn't caught. If domain has guest NUMA topology
      defined, qemuBuildNumaArgStr() function takes care of generating
      corresponding command line. The hugepages backing for guest NUMA
      nodes is handled there too. And here comes the bug: the hugepages
      setting from XML is stored in KiB internally, however, the system
      pages size was queried and stored in Bytes. So the check whether
      these two are equal was failing even if it shouldn't.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      732586d9
    • S
      nwfilter: Add support for icmpv6 filtering · 3a3b3691
      Stefan Berger 提交于
      Make use of the ebtables functionality to be able to filter certain
      parameters of icmpv6 packets. Extend the XML parser for icmpv6 types,
      type ranges, codes, and code ranges. Extend the nwfilter documentation,
      schema, and test cases.
      
      Being able to filter icmpv6 types and codes helps extending the DHCP
      snooper for IPv6 and filtering at least some parameters of IPv6's NDP
      (Neighbor Discovery Protocol) packets. However, the filtering will not
      be as good as the filtering of ARP packets since we cannot
      check on IP addresses in the payload of the NDP packets.
      Signed-off-by: NStefan Berger <stefanb@linux.vnet.ibm.com>
      3a3b3691
  4. 07 1月, 2015 4 次提交
    • J
      Indentation · b0731790
      Ján Tomko 提交于
      b0731790
    • P
      qemu: Don't unref domain after exit from nested async job · 79bb49a8
      Peter Krempa 提交于
      In commit 540c339a the whole domain
      reference counting was refactored in the qemu driver. Domain jobs now
      don't need to reference the domain object as they now expect the
      reference from the calling function.
      
      However, the patch forgot to remove the unref call in case we exit the
      monitor when we were acquiring a nested job. This caused the daemon to
      crash on a subsequent access to the domain object once we've done an
      operation requiring a nested job for a monitor access.
      
      An easy reproducer case:
      
      1) Start a vm with qcow disks
      2) virsh snapshot-create-as DOMNAME
      3) virsh dumpxml DOMNAME
      4) daemon crashes in a semi-random spot while accessing a now-removed VM
      object.
      
      Fortunately, the commit wasn't released yet, so there are no security
      implications.
      Reported-by: NShanzi Yu <shyu@redhat.com>
      Signed-off-by: NPeter Krempa <pkrempa@redhat.com>
      79bb49a8
    • L
      conf: Don't format actual network definition in migratable XML · db19a4a3
      Luyao Huang 提交于
      https://bugzilla.redhat.com/show_bug.cgi?id=1177194
      
      When migrate a vm, we will generate a xml via qemuDomainDefFormatLive and
      pass this xml to target libvirtd. Libvirt will use the current network
      state in def->data.network.actual to generate the xml, this will make
      migrate failed when we set a network type guest interface use a macvtap
      network as a source in a vm then migrate vm to another host(which has the
      different macvtap network settings: different interface name, bridge name...)
      
      Add a flag check in virDomainNetDefFormat, if we set a VIR_DOMAIN_XML_MIGRATABLE
      flag when call virDomainNetDefFormat, we won't get the current vm interface
      state.
      Signed-off-by: NLuyao Huang <lhuang@redhat.com>
      Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
      db19a4a3
    • A
      Parallels: Add VNC hostname setup · 95170a30
      Alexander Burluka 提交于
      Add missing VNC setup via Parallels SDK.
      Parallels Cloud Server starts one VNC server per domain,
      so we could process only one VNC server definition.
      Network-based listening currently is unimplemented.
      Signed-off-by: NAlexander Burluka <aburluka@parallels.com>
      95170a30
  5. 06 1月, 2015 20 次提交