1. 01 4月, 2011 4 次提交
    • O
      qemu: Fix improper logic of qemuCgroupSetup · 0ca16a78
      Osier Yang 提交于
      It throws errors as long as the cgroup controller is not available,
      regardless of whether we really want to use it to do setup or not,
      which is not what we want, fixing it with throwing error when need
      to use the controller.
      
      And change "VIR_WARN" to "qemuReportError" for memory controller
      incidentally.
      0ca16a78
    • W
      free tmp after unlinking it · e206946d
      Wen Congyang 提交于
      We create a temporary file to save memory, and we will remove it after reading
      memory to buffer. But we free the variable that contains the temporary filename
      before we remove it. So we should free tmp after unlinking it.
      e206946d
    • M
      Fix several formatting mistakes in doc · 51434d3b
      Michal Privoznik 提交于
      51434d3b
    • D
      Remove iohelper on Win32 since it is not required · e44e8e25
      Daniel P. Berrange 提交于
      The iohelper binary is not required on Win32, although it compiles
      without trouble. Simply remove it from the RPM.
      
      * mingw32-libvirt.spec.in: Remove iohelper
      e44e8e25
  2. 31 3月, 2011 4 次提交
    • D
      Fix domain events C example on Win32 · 24219542
      Daniel P. Berrange 提交于
      printf on Win32 does not necessarily support %lld and we don't
      have GNULIBs wrapper for printf(). Switch to use asprintf() for
      which we do have a gnulib wrapper with %lld support
      
      * examples/domain-events/events-c/event-test.c: Fix formatting
        of %lld on Win32
      * cfg.mk: Don't require use of virAsprintf since this is an
        example app for out of tree users to follow
      24219542
    • E
      maint: avoid locale-sensitivity in string case comparisons · 6c9e89bb
      Eric Blake 提交于
      strcase{cmp/str} have the drawback of being sensitive to the global
      locale; this is unacceptable in a library setting.  Prefer a
      hard-coded C locale alternative for all but virsh, which is user
      facing and where the global locale isn't changing externally.
      
      * .gnulib: Update to latest, for c-strcasestr change.
      * bootstrap.conf (gnulib_modules): Drop strcasestr, add c-strcase
      and c-strcasestr.
      * cfg.mk (sc_avoid_strcase): New rule.
      (exclude_file_name_regexp--sc_avoid_strcase): New exception.
      * src/internal.h (STRCASEEQ, STRCASENEQ, STRCASEEQLEN)
      (STRCASENEQLEN): Adjust offenders.
      * src/qemu/qemu_monitor_text.c (qemuMonitorTextEjectMedia):
      Likewise.
      * tools/virsh.c (namesorter): Document exception.
      6c9e89bb
    • E
      docs: mention C89 syntax preferences · 06732e1a
      Eric Blake 提交于
      * docs/hacking.html.in (Code formatting): Document that // comment
      and declaration-after-statement are discouraged.
      * HACKING: Regenerate.
      06732e1a
    • J
      qemu: Fix media eject with qemu-0.12.* · e586f574
      Jiri Denemark 提交于
      In qemu-0.12.* "device '...' is locked" message was changed to "Device
      ..." so libvirt was no longer detecting this as an error.
      e586f574
  3. 30 3月, 2011 6 次提交
    • D
      The next release is 0.9.0 not 0.8.9 · 6c8f2475
      Daniel Veillard 提交于
      Fix this which went into documentation
      6c8f2475
    • W
      check whether qemuMonitorJSONHMP() failed · 0ecfa7f2
      Wen Congyang 提交于
      If qemu quited unexpectedly when we call qemuMonitorJSONHMP(),
      libvirt will crash.
      Steps to reproduce this bug:
      1. use gdb to attach libvirtd, and set a breakpoint in the function
         qemuMonitorSetCapabilities()
      2. start a vm
      3. let the libvirtd to run until qemuMonitorJSONSetCapabilities() returns.
      4. kill the qemu process
      5. continue running libvirtd
      Signed-off-by: NWen Congyang <wency@cn.fujitsu.com>
      0ecfa7f2
    • W
      do not send monitor command after monitor meet error · cc2424fc
      Wen Congyang 提交于
      If the monitor met a error, and we will call qemuProcessHandleMonitorEOF().
      But we may try to send monitor command after qemuProcessHandleMonitorEOF()
      returned. Then libvirtd will be blocked in qemuMonitorSend().
      
      Steps to reproduce this bug:
      1. use gdb to attach libvirtd, and set a breakpoint in the function
         qemuConnectMonitor()
      2. start a vm
      3. let the libvirtd to run until qemuMonitorOpen() returns.
      4. kill the qemu process
      5. continue running libvirtd
      Signed-off-by: NWen Congyang <wency@cn.fujitsu.com>
      cc2424fc
    • H
      qemu: unlock qemu driver before return from domain save · 025e1998
      Hu Tao 提交于
      qemuDriverUnlock() wasn't called on 2 exit paths
      * src/qemu/qemu_driver.c: fix qemudDomainSave() to always unlock
        the driver before exiting on error
      025e1998
    • N
      extend logging to record configuration-related changes · 343a27af
      Naoya Horiguchi 提交于
      Currently libvirt's default logging is limited and it is difficult to
      determine what was happening when a proglem occurred (especially on a
      machines where one don't know the detail.)  This patch helps to do that
      by making additional logging available for the following events:
      
        creating/defining/undefining domains
        creating/defining/undefining/starting/stopping networks
        creating/defining/undefining/starting/stopping storage pools
        creating/defining/undefining/starting/stopping storage volumes.
      
      * AUTHORS: add Naoya Horiguchi
      * src/network/bridge_driver.c src/qemu/qemu_driver.c
        src/storage/storage_driver.c: provide more VIR_INFO logging
      343a27af
    • D
      Add libvirt_iohelper to spec file · 1613912d
      Daniel Veillard 提交于
      The new iohelper binary was missing from the packaging spec
      1613912d
  4. 29 3月, 2011 26 次提交
    • O
      cputune: New tests for cputune XML · 079ae9c7
      Osier Yang 提交于
      v1 - v2:
        * Add missed tests/qemuxml2argvdata/qemuxml2argv-cputune.args
      079ae9c7
    • O
      cputune: Support cputune for xend driver · 01692bb1
      Osier Yang 提交于
      Not sure if it's the correct way to add cputune xml for xend driver,
      and besides, seems "xm driver" and "xen hypervisor" also support
      vcpu affinity, do we need to add support for them too?
      01692bb1
    • O
      cputune: Support cputune for lxc driver · e98eb7f4
      Osier Yang 提交于
      LXC driver doesn't support vcpu affinity yet, so just need
      to modify it to support cpu shares.
      e98eb7f4
    • O
      cputune: Support cputune for qemu driver · 1cc4d025
      Osier Yang 提交于
      When domain startup, setting cpu affinity and cpu shares according
      to the cputune xml specified in domain xml.
      
      Modify "qemudDomainPinVcpu" to update domain config for vcpupin,
      and modify "qemuSetSchedulerParameters" to update domain config
      for cpu shares.
      
      v1 - v2:
         * Use "VIR_ALLOC_N" instead of "VIR_ALLOC_VAR"
         * But keep raising error when it fails on adding vcpupin xml
           entry, as I still don't have a better idea yet.
      1cc4d025
    • O
      cputune: Implementations of parsing and formating cputune xml · b8853925
      Osier Yang 提交于
      Implementations of following functions:
        virDomainVcpupinIsDuplicate
        virDomainVcpupinFindByVcpu
        virDomainVcpupinAdd
      
      Update "virDomainDefParseXML" to parse, and "virDomainDefFormatXML"
      to build cputune xml, also implementations of new internal helper
      functions.
      
      v1 - v2:
        * Resolve potential crash bug of "virDomainVcpupinAdd"
      b8853925
    • O
      cputune: Add data structures presenting cputune XML · 853f0fdf
      Osier Yang 提交于
      Also related new functions' declaration, and expose the new introduced
      functions in libvirt_private.syms.
      
      v1 - v2:
        Don't expose "virAllocVar" in libvirt_private.syms
      853f0fdf
    • O
      cputune: Add document for cputune XML · 6b364420
      Osier Yang 提交于
      v1 - v3:
        * More clear document for "cpu shares", adopted suggestions from
          Matthias Bottle and Daniel Veillard.
      6b364420
    • O
      cputune: Add XML schema for cputune xml · e3ea8828
      Osier Yang 提交于
      v1 - v2:
        * Remove upper limit of cpu shares. (Suggested by Matthias Bottle)
      e3ea8828
    • E
      qemu: fix regression with fd labeling on migration · daa6aa68
      Eric Blake 提交于
      My earlier testing for commit 34fa0de0 was done while starting
      just-built libvirt from an unconfined_t shell, where the fds happened
      to work when transferring to qemu.  But when installed and run under
      virtd_t, failure to label the raw file (with no compression) or the
      pipe (with compression) triggers SELinux failures when passing fds
      over SCM_RIGHTS to svirt_t qemu.
      
      * src/qemu/qemu_migration.c (qemuMigrationToFile): When passing
      FDs, make sure they are labeled.
      daa6aa68
    • E
      qemu: improve error message on failed fd transfer · 285e8a17
      Eric Blake 提交于
      First fallout of fd: migration - it looks like SELinux enforcing
      _does_ require fd labeling (running uninstalled libvirtd from an
      unconstrained shell had no problems, but once faked out by doing
       chcon `stat -c %C /usr/sbin/libvirtd` daemon/libvirtd
       run_init $PWD/daemon/libvirtd
      to run it with the same context as an init script service, and with
      SELinux enforcing, I got a rather confusing failure:
      error: Failed to save domain fedora_12 to fed12.img
      error: internal error unable to send TAP file handle: No file descriptor supplied via SCM_RIGHTS
      
      This fixes the error message, then I need to figure out a subsequent
      patch that does the fsetfilecon() necessary to keep things happy.
      It also appears that libvirtd hangs on a failed fd transfer; I don't
      know if that needs an independent fix.
      
      * src/qemu/qemu_monitor_text.c (qemuMonitorTextSendFileHandle):
      Improve message, since TAP is no longer only client.
      285e8a17
    • E
      maint: ignore new built file · e54a2f93
      Eric Blake 提交于
      * .gitignore: Exclude libvirt_iohelper.
      e54a2f93
    • M
      Add domainSuspend/Resume to libxl driver · 6ebcb0c7
      Markus Groß 提交于
      * src/libxl/libxl_driver.c: implements libxlDomainSuspend and
        libxlDomainResume
      6ebcb0c7
    • M
      Add domainGetOSType to libxl driver · f367a1df
      Markus Groß 提交于
      * src/libxl/libxl_driver.c: implements libxlDomainGetOSType
      f367a1df
    • M
      Add domainGetSchedulerType to libxl driver · d53bca48
      Markus Groß 提交于
      * src/libxl/libxl_driver.c: implements libxlDomainGetSchedulerType
      d53bca48
    • M
      Implements domainXMLTo/FromNative in libxl driver · 02449771
      Markus Groß 提交于
      * src/Makefile.am src/libvirt_private.syms configure.ac: share and
        reuse the sexpr routines from sexpr.h of the old xen driver
      * src/libxl/libxl_driver.c: implements libxlDomainXMLFromNative and
        libxlDomainXMLToNative
      02449771
    • M
      Add vcpu functions to libxl driver · 3d6fe99c
      Markus Groß 提交于
      Hook the virtual cpu functions to their libxenlight counterparts
      
      * src/libxl/libxl_driver.c: implements libxlDomainSetVcpus,
        libxlDomainGetVcpus, libxlDomainSetVcpusFlags,
        libxlDomainGetVcpusFlags and libxlDomainPinVcpu
      3d6fe99c
    • M
      List authors in copyright headers · cbf2717c
      Markus Groß 提交于
      * src/libxl/libxl_conf.[ch] src/libxl/libxl_driver.[ch]: add authors
        after the licence template
      cbf2717c
    • M
      Add event callbacks to libxl driver · 68e10323
      Markus Groß 提交于
      * src/libxl/libxl_conf.h: add the necessary fields to the driver
        private structure
      * src/libxl/libxl_driver.c: add lifecycle event support and entry
        points for event(de)register(any)
      68e10323
    • M
      Ignore return value of virDomainObjUnref · 6d60ca5d
      Markus Groß 提交于
      * src/libxl/libxl_driver.c: use ignore_value() in libxlDomainObjUnref
        and libxlCreateDomEvents
      6d60ca5d
    • D
      Fix infinite loop in daemon if client quits with multiple streams open · 88416593
      Daniel P. Berrange 提交于
      The daemon loops over the linked list of streams when a client
      quits, closing any that the client hadn't already closed. Except
      it didn't ever move to the next element in the list!
      
      * daemon/stream.c: Fix loop over linked list of streams
      88416593
    • D
      Remote protocol support for storage vol upload/download APIs · 230a5d8b
      Daniel P. Berrange 提交于
      * daemon/remote.c, src/remote/remote_driver.c: Implementation
        of storage vol upload/download APIs
      * src/remote/remote_protocol.x: Wire protocol definition for
        upload/download
      * daemon/remote_dispatch_args.h, daemon/remote_dispatch_prototypes.h,
        daemon/remote_dispatch_table.h, src/remote/remote_protocol.h,
        src/remote/remote_protocol.c: Re-generate
      230a5d8b
    • D
      Support volume data upload/download APIs in storage driver · 92563962
      Daniel P. Berrange 提交于
      Use generic FD streams to allow data upload/download to/from
      any storage volume
      
      * src/storage/storage_driver.c: Wire up upload/download APIs
      92563962
    • D
      Add vol-upload and vol-download commands to virsh · 6299ca71
      Daniel P. Berrange 提交于
      The new commands vol-upload and vol-download, allow a local file
      to be transferred to/from a storage volume.
      
      * tools/virsh.c: Add vol-upload and vol-download commands
      * tools/virsh.pod: Document new commands
      6299ca71
    • D
      Add public APIs for storage volume upload/download · 7300f68d
      Daniel P. Berrange 提交于
      New APIs are added allowing streaming of content to/from
      storage volumes.
      
      * include/libvirt/libvirt.h.in: Add virStorageVolUpload and
        virStorageVolDownload APIs
      * src/driver.h, src/libvirt.c, src/libvirt_public.syms: Stub
        code for new APIs
      * src/storage/storage_driver.c, src/esx/esx_storage_driver.c:
        Add dummy entries in driver table for new APIs
      7300f68d
    • D
      Enhance the streams helper to support plain file I/O · e886237a
      Daniel P. Berrange 提交于
      The O_NONBLOCK flag doesn't work as desired on plain files
      or block devices. Introduce an I/O helper program that does
      the blocking I/O operations, communicating over a pipe that
      can support O_NONBLOCK
      
      * src/fdstream.c, src/fdstream.h: Add non-blocking I/O
        on plain files/block devices
      * src/Makefile.am, src/util/iohelper.c: I/O helper program
      * src/qemu/qemu_driver.c, src/lxc/lxc_driver.c,
        src/uml/uml_driver.c, src/xen/xen_driver.c: Update for
        streams API change
      e886237a
    • D
      Update event loop example programs to demonstrate best practice · 0c97e70b
      Daniel P. Berrange 提交于
      The example C event loop code is a nasty hack and not compliant
      with the require API semantics. Delete this, so that developers
      don't mistakenly copy it. Instead call the new public event loop
      APIs.
      
      Update the python event loop example, so that it can optionally
      use the public event APIs, as an alternative to the pure python
      code. The pure python event code is a good working example, so
      don't delete it.
      
      Also make the python example use a read only connection to avoid
      authentication prompts
      
      * examples/domain-events/events-c/event-test.c: Replace event
        loop code with use of public APIs
      * examples/domain-events/events-python/event-test.py: Allow
        optional use of new public event APIs
      0c97e70b