1. 12 10月, 2010 5 次提交
    • J
      xen: Fix virDomain{At,De}tachDevice · 093973aa
      Jiri Denemark 提交于
      According to API documentation virDomain{At,De}tachDevice calls are
      supposed to only work on active guests for device hotplug. For anything
      beyond that, their *Flags variants have to be used.
      
      Despite the variant which was acked on libvirt mailing list
      (https://www.redhat.com/archives/libvir-list/2010-January/msg00385.html)
      commit ed9c14a7 (by Jim Fehlig)
      introduced automagic behavior of these API calls for xen driver. Since
      January, these calls always change persistent configuration of a guest
      and if the guest is currently active, they also hot(un)plug the device.
      
      That change didn't follow API documentation and also broke device
      hot(un)plug for older xend implementations which do not support changing
      persistent configuration of a guest and hot(un)plugging in one step.
      
      This patch should not break anything for active guests. On the other
      hand, changing inactive guests is not supported any more.
      093973aa
    • J
      xen: xenXMDomain*DeviceFlags should obey all flags · e2856d36
      Jiri Denemark 提交于
      xenXMDomain*DeviceFlags() silently ignores requests to modify live
      configuration of an active guest while still touching its persistent
      configuration.
      e2856d36
    • J
      xen: Fix logic bug in xenDaemon*DeviceFlags · 6ab99b8a
      Jiri Denemark 提交于
      6ab99b8a
    • J
      xen: Make xenDaemon*DeviceFlags errors less confusing · 28160e22
      Jiri Denemark 提交于
      When a user calls to virDomain{Attach,Detach,Update}DeviceFlags() with
      flags == VIR_DOMAIN_DEVICE_MODIFY_LIVE on an inactive guest running on
      an old Xen hypervisor (such as RHEL-5) xend_internal driver reports:
      
          Xend version does not support modifying persistent config
      
      which is pretty confusing since no-one requested to modify persistent
      config.
      28160e22
    • G
  2. 09 10月, 2010 1 次提交
  3. 07 10月, 2010 6 次提交
  4. 06 10月, 2010 2 次提交
    • E
      build: require pkg-config for bootstrap · b0f34a6a
      Eric Blake 提交于
      * .gnulib: Update to latest, for bootstrap fixes.
      * bootstrap: Synchronize with upstream.
      * bootstrap.conf: Add pkg-config pre-requisite.
      * autogen.sh: Tweak wording message.
      Reported by Justin Clift, and with feedback from Bruno Haible.
      b0f34a6a
    • J
      xen: Fix bogus error when attaching a device · ad4cb905
      Jiri Denemark 提交于
      The xm internal xen driver only supports disk and network devices to be
      added to a guest. On an attempt to attach any other device the xm driver
      used VIR_ERR_XML_ERROR which resulted in a completely bogus error
      message:
      
      error: Failed to attach device from pci.xml
      error: XML description for unknown device is not well formed or invalid
      ad4cb905
  5. 05 10月, 2010 1 次提交
  6. 04 10月, 2010 1 次提交
  7. 02 10月, 2010 2 次提交
    • M
      esx: Add support for virtual serial device network backing · 02e11b83
      Matthias Bolte 提交于
      Since version 4.1 ESX(i) can expose virtual serial devices over TCP.
      
      Add support in the VMX handling code for this, add test cases to cover
      it and add links to some documentation.
      
      ESX supports two additional protocols: TELNETS and TLS. Add them to
      the list of serial-over-TCP protocols.
      02e11b83
    • E
      vcpu: improve cpuset attribute · 62a50a0b
      Eric Blake 提交于
      The <vcpu cpuset=...> attribute has been available since commit
      e193b5dd, but without documentation or RNG validation.
      
      * docs/schemas/domain.rng (vcpu): Further validate cpuset.
      * docs/formatdomain.html.in: Document it.
      * src/conf/domain_conf.c: Fix typos.
      62a50a0b
  8. 01 10月, 2010 9 次提交
    • M
      phyp: Verify that domain XML contains at least one disk element · 53a2f725
      Matthias Bolte 提交于
      phypBuildLpar expects that at least one disk element is provided.
      53a2f725
    • J
      virt-aa-helper-test cleanups · 091075a3
      Jamie Strandboge 提交于
      Don't cat | sed, just sed.  Suggested by Eric Blake.
      091075a3
    • J
      implement usb and pci hot attach in AppArmor driver · 593e0072
      Jamie Strandboge 提交于
      Description: Implement AppArmorSetSecurityHostdevLabel() and
      AppArmorRestoreSecurityHostdevLabel() for hostdev and pcidev attach.
      
      virt-aa-helper also has to be adjusted because *FileIterate() is used for pci
      and usb devices and the corresponding XML for hot attached hostdev and pcidev
      is not in the XML passed to virt-aa-helper. The new '-F filename' option is
      added to append a rule to the profile as opposed to the existing '-f
      filename', which rewrites the libvirt-<uuid>.files file anew. This new '-F'
      option will append a rule to an existing libvirt-<uuid>.files if it exists,
      otherwise it acts the same as '-f'.
      
      load_profile() and reload_profile() have been adjusted to add an 'append'
      argument, which when true will use '-F' instead of '-f' when executing
      virt-aa-helper.
      
      All existing calls to load_profile() and reload_profile() have been adjusted
      to use the old behavior (ie append==false) except AppArmorSetSavedStateLabel()
      where it made sense to use the new behavior.
      
      This patch also adds tests for '-F'.
      
      Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/640993
      593e0072
    • S
      nwfilter: Add a test case for testing the comment attribute · f0954246
      Stefan Berger 提交于
      This patch adds a test case for testing the XML parser's and instantiator's
      support of the comment attribute.
      f0954246
    • S
      nwfilter: Extend docs with information about comment attr. · 4bb2b16d
      Stefan Berger 提交于
      I am adding a row with information about the newly supported comment
      attribute to each of the tables describing supported attributes of protocols.
      4bb2b16d
    • S
      nwfilter: Extend nwfilter schema to accept comment attrib. · 44ae2279
      Stefan Berger 提交于
      Extend the nwfilter.rng schema to accept comment attributes for all protocol
      types.
      44ae2279
    • S
      nwfilter: Instantiate comments in ip(6)tables rules · b00f41a1
      Stefan Berger 提交于
      In this patch I am extending the rule instantiator to create the comment
      node where supported, which is the case for iptables and ip6tables.
      
      Since commands are written in the format
      
      cmd='iptables ...-m comment --comment \"\" '
      
      certain characters ('`) in the comment need to be escaped to
      prevent comments from becoming commands themselves or cause other
      forms of (bash) substitutions. I have tested this with various input and in
      my tests the input made it straight into the comment. A test case for TCK
      will be provided separately that tests this.
      b00f41a1
    • S
      nwfilter: Extend XML parser and generator w/ comment attribute · ec3d03db
      Stefan Berger 提交于
      The patch below extends the XML parser and generator so that every protocol
      now can have a comment node. Comments are limited to 256 characters.
      ec3d03db
    • E
      build: fix example build on MacOS X · f8db6c90
      Eric Blake 提交于
      Partial reversion of commit 76d87a59, now that bootstrap is smarter.
      
      * .gnulib: Update to latest, for poll and bootstrap fixes.
      * bootstrap: Resync from gnulib.
      * autogen.sh: Drop redundant tool checks; bootstrap does them
      better, by honoring environment variables.
      * examples/domain-events/events-c/Makefile.am (INCLUDES)
      (event_test_LDADD): Use gnulib library during build.
      * bootstrap.conf (gnulib_tool_option_extras): Revert --libtool
      addition, now that updated bootstrap does it for us.
      Reported by Justin Clift.
      f8db6c90
  9. 29 9月, 2010 5 次提交
    • E
      phyp: Checking for NULL values when building new guest · ee2cb983
      Eduardo Otubo 提交于
      When creating a new gust, the function phypBuildLpar() was not
      checking for NULL values
      
      src/phyp/phyp_driver.c: check the definition arguments to avoid a segmentation
        fault in phypBuildLpar()
      ee2cb983
    • J
      configure: tweak logic flow of virtport check · 8bd11f37
      Justin Clift 提交于
      This fixes a small logic bug, where passing --without-macvtap
      on the configure line, or otherwise indicating a lack of
      support for macvtap, causes configure to bail.
      8bd11f37
    • J
      mpath: disable devmapper-multipath checking on non-linux · fc812dd9
      Justin Clift 提交于
      The configure script was breaking on MacOS X unless passed:
      
        --without-storage-mpath
      
      This patch leverages Stefan Bergers earlier work for nwfilter,
      so non-linux systems don't even attempt to build multipath.
      fc812dd9
    • S
      Rework configure logic for virtualport support · b502a6eb
      Stefan Berger 提交于
      In this patch I am reworking the logic around detecting virtual port support and requiring the libnl dependency.
      
      - It requires --with-macvtap and displays an error in case of --without-macvtap --with-virtualport.
      - It tests for availability of certain data in include files and displays an error in case the include file is not at the correct level and --with-virtualport was chosen
      - displays 'checking' messages for macvtap and virtualport support and results
      - libnl support is required when macvtap is found or requested; if libnl is not there, please supply without-macvtap
      b502a6eb
    • J
      mac os x: use awk selected by build system rather than first in path · 81e329eb
      Justin Clift 提交于
      Prior to this patch, the ChangeLog generation was hard coded to use
      "awk", when it should have been using the AWK variable set by our
      build system.
      
      This breaks compilation on a newly installed OS X system, where the
      default path has the Mac (non GNU) awk in the default search PATH
      before any installed GNU awk (gawk).
      81e329eb
  10. 28 9月, 2010 4 次提交
  11. 27 9月, 2010 1 次提交
  12. 25 9月, 2010 1 次提交
    • S
      nwfilter: report if ip(6)tables rules would not be active · 570d0404
      Stefan Berger 提交于
      The patch below reports a warning in the log if the generated ip(6)tables rules would not be effective due to the proc filesystem entries
      
          /proc/sys/net/bridge/bridge-nf-call-iptables
          /proc/sys/net/bridge/bridge-nf-call-ip6tables
      
      containing a '0'. The warning tells the user what to do. I am rate-limiting the warning message to appear only every 10 seconds.
      570d0404
  13. 24 9月, 2010 2 次提交