- 08 3月, 2017 5 次提交
-
-
由 John Ferlan 提交于
Move all the NWFilterObj API's into their own module virnwfilterobj from the nwfilter_conf Purely code motion at this point, plus adjustments to cleanly build.
-
由 John Ferlan 提交于
Rather than pass the nwfilter object, just pass the def to the function
-
由 John Ferlan 提交于
There's no need to pass the driver pointer to nwfilter_conf, just pass the configDir.
-
由 John Ferlan 提交于
Found by Coverity. Because there's an "if ((cur = strstr(base, "revision")) != NULL) {" followed by a "base = cur" coverity notes that 'base' could then be NULL causing the return to the top of the "while ((tmp_base = strstr(base, "processor")) != NULL) {" to have strstr deref a NULL 'base' pointer because the setting of base at the bottom of the loop is unconditional. Alter the code to set "base = cur" after processing each key. That will "ensure" that base doesn't get set to NULL if both "cpu" and "revision" do no follow a "processor". While a /proc/cpuinfo file that has a "processor" key but with neither a "cpu" nor a "revision" doesn't seem feasible, the code is written as if it could happen, so we have to account for it. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Calls to virFileReadAll after a VIR_ALLOC that return NULL all show a memory leak since 'ret' isn't virSysinfoDefFree'd and normal path "return ret" doesn't free outbuf. Reported by Coverity Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
- 07 3月, 2017 12 次提交
-
-
由 Cole Robinson 提交于
-
由 Cole Robinson 提交于
$ virsh vol-clone /tmp/test.iso new.iso error: Failed to clone vol from test.iso error: internal error: Child process (/bin/qemu-img convert -f iso -O iso /tmp/test.iso /tmp/new.iso) unexpected exit status 1: qemu-img: Could not open '/tmp/test.iso': Unknown driver 'iso' Map iso->raw before sending the format value to qemu-img https://bugzilla.redhat.com/show_bug.cgi?id=972784 https://bugzilla.redhat.com/show_bug.cgi?id=1419395
-
由 Pavel Hrdina 提交于
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Pavel Hrdina 提交于
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Peter Krempa 提交于
Since the kernel does not report much data for that box the sysinfo output is comparatively sparse.
-
由 Peter Krempa 提交于
There's no reason why we should avoid running all sysinfo tests on all platforms. Refactor the test to get rid of the conditionally compiled cruft.
-
由 Peter Krempa 提交于
virSysinfoSetup should be used only in tests so it can be moved to the new header file rather than using an extern declaration.
-
由 Peter Krempa 提交于
Whole implementations along with helper totalling screens of code were conditionally compiled. That made the code totally unreadable and untestable. Rename functions to have the architecture in the name so that all can be compiled at the same time and introduce header to allow testing them all.
-
由 Pavel Hrdina 提交于
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Laine Stump 提交于
Proposed formal coding conventions encourage defining typedefs for vir[Blah] and vir[Blah]Ptr separately from the associated struct named _vir[Blah]: typedef struct _virBlah virBlah; typedef virBlah *virBlahPtr; struct _virBlah { ... }; At some point in the past, I had submitted several patches using a more compact style that I prefer, and they were accepted: typedef struct _virBlah { ... } virBlah, *virBlahPtr; Since these are by far a minority among all struct definitions, this patch changes all those definitions to reflect the style prefered by the proposal so that there is 100% consistency.
-
由 Daniel P. Berrange 提交于
Ensure virsystemdpriv.h gets included in dist tarballs. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Nitesh Konkar 提交于
Signed-off-by: NNitesh Konkar <nitkon12@linux.vnet.ibm.com>
-
- 06 3月, 2017 14 次提交
-
-
由 Ján Tomko 提交于
Test virSystemd APIs twice to check the cache effects.
-
由 Ján Tomko 提交于
After the system has been booted, it should not change. Cache the return value of virSystemdHasMachined. Allow starting and terminating machines with just one DBus call, instead of three, reducing the chance of the call timing out. Also introduce a small function for resetting the cache to be used in tests.
-
由 Ján Tomko 提交于
This hides the unused third parameter from every line and prepares for resetting the environment after each test case in the future.
-
由 Ján Tomko 提交于
Both virSystemdTerminateMachine and virSystemdCreateMachine propagate the error to tell between a non-systemd system and a hard error. In virSystemdGetMachineNameByPID both are treated the same, but an error is ignored by the callers. Split out the checks into a separate function.
-
由 John Ferlan 提交于
Make common helpers testNetworkObjFindByUUID and testStoragePoolObjFindByUUID which will replace the repeated patter for each to find objects by UUID. As a bonus, the error message processing will also provide the failed uuidstr rather than a generic error message.
-
由 John Ferlan 提交于
Rather than have multiple places using the same pattern to find a network by name using virNetworkObjFindByName, create a common helper which will provide a consistent error message as well.
-
由 John Ferlan 提交于
Rather than have continued repeated sequences of : testDriverLock() xxx = vir*ObjFindByName() testDriverUnlock() if (xxx == NULL) { virReportError goto cleanup; } Make some common helpers which will use the pattern and make a single reference using a single common error message. Altered for Interfaces, Storage Pools, Storage Volumes, and Node Devices. For each the common error message can now also indicate which 'name' was not found. For Storage Volumes, the "new" error will be more specific rather than just invalid argument.
-
由 John Ferlan 提交于
In an effort to be consistent with the source module, alter the function prototypes to follow the similar style of source with the "type" on one line followed by the function name and arguments on subsequent lines with with argument getting it's own line.
-
由 John Ferlan 提交于
Use "virInterfaceObj" as a prefix for any external API in virinterfaceobj
-
由 John Ferlan 提交于
Alter the format of the code to follow more recent style guidelines of two empty lines between functions, function decls with "[static] type" on one line followed by function name with arguments to functions each on one line.
-
由 John Ferlan 提交于
Move all the InterfaceObj API's into their own module virinterfaceobj from the interface_conf Purely code motion at this point.
-
由 Michal Privoznik 提交于
Now that we have some qemuSecurity wrappers over virSecurityManager APIs, lets make sure everybody sticks with them. We have them for a reason and calling virSecurityManager API directly instead of wrapper may lead into accidentally labelling a file on the host instead of namespace. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Jiri Denemark 提交于
Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
-
由 Jiri Denemark 提交于
The implementation matches virStringListFreeCount. The only difference between the two functions is the ordering of their parameters. Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
-
- 04 3月, 2017 9 次提交
-
-
由 John Ferlan 提交于
Changes in commit id 'dec6d9df' caused a compilation failure on a RHEL6 CI build environment. So just replace 'system' with 'syscap' as a name. cc1: warnings being treated as errors ../../src/conf/node_device_conf.c: In function 'virNodeDevCapSystemParseXML': ../../src/conf/node_device_conf.c:1415: error: declaration of 'system' shadows a global declaration [-Wshadow]
-
由 John Ferlan 提交于
Replace with more data specific pointer types.
-
由 John Ferlan 提交于
Rather than a bunch of embedded union structs, let's create structs for each of the structs within the union and make the struct easier to read.
-
由 John Ferlan 提交于
In an effort to be consistent with the source module, alter the function prototypes to follow the similar style of source with the "type" on one line followed by the function name and arguments on subsequent lines with with argument getting it's own line.
-
由 John Ferlan 提交于
Use "virNodeDeviceObj" as a prefix for any external API in virnodedeviceobj
-
由 John Ferlan 提交于
Alter the format of the code to follow more recent style guidelines of two empty lines between functions, function decls with "[static] type" on one line followed by function name with arguments to functions each on one line.
-
由 John Ferlan 提交于
Move all the NodeDeviceObj API's into their own module virnodedeviceobj from the node_device_conf Purely code motion at this point, plus adjustments to cleanly build.
-
由 Matwey V. Kornilov 提交于
AArch64 kernels are technically capable of running armv7l binaries. Though some vendors disable this feature during kernel build, we need to allow it in LXC. Signed-off-by: NMatwey V. Kornilov <matwey.kornilov@gmail.com>
-
由 Jiri Denemark 提交于
Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
-