1. 24 4月, 2010 2 次提交
    • E
      build: don't include winsock2.h on cygwin · 004aee63
      Eric Blake 提交于
      Under cygwin, winsock2.h is intentionally incompatible with,
      <sys/socket.h>, and checking for existence is wrong.
      
      Under mingw, HAVE_WINSOCK2_H is defined on our behalf by
      gnulib, in a way that does not interfere with cygwin.
      
      * configure.ac: Drop unnecessary header check.
      Reported by Matthias Bolte.
      004aee63
    • L
      QEmu JSON drop timestamp from command object · eb9b6532
      Luiz Capitulino 提交于
      It's not needed and is currently ignored, but this is a bug.
      
      It will get fixed soon and QMP will return an error for keys
      it doesn't know about, this will break libvirt.
      
      * src/qemu/qemu_monitor_json.c: remove qemuMonitorJSONCommandAddTimestamp()
        and the place where it's invoked in qemuMonitorJSONMakeCommand()
      eb9b6532
  2. 23 4月, 2010 14 次提交
    • S
      nwfilter: extend schema + add testcase w/ connlimit-above · 9db01465
      Stefan Berger 提交于
      I am extending the schema with the recently added connlimit-above
      attribute and adding a test case for it to the test suite.
      9db01465
    • M
      maint: update AUTHORS · 2aed290e
      Marco Bozzolan 提交于
      * AUTHORS: Use preferred name.
      Signed-off-by: NEric Blake <eblake@redhat.com>
      2aed290e
    • D
      Fix crash in nwfilter driver check · 98bd5e6c
      Daniel P. Berrange 提交于
      The nwfilterDriverActive() could de-reference a NULL pointer
      if it hadn't be started at the point it was called. It was
      also not thread safe, since it lacked locking around data
      accesses.
      
      * src/nwfilter/nwfilter_driver.c: Fix locking & NULL checks
        in nwfilterDriverActive()
      98bd5e6c
    • E
      addrToString: give better error message · 3022375d
      Eric Blake 提交于
      The user probably doesn't care what the gai error numbers are, as
      much as what the failed conversion IP address was.
      
      * src/remote/remote_driver.c (addrToString): Mention which address
      could not be converted.
      * daemon/remote.c (addrToString): Likewise.
      3022375d
    • E
      maint: update AUTHORS with recent contributors · 2a82a33e
      Eric Blake 提交于
      git shortlog $(git log -1 --format=%H AUTHORS).. | grep -v "^ "
      
      then add missing entries to AUTHORS.
      
      * AUTHORS: Update.
      2a82a33e
    • S
      qemu: fix security context references in DAC code · c85c9b3a
      Spencer Shimko 提交于
      * The error messages coming from qemu's DAC support contain strings
        from the original SELinux security driver code.  This just removes
        references to "security context" and other SELinux-isms from the DAC
        code.
      Signed-off-by: NSpencer Shimko <sshimko@tresys.com>
      Signed-off-by: NEric Blake <eblake@redhat.com>
      c85c9b3a
    • S
      Changes from V1 to V2: · 647c26c8
      Stefan Berger 提交于
       - using INT_BUFSIZE_BOUND() to determine the length of the buffersize
      for printing and integer into
      
       - not explicitly initializing static var threadsTerminate to false
      anymore, since that's done automatically
      
      Changes after V2:
        - removed while looks in case of OOM error
        - removed on ifaceDown() call
        - preceding one ifaceDown() call with an ifaceCheck() call
      
      Since the name of an interface can be the same between stops and starts
      of different VMs I have to switch the IP address learning thread to use
      the index of the interface to determine whether an interface is still
      available or not - in the case of macvtap the thread needs to listen for
      traffic on the physical interface, thus having to time out periodically
      to check whether the VM's macvtap device is still there as an indication
      that the VM is still alive. Previously the following sequence of 2 VMs
      with macvtap device
      
      virsh start testvm1; virsh destroy testvm1 ; virsh start testvm2
      
      would not terminate the thread upon testvm1's destroy since the name of
      the interface on the host could be the same (i.e, macvtap0) on testvm1
      and testvm2, thus it was easily race-able. The thread would then
      determine the IP address parameter for testvm2 but apply the rule set
      for testvm1. :-(
      I am also introducing a lock for the interface (by name) that the thread
      must hold while it listens for the traffic and releases when it
      terminates upon VM termination or 0.5 second thereafter. Thus, the new
      thread for a newly started VM with the same interface name will not
      start while the old one still holds the lock. The only other code that I
      see that also needs to grab the lock to serialize operation is the one
      that tears down the firewall that were established on behalf of an
      interface.
      
      I am moving the code applying the 'basic' firewall rules during the IP
      address learning phase inside the thread but won't start the thread
      unless it is ensured that the firewall driver has the ability to apply
      the 'basic' firewall rules.
      647c26c8
    • D
      Properly indent encryption tags · 68529bc5
      David Allan 提交于
      * Fix for the bug reported at:
      
      https://bugzilla.redhat.com/show_bug.cgi?id=573908
      68529bc5
    • J
      Fix locking in qemudDomainCoreDump · 96ac1859
      Jiri Denemark 提交于
      The hang fix in d376b7d6 was incomplete
      since it left quite a few {Enter,Exit}Monitor calls which require driver
      to be unlocked. Since the driver is locked throughout the whole
      function, {Enter,Exit}MonitorWithDriver need to be used instead to
      ensure driver is not locked when issuing monitor commands.
      96ac1859
    • J
      Poll for migration end every 50ms instead of 50us · e2c05948
      Jiri Denemark 提交于
      The comment in qemuDomainWaitForMigrationComplete says we are polling
      every 50ms but the code sleeps only for 50us. This was already discussed
      during review but apparently forgotten when the series was pushed.
      e2c05948
    • S
      configure.ac SELinux fixes · e5c668a0
      Spencer Shimko 提交于
      * Fix a logic error in configure.ac that prevented --with-selinux=no
        from being used with --with-secdriver-selinux=no.
      
      * Fix some strings to clarify the difference between --with-selinux
        and --with-secdriver-selinux.
      Signed-off-by: NSpencer Shimko <sshimko@tresys.com>
      Signed-off-by: NEric Blake <eblake@redhat.com>
      e5c668a0
    • D
      Fix QEMU text monitor command error checking · 9772beba
      Daniel P. Berrange 提交于
      The text monitor code was checking for a '\n' prefix on several
      places. Previously this would work, but since the monitor code
      re-write the '\n' is already stripped off, so mustn't be checked
      for.
      
      * src/qemu/qemu_monitor_text.c: Fix monitor error checking
      9772beba
    • D
      Fix CPU hotplug command names · a980d123
      Daniel P. Berrange 提交于
      Probably as a result of a merge error, the CPU hotplug command
      names were completely wrong.
      
      * src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_text.c: Fix
        the CPU hotplug command names
      a980d123
    • D
      Fix printing of event detail in python events demo program · de8ecb12
      Daniel P. Berrange 提交于
      The events demo program is slightly misleading printing
      
        myDomainEventCallback1 EVENT: Domain f14i686(-1) Added
      
      which is not distinguishing Add vs Update events. It should have
      been doing
      
        myDomainEventCallback1 EVENT: Domain f14i686(-1) Defined Updated
      
      * examples/domain-events/events-python/event-test.py: Fully print
        event detail info string
      de8ecb12
  3. 22 4月, 2010 13 次提交
  4. 21 4月, 2010 10 次提交
  5. 20 4月, 2010 1 次提交
    • P
      Install nwfilter xml files from source directory. · 8b3a89c4
      Philipp Hahn 提交于
      During an out-of-tree build, the current working directory is the build
      directory. Since the FILTERS are static and not modified or
      auto-generated during the build process, they need to be explicitly
      fetched from the source directory during install.
      
      Prefix the files with $(srcdir), which gets expanded to the absolute or
      relative path to the source directory, even when duing out-of-tree
      builds.
      Signed-off-by: NPhilipp Hahn <hahn@univention.de>
      8b3a89c4