提交 f1b4021b 编写于 作者: D Daniel P. Berrange

Don't ignore return value of qemuProcessKill

When calling qemuProcessKill from the virDomainDestroy impl
in QEMU, do not ignore the return value. This ensures that
if QEMU fails to respond to SIGKILL, the caller will know
about the failure.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
上级 36c1fc18
...@@ -2012,7 +2012,11 @@ qemuDomainDestroyFlags(virDomainPtr dom, ...@@ -2012,7 +2012,11 @@ qemuDomainDestroyFlags(virDomainPtr dom,
goto cleanup; goto cleanup;
} }
} else { } else {
ignore_value(qemuProcessKill(driver, vm, VIR_QEMU_PROCESS_KILL_FORCE)); if (qemuProcessKill(driver, vm, VIR_QEMU_PROCESS_KILL_FORCE) < 0) {
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
_("failed to kill qemu process with SIGTERM"));
goto cleanup;
}
} }
/* We need to prevent monitor EOF callback from doing our work (and sending /* We need to prevent monitor EOF callback from doing our work (and sending
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册