提交 e3293406 编写于 作者: P Pavel Mores 提交者: Michal Privoznik

qemu: call networkPlugBandwidth() for all types of network

To fix the actual bug, it was necessary to make networkPlugBandwidth() be
called also for 'bridge'-type networks implemented using macvtap's 'bridge'
mode (previously it was only called for those implemented on top of an
existing bridge).

However, it seems beneficial to call it for other network types as well, at
least because it removes an inconsistency in types of bandwidth configuration
changes permissible in inactive and active domain configs.  It should also be
safe as the function pretty much amounts to NOP if no QoS is requested and the
new behaviour should not be any worse than before if it is.
Signed-off-by: NPavel Mores <pmores@redhat.com>
Reviewed-by: NMichal Privoznik <mprivozn@redhat.com>
上级 aa985af2
......@@ -4571,8 +4571,6 @@ networkAllocatePort(virNetworkObjPtr obj,
return -1;
}
if (networkPlugBandwidth(obj, &port->mac, port->bandwidth, &port->class_id) < 0)
return -1;
break;
case VIR_NETWORK_FORWARD_HOSTDEV: {
......@@ -4637,8 +4635,6 @@ networkAllocatePort(virNetworkObjPtr obj,
}
}
if (networkPlugBandwidth(obj, &port->mac, port->bandwidth, &port->class_id) < 0)
return -1;
break;
}
......@@ -4736,6 +4732,11 @@ networkAllocatePort(virNetworkObjPtr obj,
return -1;
}
if (networkPlugBandwidth(obj, &port->mac, port->bandwidth,
&port->class_id) < 0)
return -1;
if (virNetworkObjMacMgrAdd(obj, driver->dnsmasqStateDir,
port->ownername, &port->mac) < 0)
return -1;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册