提交 e2705cfb 编写于 作者: M Martin Kletzander

qemu: Make qemuDomainCheckDiskStartupPolicy self-contained

There is an error reset following the function and check for
startupPolicy before that.  Let's reflect those things inside that
function so that future code doesn't have to be that complex.
Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
上级 2ee5c6ed
...@@ -4192,6 +4192,7 @@ qemuDomainCheckDiskStartupPolicy(virQEMUDriverPtr driver, ...@@ -4192,6 +4192,7 @@ qemuDomainCheckDiskStartupPolicy(virQEMUDriverPtr driver,
return -1; return -1;
break; break;
case VIR_DOMAIN_STARTUP_POLICY_DEFAULT:
case VIR_DOMAIN_STARTUP_POLICY_MANDATORY: case VIR_DOMAIN_STARTUP_POLICY_MANDATORY:
return -1; return -1;
...@@ -4200,14 +4201,13 @@ qemuDomainCheckDiskStartupPolicy(virQEMUDriverPtr driver, ...@@ -4200,14 +4201,13 @@ qemuDomainCheckDiskStartupPolicy(virQEMUDriverPtr driver,
return -1; return -1;
break; break;
case VIR_DOMAIN_STARTUP_POLICY_DEFAULT:
case VIR_DOMAIN_STARTUP_POLICY_LAST: case VIR_DOMAIN_STARTUP_POLICY_LAST:
/* this should never happen */ /* this should never happen */
break; break;
} }
qemuDomainCheckRemoveOptionalDisk(driver, vm, diskIndex); qemuDomainCheckRemoveOptionalDisk(driver, vm, diskIndex);
virResetLastError();
return 0; return 0;
} }
...@@ -4241,12 +4241,8 @@ qemuDomainCheckDiskPresence(virQEMUDriverPtr driver, ...@@ -4241,12 +4241,8 @@ qemuDomainCheckDiskPresence(virQEMUDriverPtr driver,
if (qemuDomainDetermineDiskChain(driver, vm, disk, true, true) >= 0) if (qemuDomainDetermineDiskChain(driver, vm, disk, true, true) >= 0)
continue; continue;
if (disk->startupPolicy && if (qemuDomainCheckDiskStartupPolicy(driver, vm, idx, cold_boot) >= 0)
qemuDomainCheckDiskStartupPolicy(driver, vm, idx,
cold_boot) >= 0) {
virResetLastError();
continue; continue;
}
goto error; goto error;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册