提交 dcbedfa6 编写于 作者: L Laine Stump

test: Fix actual vs. expected in virtTestCompareFiles

Commit ca329299 added a utility function virtTestCompareFiles() to
eliminate repetitive code in several test programs. It unfortunately
calls virtTestDifference() with the arguments in the wrong order -
strcontent is the "actual" output gathered by the test rig, while
filecontent is the "expected", and virtTestDifference() wants expected
(filecontent) followed by actual (strcontent), but
virtTestCompareFiles() does the opposite, which can make the output a
bit confusing when there is a failure.
上级 d8082d2d
/*
* testutils.c: basic test utils
*
* Copyright (C) 2005-2014 Red Hat, Inc.
* Copyright (C) 2005-2015 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
......@@ -641,7 +641,7 @@ virtTestCompareToFile(const char *strcontent,
goto failure;
goto out;
}
virtTestDifference(stderr, strcontent, filecontent);
virtTestDifference(stderr, filecontent, strcontent);
goto failure;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册